summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFei Wang <wangzfei@google.com>2023-11-30 15:59:25 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2023-11-30 15:59:25 +0000
commit3377593ed636bdff5b7f546bca9500b9286d9a67 (patch)
tree741c3fdafdea8f8a1ed6375312de57201ae49bbb
parent78368d452cca8a204d0378c09ee114eb3b1f7ad8 (diff)
parent080dabd386ba659e304d04bc612306a30eeac422 (diff)
downloadvcard-3377593ed636bdff5b7f546bca9500b9286d9a67.tar.gz
Merge "Default to OTHER if label is unknown" into main
-rw-r--r--java/com/android/vcard/VCardUtils.java4
-rw-r--r--tests/src/com/android/vcard/tests/VCardImporterTests.java4
2 files changed, 4 insertions, 4 deletions
diff --git a/java/com/android/vcard/VCardUtils.java b/java/com/android/vcard/VCardUtils.java
index 5890fb4..aa335d3 100644
--- a/java/com/android/vcard/VCardUtils.java
+++ b/java/com/android/vcard/VCardUtils.java
@@ -253,8 +253,8 @@ public class VCardUtils {
if (hasPref) {
type = Phone.TYPE_MAIN;
} else {
- // default to TYPE_HOME
- type = Phone.TYPE_HOME;
+ // default to TYPE_OTHER
+ type = Phone.TYPE_OTHER;
}
}
if (isFax) {
diff --git a/tests/src/com/android/vcard/tests/VCardImporterTests.java b/tests/src/com/android/vcard/tests/VCardImporterTests.java
index b4713d0..6ec02b6 100644
--- a/tests/src/com/android/vcard/tests/VCardImporterTests.java
+++ b/tests/src/com/android/vcard/tests/VCardImporterTests.java
@@ -674,7 +674,7 @@ public class VCardImporterTests extends VCardTestsBase {
.put(Phone.TYPE, Phone.TYPE_HOME)
.put(Phone.NUMBER, "404-555-1212");
elem.addExpected(Phone.CONTENT_ITEM_TYPE)
- .put(Phone.TYPE, Phone.TYPE_FAX_HOME)
+ .put(Phone.TYPE, Phone.TYPE_OTHER_FAX)
.put(Phone.NUMBER, "4045551212,*#55");
elem.addExpected(Phone.CONTENT_ITEM_TYPE)
.put(Phone.TYPE, Phone.TYPE_MOBILE)
@@ -1379,7 +1379,7 @@ public class VCardImporterTests extends VCardTestsBase {
.put(StructuredName.DISPLAY_NAME, "Pause Wait");
// See PhoneNumberUtils in Android SDK.
elem.addExpected(Phone.CONTENT_ITEM_TYPE)
- .put(Phone.TYPE, Phone.TYPE_HOME)
+ .put(Phone.TYPE, Phone.TYPE_OTHER)
.put(Phone.NUMBER, ",1234,5678;9");
}