diff options
author | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2023-07-07 07:16:56 +0000 |
---|---|---|
committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2023-07-07 07:16:56 +0000 |
commit | c0cc8b0d805c1f5ae42c11498e75378d6abf8b32 (patch) | |
tree | a85f0aebda6323f25951bba64272fccba9821150 | |
parent | a83a9a8ab054912a3a26e5901b636070d30ac051 (diff) | |
parent | 8e9a212552c9096cfeccaacd65dea1d1bca88107 (diff) | |
download | slang-aml_odp_341610000.tar.gz |
Snap for 10453938 from 8e9a212552c9096cfeccaacd65dea1d1bca88107 to mainline-odp-releaseaml_odp_341717000aml_odp_341610000
Change-Id: I273893d14138e1d9dd0d73ada4a4d3c2f322563c
-rw-r--r-- | OWNERS | 5 | ||||
-rw-r--r-- | slang_rs_export_type.cpp | 6 |
2 files changed, 7 insertions, 4 deletions
@@ -1,5 +1,2 @@ -butlermichael@google.com -dgross@google.com -jeanluc@google.com -miaowang@google.com +include platform/frameworks/rs:/RS_OWNERS # Bug component: 43047 srhines@google.com diff --git a/slang_rs_export_type.cpp b/slang_rs_export_type.cpp index afeb6c5..ffe8ffc 100644 --- a/slang_rs_export_type.cpp +++ b/slang_rs_export_type.cpp @@ -333,6 +333,8 @@ static const clang::Type *TypeExportableHelper( // // TODO(zonr/srhines): allow bit fields of size 8, 16, 32 if (FD->isBitField()) { + // Context can be null from NormalizeType? + slangAssert(Context); Context->ReportError( FD->getLocation(), "bit fields are not able to be exported: '%0.%1'") @@ -415,6 +417,8 @@ static const clang::Type *TypeExportableHelper( case clang::Type::Enum: { // FIXME: We currently convert enums to integers, rather than reflecting // a more complete (and nicer type-safe Java version). + // Context can be null from NormalizeType? + slangAssert(Context); return Context->getASTContext().IntTy.getTypePtr(); } default: { @@ -797,6 +801,8 @@ llvm::StringRef RSExportType::GetTypeName(const clang::Type* T) { const clang::PointerType *P = static_cast<const clang::PointerType*>(CTI); const clang::Type *PT = GetPointeeType(P); llvm::StringRef PointeeName; + // Passing nullptr as Context to NormalizeType can cause TypeExportableHelper + // to dereference a null Context? if (NormalizeType(PT, PointeeName, nullptr, nullptr, NotLegacyKernelArgument)) { char *Name = new char[ 1 /* * */ + PointeeName.size() + 1 ]; |