1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
# Copyright 2024 The ChromiumOS Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Shared utilities for working with git."""
import contextlib
import logging
from pathlib import Path
import re
import shlex
import subprocess
import tempfile
from typing import Generator, Iterable, List
# Email address used to tag the detective as a reviewer.
REVIEWER_DETECTIVE = "c-compiler-chrome@google.com"
def _parse_cls_from_upload_output(upload_output: str) -> List[int]:
"""Returns the CL number in the given upload output."""
id_regex = re.compile(
r"^remote:\s+https://chromium-review\S+/\+/(\d+)\s", re.MULTILINE
)
results = id_regex.findall(upload_output)
if not results:
raise ValueError(
f"Wanted at least one match for {id_regex} in {upload_output!r}; "
"found 0"
)
return [int(x) for x in results]
def upload_to_gerrit(
git_repo: Path,
remote: str,
branch: str,
reviewers: Iterable[str] = (),
cc: Iterable[str] = (),
ref: str = "HEAD",
) -> List[int]:
"""Uploads `ref` to gerrit, optionally adding reviewers/CCs."""
# https://gerrit-review.googlesource.com/Documentation/user-upload.html#reviewers
# for more info on the `%` params.
option_list = [f"r={x}" for x in reviewers]
option_list += (f"cc={x}" for x in cc)
if option_list:
trailing_options = "%" + ",".join(option_list)
else:
trailing_options = ""
run_result = subprocess.run(
[
"git",
"push",
remote,
# https://gerrit-review.googlesource.com/Documentation/user-upload.html#reviewers
# for more info on the `%` params.
f"{ref}:refs/for/{branch}{trailing_options}",
],
cwd=git_repo,
check=False,
stdin=subprocess.DEVNULL,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
encoding="utf-8",
)
logging.info(
"`git push`ing %s to %s/%s had this output:\n%s",
ref,
remote,
branch,
run_result.stdout,
)
run_result.check_returncode()
return _parse_cls_from_upload_output(run_result.stdout)
def try_set_autosubmit_labels(cwd: Path, cl_id: int) -> None:
"""Sets autosubmit on a CL. Logs - not raises - on failure.
This sets a series of convenience labels on the given cl_number, so landing
it (e.g., for the detective) is as easy as possible.
Args:
cwd: the directory that the `gerrit` tool should be run in. Anywhere in
a ChromeOS tree will do. The `gerrit` command fails if it isn't run
from within a ChromeOS tree.
cl_id: The CL number to apply labels to.
"""
gerrit_cl_id = str(cl_id)
gerrit_commands = (
["gerrit", "label-as", gerrit_cl_id, "1"],
["gerrit", "label-cq", gerrit_cl_id, "1"],
["gerrit", "label-v", gerrit_cl_id, "1"],
)
for cmd in gerrit_commands:
# Run the gerrit commands inside of toolchain_utils, since `gerrit`
# needs to be run inside of a ChromeOS tree to work. While
# `toolchain-utils` can be checked out on its own, that's not how this
# script is expeted to be used.
return_code = subprocess.run(
cmd,
cwd=cwd,
check=False,
stdin=subprocess.DEVNULL,
).returncode
if return_code:
logging.warning(
"Failed to run gerrit command %s. Ignoring.",
shlex.join(cmd),
)
@contextlib.contextmanager
def create_worktree(git_directory: Path) -> Generator[Path, None, None]:
"""Creates a temp worktree of `git_directory`, yielding the result."""
with tempfile.TemporaryDirectory(prefix="update_kernel_afdo_") as t:
tempdir = Path(t)
logging.info(
"Establishing worktree of %s in %s", git_directory, tempdir
)
subprocess.run(
[
"git",
"worktree",
"add",
"--detach",
"--force",
tempdir,
],
cwd=git_directory,
check=True,
stdin=subprocess.DEVNULL,
)
try:
yield tempdir
finally:
# Explicitly `git worktree remove` here, so the parent worktree's
# metadata is cleaned up promptly.
subprocess.run(
[
"git",
"worktree",
"remove",
"--force",
tempdir,
],
cwd=git_directory,
check=False,
stdin=subprocess.DEVNULL,
)
|
