diff options
author | android-build-team Robot <android-build-team-robot@google.com> | 2017-08-02 17:43:06 +0000 |
---|---|---|
committer | android-build-team Robot <android-build-team-robot@google.com> | 2017-08-02 17:43:06 +0000 |
commit | e35ab478ea3ecfed570fcd6bfeb0ab9b2de8b31e (patch) | |
tree | d43b3a99ec9feff195c9227868c823164eb443a8 | |
parent | 342a87008c378cb7ff3a9f0fa6967ef5f4818063 (diff) | |
parent | 32d12c8417752eeb9c109ce9e37c60e06390e0f0 (diff) | |
download | skia-nougat-mr1.6-release.tar.gz |
Merge cherrypicks of [2647896, 2647897, 2647437, 2647438, 2647439, 2647440, 2647441, 2647442, 2647443, 2647444, 2647916, 2647421, 2647898, 2647899, 2647936, 2647937, 2647938, 2647939, 2647940, 2647941, 2647942, 2647943, 2647944, 2647945, 2647946, 2647947, 2647948, 2647949, 2647917, 2647950, 2647900, 2647445, 2647901, 2647902, 2647903, 2647446, 2647422, 2647423, 2647424, 2647425, 2647426, 2647427, 2647428, 2647447] into nyc-mr1-security-f-releaseandroid-7.1.1_r56nougat-mr1.6-release
Change-Id: Ibe22dfbf39bde68ce56890d6c185cece8b954e97
-rw-r--r-- | resources/invalid_images/b38116746.ico | bin | 0 -> 1024 bytes | |||
-rw-r--r-- | src/codec/SkIcoCodec.cpp | 13 | ||||
-rw-r--r-- | tests/BadIcoTest.cpp | 1 |
3 files changed, 11 insertions, 3 deletions
diff --git a/resources/invalid_images/b38116746.ico b/resources/invalid_images/b38116746.ico Binary files differnew file mode 100644 index 0000000000..35ee5b5a28 --- /dev/null +++ b/resources/invalid_images/b38116746.ico diff --git a/src/codec/SkIcoCodec.cpp b/src/codec/SkIcoCodec.cpp index dc4222a43c..8b3d26dd86 100644 --- a/src/codec/SkIcoCodec.cpp +++ b/src/codec/SkIcoCodec.cpp @@ -14,6 +14,7 @@ #include "SkStream.h" #include "SkTDArray.h" #include "SkTSort.h" +#include "../private/SkTemplates.h" /* * Checks the start of the stream to see if the image is an Ico or Cur @@ -128,12 +129,18 @@ SkCodec* SkIcoCodec::NewFromStream(SkStream* stream) { bytesRead = offset; // Create a new stream for the embedded codec - SkAutoTUnref<SkData> data( - SkData::NewFromStream(inputStream.get(), size)); - if (nullptr == data.get()) { + SkAutoFree buffer(sk_malloc_flags(size, 0)); + if (!buffer.get()) { + SkCodecPrintf("Warning: OOM trying to create embedded stream.\n"); + break; + } + + if (inputStream->read(buffer.get(), size) != size) { SkCodecPrintf("Warning: could not create embedded stream.\n"); break; } + + SkAutoTUnref<SkData> data(SkData::NewFromMalloc(buffer.detach(), size)); SkAutoTDelete<SkMemoryStream> embeddedStream(new SkMemoryStream(data.get())); bytesRead += size; diff --git a/tests/BadIcoTest.cpp b/tests/BadIcoTest.cpp index c387e157be..f6b1c469cc 100644 --- a/tests/BadIcoTest.cpp +++ b/tests/BadIcoTest.cpp @@ -22,6 +22,7 @@ DEF_TEST(BadImage, reporter) { "ico_fuzz1.ico", "skbug3442.webp", "skbug3429.webp", + "b38116746.ico", }; const char* badImagesFolder = "invalid_images"; |