diff options
Diffstat (limited to 'pw_file/flat_file_system.cc')
| -rw-r--r-- | pw_file/flat_file_system.cc | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/pw_file/flat_file_system.cc b/pw_file/flat_file_system.cc index 9960bd348..ce57a2d84 100644 --- a/pw_file/flat_file_system.cc +++ b/pw_file/flat_file_system.cc @@ -73,12 +73,12 @@ void FlatFileSystemService::EnumerateAllFiles(RawServerWriter& writer) { Status write_status = writer.Write(encoder); if (!write_status.ok()) { writer.Finish(write_status) - .IgnoreError(); // TODO(b/242598609): Handle Status properly + .IgnoreError(); // TODO: b/242598609 - Handle Status properly return; } } writer.Finish(OkStatus()) - .IgnoreError(); // TODO(b/242598609): Handle Status properly + .IgnoreError(); // TODO: b/242598609 - Handle Status properly } void FlatFileSystemService::List(ConstByteSpan request, @@ -92,10 +92,9 @@ void FlatFileSystemService::List(ConstByteSpan request, } std::string_view file_name_view; - if (!decoder.ReadString(&file_name_view).ok() || - file_name_view.length() == 0) { + if (!decoder.ReadString(&file_name_view).ok() || file_name_view.empty()) { writer.Finish(Status::DataLoss()) - .IgnoreError(); // TODO(b/242598609): Handle Status properly + .IgnoreError(); // TODO: b/242598609 - Handle Status properly return; } @@ -103,7 +102,7 @@ void FlatFileSystemService::List(ConstByteSpan request, Result<Entry*> result = FindFile(file_name_view); if (!result.ok()) { writer.Finish(result.status()) - .IgnoreError(); // TODO(b/242598609): Handle Status properly + .IgnoreError(); // TODO: b/242598609 - Handle Status properly return; } @@ -111,12 +110,12 @@ void FlatFileSystemService::List(ConstByteSpan request, Status proto_encode_status = EnumerateFile(*result.value(), encoder); if (!proto_encode_status.ok()) { writer.Finish(proto_encode_status) - .IgnoreError(); // TODO(b/242598609): Handle Status properly + .IgnoreError(); // TODO: b/242598609 - Handle Status properly return; } writer.Finish(writer.Write(encoder)) - .IgnoreError(); // TODO(b/242598609): Handle Status properly + .IgnoreError(); // TODO: b/242598609 - Handle Status properly return; } |