parameter-framework: Fix incremental build issueandroid-cts_7.1_r1android-cts-7.1_r9android-cts-7.1_r8android-cts-7.1_r7android-cts-7.1_r6android-cts-7.1_r5android-cts-7.1_r4android-cts-7.1_r3android-cts-7.1_r29android-cts-7.1_r28android-cts-7.1_r27android-cts-7.1_r26android-cts-7.1_r25android-cts-7.1_r24android-cts-7.1_r23android-cts-7.1_r22android-cts-7.1_r21android-cts-7.1_r20android-cts-7.1_r2android-cts-7.1_r19android-cts-7.1_r18android-cts-7.1_r17android-cts-7.1_r16android-cts-7.1_r15android-cts-7.1_r14android-cts-7.1_r13android-cts-7.1_r12android-cts-7.1_r11android-cts-7.1_r10android-cts-7.1_r1android-cts-7.0_r9android-cts-7.0_r8android-cts-7.0_r7android-cts-7.0_r6android-cts-7.0_r5android-cts-7.0_r4android-cts-7.0_r33android-cts-7.0_r32android-cts-7.0_r31android-cts-7.0_r30android-cts-7.0_r3android-cts-7.0_r29android-cts-7.0_r28android-cts-7.0_r27android-cts-7.0_r26android-cts-7.0_r25android-cts-7.0_r24android-cts-7.0_r23android-cts-7.0_r22android-cts-7.0_r21android-cts-7.0_r20android-cts-7.0_r2android-cts-7.0_r19android-cts-7.0_r18android-cts-7.0_r17android-cts-7.0_r16android-cts-7.0_r15android-cts-7.0_r14android-cts-7.0_r13android-cts-7.0_r12android-cts-7.0_r11android-cts-7.0_r10android-cts-7.0_r1android-7.1.2_r9android-7.1.2_r8android-7.1.2_r6android-7.1.2_r5android-7.1.2_r4android-7.1.2_r39android-7.1.2_r38android-7.1.2_r37android-7.1.2_r36android-7.1.2_r33android-7.1.2_r32android-7.1.2_r30android-7.1.2_r3android-7.1.2_r29android-7.1.2_r28android-7.1.2_r27android-7.1.2_r25android-7.1.2_r24android-7.1.2_r23android-7.1.2_r2android-7.1.2_r19android-7.1.2_r18android-7.1.2_r17android-7.1.2_r16android-7.1.2_r15android-7.1.2_r14android-7.1.2_r13android-7.1.2_r12android-7.1.2_r11android-7.1.2_r10android-7.1.2_r1android-7.1.1_r9android-7.1.1_r8android-7.1.1_r7android-7.1.1_r61android-7.1.1_r60android-7.1.1_r6android-7.1.1_r59android-7.1.1_r58android-7.1.1_r57android-7.1.1_r56android-7.1.1_r55android-7.1.1_r54android-7.1.1_r53android-7.1.1_r52android-7.1.1_r51android-7.1.1_r50android-7.1.1_r49android-7.1.1_r48android-7.1.1_r47android-7.1.1_r46android-7.1.1_r45android-7.1.1_r44android-7.1.1_r43android-7.1.1_r42android-7.1.1_r41android-7.1.1_r40android-7.1.1_r4android-7.1.1_r39android-7.1.1_r38android-7.1.1_r35android-7.1.1_r33android-7.1.1_r32android-7.1.1_r31android-7.1.1_r3android-7.1.1_r28android-7.1.1_r27android-7.1.1_r26android-7.1.1_r25android-7.1.1_r24android-7.1.1_r23android-7.1.1_r22android-7.1.1_r21android-7.1.1_r20android-7.1.1_r2android-7.1.1_r17android-7.1.1_r16android-7.1.1_r15android-7.1.1_r14android-7.1.1_r13android-7.1.1_r12android-7.1.1_r11android-7.1.1_r10android-7.1.1_r1android-7.1.0_r7android-7.1.0_r6android-7.1.0_r5android-7.1.0_r4android-7.1.0_r3android-7.1.0_r2android-7.1.0_r1android-7.0.0_r9android-7.0.0_r8android-7.0.0_r7android-7.0.0_r6android-7.0.0_r5android-7.0.0_r4android-7.0.0_r36android-7.0.0_r35android-7.0.0_r34android-7.0.0_r33android-7.0.0_r32android-7.0.0_r31android-7.0.0_r30android-7.0.0_r3android-7.0.0_r29android-7.0.0_r28android-7.0.0_r27android-7.0.0_r24android-7.0.0_r21android-7.0.0_r19android-7.0.0_r17android-7.0.0_r15android-7.0.0_r14android-7.0.0_r13android-7.0.0_r12android-7.0.0_r11android-7.0.0_r10android-7.0.0_r1nougat-releasenougat-mr2.3-releasenougat-mr2.2-releasenougat-mr2.1-releasenougat-mr2-security-releasenougat-mr2-releasenougat-mr2-pixel-releasenougat-mr2-devnougat-mr1.8-releasenougat-mr1.7-releasenougat-mr1.6-releasenougat-mr1.5-releasenougat-mr1.4-releasenougat-mr1.3-releasenougat-mr1.2-releasenougat-mr1.1-releasenougat-mr1-volantis-releasenougat-mr1-security-releasenougat-mr1-releasenougat-mr1-flounder-releasenougat-mr1-devnougat-mr1-cts-releasenougat-mr0.5-releasenougat-dr1-releasenougat-devnougat-cts-releasenougat-bugfix-release

Fix incremental build issue where libremote-processor
was not rebuilt when changing the networking mode support.

This can cause a crash at runtime when starting the AudioPolicyEngine.

Change-Id: I3b4fc0924eb9f891b8e06690ac23bdd3f2055291
Signed-off-by: Di Folco, Neil <neil.di.folco@intel.com>

6 files changed, 24 insertions, 32 deletions

diff --git a/Android.mk b/Android.mk
index ba3d0c1..ce73637 100644
--- a/Android.mk
+++ b/Android.mk
@@ -34,6 +34,7 @@ ifneq ($(USE_CUSTOM_PARAMETER_FRAMEWORK), true)
 #
 ifeq ($(TARGET_BUILD_VARIANT),user)
 PFW_NETWORKING := false
+PFW_NETWORKING_SUFFIX := -no-networking
 endif
 
 LOCAL_PATH := $(call my-dir)
@@ -96,7 +97,4 @@ endif #ifneq ($(PFW_NETWORKING),false)
 include $(LOCAL_PATH)/XmlGenerator.mk
 include $(LOCAL_PATH)/Schemas.mk
 
-# Clear variables for further use
-PFW_NETWORKING :=
-
 endif #ifneq ($(USE_CUSTOM_PARAMETER_FRAMEWORK), true)
diff --git a/LibParameter.mk b/LibParameter.mk
index d773321..fa7d26f 100644
--- a/LibParameter.mk
+++ b/LibParameter.mk
@@ -142,13 +142,12 @@ LOCAL_COPY_HEADERS := $(common_copy_headers)
 
 LOCAL_C_INCLUDES := $(LOCAL_EXPORT_C_INCLUDE_DIRS)
 
-LOCAL_SHARED_LIBRARIES := libremote-processor$(SUFFIX)
+LOCAL_SHARED_LIBRARIES := libremote-processor$(PFW_NETWORKING_SUFFIX)$(SUFFIX)
 LOCAL_C_INCLUDES += \
     external/libxml2/include \
     external/icu/icu4c/source/common
 
-LOCAL_CFLAGS := -frtti -isystem
-LOCAL_CPPFLAGS += -fexceptions
+LOCAL_CFLAGS := -frtti -fexceptions
 
 LOCAL_STATIC_LIBRARIES := \
     libpfw_utility$(SUFFIX) \
diff --git a/LibPfwUtility.mk b/LibPfwUtility.mk
index 25d4155..d2b3fbe 100644
--- a/LibPfwUtility.mk
+++ b/LibPfwUtility.mk
@@ -38,17 +38,17 @@ LOCAL_SRC_FILES := \
     upstream/utility/DynamicLibrary.cpp \
     upstream/utility/posix/DynamicLibrary.cpp \
     upstream/utility/Tokenizer.cpp \
-    upstream/utility/Utility.cpp \
+    upstream/utility/Utility.cpp
 
 target_copy_headers := \
     upstream/utility/NonCopyable.hpp \
     upstream/utility/ErrorContext.hpp \
     upstream/utility/Utility.h \
-    upstream/utility/convert.hpp \
+    upstream/utility/convert.hpp
 
 LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/upstream/utility/
 LOCAL_C_INCLUDES := $(LOCAL_PATH)/upstream/utility/
-LOCAL_CFLAGS += -frtti -fexceptions
+LOCAL_CFLAGS := -frtti -fexceptions
 
 LOCAL_COPY_HEADERS := $(target_copy_headers)
 
diff --git a/LibRemoteProcessor.mk b/LibRemoteProcessor.mk
index 0b033e7..ed437ee 100644
--- a/LibRemoteProcessor.mk
+++ b/LibRemoteProcessor.mk
@@ -32,7 +32,7 @@ else
 SUFFIX :=
 endif
 
-LOCAL_MODULE := libremote-processor$(SUFFIX)
+LOCAL_MODULE := libremote-processor$(PFW_NETWORKING_SUFFIX)$(SUFFIX)
 LOCAL_MODULE_CLASS := SHARED_LIBRARIES
 LOCAL_SRC_FILES := \
     upstream/remote-processor/RequestMessage.cpp \
@@ -46,8 +46,7 @@ LOCAL_EXPORT_C_INCLUDE_DIRS := \
     $(LOCAL_PATH)/support/android/remote-processor/
 
 LOCAL_STATIC_LIBRARIES := libpfw_utility$(SUFFIX)
-LOCAL_CFLAGS := -frtti -isystem
-LOCAL_CPPFLAGS += -fexceptions
+LOCAL_CFLAGS := -frtti -fexceptions
 
 LOCAL_C_INCLUDES := $(LOCAL_EXPORT_C_INCLUDE_DIRS)
 
@@ -58,13 +57,12 @@ LOCAL_C_INCLUDES += $(LOCAL_PATH)/upstream/asio/stub
 else
 
 LOCAL_C_INCLUDES += \
-    $(LOCAL_PATH)/asio/include \
     $(LOCAL_PATH)/support/android/asio
 
-LOCAL_CFLAGS +=  \
-    -DASIO_STANDALONE -frtti \
-    -DASIO_DISABLE_STD_SYSTEM_ERROR -fexceptions
+LOCAL_CFLAGS :=  \
+    -frtti -fexceptions \
+    -isystem $(LOCAL_PATH)/asio/include
 
-endif #ifneq ($(PFW_NETWORKING),false)
+endif #ifeq ($(PFW_NETWORKING),false)
 
-LOCAL_CLANG := true
\ No newline at end of file
+LOCAL_CLANG := true
diff --git a/RemoteProcess.mk b/RemoteProcess.mk
index 8dae0e4..d30020f 100644
--- a/RemoteProcess.mk
+++ b/RemoteProcess.mk
@@ -32,7 +32,7 @@ else
 SUFFIX :=
 endif
 
-LOCAL_MODULE := remote_process$(SUFFIX)
+LOCAL_MODULE := remote-process$(SUFFIX)
 LOCAL_MODULE_CLASS := EXECUTABLES
 LOCAL_SRC_FILES := upstream/remote-process/main.cpp
 LOCAL_C_INCLUDES := \
@@ -40,10 +40,9 @@ LOCAL_C_INCLUDES := \
     $(LOCAL_PATH)/support/android/asio
 
 LOCAL_CFLAGS := \
-    -DASIO_STANDALONE -frtti -isystem \
-    $(LOCAL_PATH)/asio/include -DASIO_DISABLE_STD_SYSTEM_ERROR \
-    -fexceptions
+    -frtti -fexceptions \
+    -isystem $(LOCAL_PATH)/asio/include
 
-LOCAL_SHARED_LIBRARIES := libremote-processor$(SUFFIX)
+LOCAL_SHARED_LIBRARIES := libremote-processor$(PFW_NETWORKING_SUFFIX)$(SUFFIX)
 
-LOCAL_CLANG := true
\ No newline at end of file
+LOCAL_CLANG := true
diff --git a/TestPlatform.mk b/TestPlatform.mk
index 7a8dc5d..dbba719 100644
--- a/TestPlatform.mk
+++ b/TestPlatform.mk
@@ -43,24 +43,22 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH)/upstream/test/test-platform
 LOCAL_STATIC_LIBRARIES := libpfw_utility$(SUFFIX)
 LOCAL_SHARED_LIBRARIES := \
     libparameter$(SUFFIX) \
-    libremote-processor$(SUFFIX)
+    libremote-processor$(PFW_NETWORKING_SUFFIX)$(SUFFIX)
 
 ifeq ($(PFW_NETWORKING),false)
 
 LOCAL_C_INCLUDES += $(LOCAL_PATH)/upstream/asio/stub
-LOCAL_CFLAGS := -frtti -isystem
-LOCAL_CPPFLAGS += -fexceptions
+LOCAL_CFLAGS := -frtti -fexceptions
 
 else
 
 LOCAL_C_INCLUDES += \
-    $(LOCAL_PATH)/asio/include \
     $(LOCAL_PATH)/support/android/asio
 
-LOCAL_CFLAGS +=  \
-    -DASIO_STANDALONE -frtti -isystem \
-    -DASIO_DISABLE_STD_SYSTEM_ERROR -fexceptions
+LOCAL_CFLAGS :=  \
+    -frtti -fexceptions \
+    -isystem $(LOCAL_PATH)/asio/include
 
 endif #ifeq ($(PFW_NETWORKING),false)
 
-LOCAL_CLANG := true
\ No newline at end of file
+LOCAL_CLANG := true