diff options
author | Leon Scroggins III <scroggo@google.com> | 2015-02-20 16:17:28 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-02-20 16:17:28 +0000 |
commit | 193327270691afde273fe6befd88aa6942862373 (patch) | |
tree | 871243893f826dc738275275559e8aab4b3f6d6c | |
parent | 021b9904279c7bcd08a66a349933fc883141db34 (diff) | |
parent | 31b3a825a1934d9635e4b674dda9025465d35b69 (diff) | |
download | jpeg-193327270691afde273fe6befd88aa6942862373.tar.gz |
am 31b3a825: am 0e1c7ef1: Fix bugs in jmem-ashmem.
* commit '31b3a825a1934d9635e4b674dda9025465d35b69':
Fix bugs in jmem-ashmem.
-rw-r--r-- | jmem-ashmem.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/jmem-ashmem.c b/jmem-ashmem.c index 3a17b02..0c35715 100644 --- a/jmem-ashmem.c +++ b/jmem-ashmem.c @@ -121,6 +121,8 @@ LOCAL(int) get_ashmem(backing_store_ptr info, long total_bytes_needed) { char path[1024]; + // FIXME: Does this name need to be unique? What happens if two jpegs + // are being decoded simultaneously in the same process? snprintf(path, 1023, "%d.tmp.ashmem", getpid()); int fd = ashmem_create_region(path, total_bytes_needed); if (fd == -1) { @@ -128,9 +130,16 @@ get_ashmem(backing_store_ptr info, long total_bytes_needed) } int err = ashmem_set_prot_region(fd, PROT_READ | PROT_WRITE); if (err) { - return -1; + close(fd); + return -1; + } + void* addr = mmap(NULL, total_bytes_needed, PROT_READ | PROT_WRITE, + MAP_PRIVATE, fd, 0); + if (-1 == (long) addr) { + close(fd); + return -1; } - info->addr = mmap(NULL, total_bytes_needed, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); + info->addr = addr; info->size = total_bytes_needed; info->temp_file = fd; return fd; |