diff options
author | project-model-updater <project-model-updater-no-reply@jetbrains.com> | 2021-01-29 18:02:27 +0000 |
---|---|---|
committer | kotlin-ide-monorepo-bot <kotlin-ide-monorepo-bot-no-reply@jetbrains.com> | 2021-01-29 18:02:27 +0000 |
commit | ea69c3c147d5787f4acfcb5926ad43558cd3f741 (patch) | |
tree | d67af90c57f84e68d31a85cbf83eb16bbc9145a7 | |
parent | ffaf9678a86e33d088924b3b8db1de98c8648555 (diff) | |
download | intellij-kotlin-upstream-master.tar.gz |
Project model is updatedupstream-master
GitOrigin-RevId: 100353c2e51c7bdc42a1c395ad6a239bcc40db09
-rw-r--r-- | .idea/inspectionProfiles/idea_default.xml | 147 |
1 files changed, 79 insertions, 68 deletions
diff --git a/.idea/inspectionProfiles/idea_default.xml b/.idea/inspectionProfiles/idea_default.xml index 0f2b1e99f927..dcc2f9e3feb4 100644 --- a/.idea/inspectionProfiles/idea_default.xml +++ b/.idea/inspectionProfiles/idea_default.xml @@ -804,7 +804,7 @@ <constraint name="__context__" within="" contains="" /> <constraint name="class" regexp=".*Performance.*" negateName="true" within="" contains="" /> </searchConfiguration> - <searchConfiguration name="Anonymous Disposable passed to method" description="Do not pass Disposer.newDisposable() or similar to method expecting Disposable, because it can cause memory leak via Disposer tree. Instead, pass Disposable which you can guarantee to be disposed at the time needed." problemDescriptor="Anonymous Disposable passed to method: possible memory leak" text="new $f$($s1$, com.intellij.openapi.util.Disposer.$newDisposable$($a$), $s2$)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" search_injected="false"> + <searchConfiguration name="Anonymous Disposable passed to method" description="Do not pass Disposer.newDisposable() or similar to method expecting Disposable, because it can cause memory leak via Disposer tree. Instead, pass Disposable which you can guarantee to be disposed at the time needed." problemDescriptor="Anonymous Disposable passed to method: possible memory leak" text="new $f$($s1$, com.intellij.openapi.util.Disposer.$newDisposable$($a$), $s2$)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default"> <constraint name="__context__" within="" contains="" /> <constraint name="f" within="" contains="" /> <constraint name="s1" minCount="0" maxCount="2147483647" within="" contains="" /> @@ -812,7 +812,7 @@ <constraint name="a" minCount="0" maxCount="2147483647" within="" contains="" /> <constraint name="newDisposable" regexp="newDisposable" target="true" within="" contains="" /> </searchConfiguration> - <searchConfiguration name="Anonymous Disposable passed to method" text="$f$($s1$, com.intellij.openapi.util.Disposer.$newDisposable$($a$), $s2$)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" search_injected="false"> + <searchConfiguration name="Anonymous Disposable passed to method" text="$f$($s1$, com.intellij.openapi.util.Disposer.$newDisposable$($a$), $s2$)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default"> <constraint name="__context__" within="" contains="" /> <constraint name="f" within="" contains="" /> <constraint name="s1" minCount="0" maxCount="2147483647" within="" contains="" /> @@ -869,29 +869,29 @@ <constraint name="Field" within="" contains="" /> <constraint name="elements" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="can be simplified to ReadAction.compute" created="1516639178225" text="$application$.runReadAction(new $Computable$() { public $SearchScope$ compute() { return $e$; } })" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.application.ReadAction.compute(()->$e$)"> + <replaceConfiguration name="can be simplified to ReadAction.compute()" uuid="44cf5267-e665-3ff5-9d2f-0de5c6983156" text="$application$.runReadAction(new $Computable$() { public $SearchScope$ compute() { return $e$; } })" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.application.ReadAction.compute(()->$e$)"> <constraint name="SearchScope" within="" contains="" /> <constraint name="e" within="" contains="" /> <constraint name="application" nameOfExprType="com.intellij.openapi.application.Application" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="Computable" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="can be simplified to ReadAction.compute" text="$application$.runReadAction(($C$)()->$e$)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.application.ReadAction.compute(()->$e$)"> + <replaceConfiguration name="can be simplified to ReadAction.compute()" uuid="44cf5267-e665-3ff5-9d2f-0de5c6983156" text="$application$.runReadAction(($C$)()->$e$)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.application.ReadAction.compute(()->$e$)"> <constraint name="e" within="" contains="" /> <constraint name="C" minCount="0" within="" contains="" /> <constraint name="application" nameOfExprType="com.intellij.openapi.application.Application" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="can be simplified to ReadAction.compute" text="$application$.runReadAction($Computable$() { fun compute() { return $e$ } })" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.application.ReadAction.compute { $e$ }"> + <replaceConfiguration name="can be simplified to ReadAction.compute()" uuid="44cf5267-e665-3ff5-9d2f-0de5c6983156" text="$application$.runReadAction($Computable$() { fun compute() { return $e$ } })" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.application.ReadAction.compute { $e$ }"> <constraint name="e" within="" contains="" /> <constraint name="application" nameOfExprType="com.intellij.openapi.application.Application" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="Computable" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="can simplify to getInstanceEx" text="(PsiManagerEx)PsiManager.getInstance($project$)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="PsiManagerEx.getInstanceEx($project$)"> + <replaceConfiguration name="can simplify to getInstanceEx()" uuid="83b2549d-3689-355b-bb4a-b2b6d2dad4fc" text="(PsiManagerEx)PsiManager.getInstance($project$)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="PsiManagerEx.getInstanceEx($project$)"> <constraint name="__context__" within="" contains="" /> <constraint name="project" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="can simplify to getInstanceEx" text="PsiManager.getInstance($project$) as PsiManagerEx" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="PsiManagerEx.getInstanceEx($project$)"> + <replaceConfiguration name="can simplify to getInstanceEx()" uuid="83b2549d-3689-355b-bb4a-b2b6d2dad4fc" text="PsiManager.getInstance($project$) as PsiManagerEx" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="PsiManagerEx.getInstanceEx($project$)"> <constraint name="__context__" within="" contains="" /> <constraint name="project" within="" contains="" /> </replaceConfiguration> @@ -929,24 +929,24 @@ </replaceConfiguration> <replaceConfiguration name="can use ContainerUtil" uuid="c9f1d44f-a345-34e5-8460-cf58d74c993d" text="new HashSet<>(Arrays.asList($list$))" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.util.containers.ContainerUtil.set($list$)"> <constraint name="__context__" within="" contains="" /> - <constraint name="list" maxCount="32000" within="" contains="" /> + <constraint name="list" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="can use ContainerUtil" uuid="c9f1d44f-a345-34e5-8460-cf58d74c993d" text="HashSet(Arrays.asList($list$))" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.util.containers.ContainerUtil.set($list$)"> <constraint name="__context__" within="" contains="" /> - <constraint name="list" maxCount="32000" within="" contains="" /> + <constraint name="list" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="can use ContainerUtil" uuid="c9f1d44f-a345-34e5-8460-cf58d74c993d" text="Collections.unmodifiableList(Arrays.asList($c$))" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.util.containers.ContainerUtil.immutableList($c$)"> <constraint name="__context__" within="" contains="" /> - <constraint name="c" maxCount="32000" within="" contains="" /> + <constraint name="c" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="can use ContainerUtil" uuid="c9f1d44f-a345-34e5-8460-cf58d74c993d" text="Collections.unmodifiableList(Arrays.asList($c$))" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.util.containers.ContainerUtil.immutableList($c$)"> <constraint name="__context__" within="" contains="" /> - <constraint name="c" maxCount="32000" within="" contains="" /> + <constraint name="c" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="can use ContainerUtil" uuid="c9f1d44f-a345-34e5-8460-cf58d74c993d" text="Collections.newSetFromMap(new ConcurrentHashMap<>())" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="com.intellij.util.containers.ContainerUtil.newConcurrentSet()"> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="can use StringUtil" uuid="e2009598-65b8-3ae6-a9f8-9159d2b2e27a" text="if ($s$.endsWith($e$)) { $s$ = $s$.substring(0, $s$.length() - $e$.length()); }" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="$s$ = com.intellij.openapi.util.text.StringUtil.trimEnd($s$, $e$); "> + <replaceConfiguration name="can use StringUtil" uuid="e2009598-65b8-3ae6-a9f8-9159d2b2e27a" text="if ($s$.endsWith($e$)) { $s$ = $s$.substring(0, $s$.length() - $e$.length()); }" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="$s$ = com.intellij.openapi.util.text.StringUtil.trimEnd($s$, $e$); "> <constraint name="s" within="" contains="" /> <constraint name="e" within="" contains="" /> <constraint name="__context__" script=""import com.intellij.psi.* import com.intellij.psi.search.GlobalSearchScope import com.intellij.psi.util.PsiUtil def stringUtil = JavaPsiFacade.getInstance(e.getProject()).findClass("com.intellij.openapi.util.text.StringUtil", GlobalSearchScope.allScope(e.getProject())); def strVirtualFile = PsiUtil.getVirtualFile(stringUtil); e instanceof PsiLiteralExpression && e.getParent().getParent().getParent() instanceof PsiIfStatement && ((PsiIfStatement)e.getParent().getParent().getParent()).getElseBranch() == null && strVirtualFile != null && e.getResolveScope().contains(strVirtualFile) "" target="true" within="" contains="" /> @@ -1118,44 +1118,45 @@ <constraint name="ref" within="" contains="" /> <constraint name="SwiftType" regexp="Swift(?!Inout).+Type" within="" contains="" /> </searchConfiguration> - <replaceConfiguration name="File.createTempFile" text="java.io.File.createTempFile($prefix$, $suffix$)" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($prefix$, $suffix$)"> + <replaceConfiguration name="File.createTempFile()" uuid="dee96c73-c402-36ca-a972-4b6641585bc0" text="java.io.File.createTempFile($prefix$, $suffix$)" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($prefix$, $suffix$)"> <constraint name="prefix" within="" contains="" /> <constraint name="suffix" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="File.createTempFile" text="java.io.File.createTempFile($prefix$, $suffix$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($prefix$, $suffix$)"> + <replaceConfiguration name="File.createTempFile()" uuid="dee96c73-c402-36ca-a972-4b6641585bc0" text="java.io.File.createTempFile($prefix$, $suffix$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($prefix$, $suffix$)"> <constraint name="prefix" within="" contains="" /> <constraint name="suffix" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="File.createTempFile" text="java.io.File.createTempFile($prefix$, $suffix$, $dir$)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($dir$, $prefix$, $suffix$, true)"> + <replaceConfiguration name="File.createTempFile()" uuid="dee96c73-c402-36ca-a972-4b6641585bc0" text="java.io.File.createTempFile($prefix$, $suffix$, $dir$)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($dir$, $prefix$, $suffix$, true)"> <constraint name="prefix" within="" contains="" /> <constraint name="suffix" within="" contains="" /> <constraint name="dir" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="File.createTempFile" text="java.io.File.createTempFile($prefix$, $suffix$, $dir$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($dir$, $prefix$, $suffix$, true)"> + <replaceConfiguration name="File.createTempFile()" uuid="dee96c73-c402-36ca-a972-4b6641585bc0" text="java.io.File.createTempFile($prefix$, $suffix$, $dir$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.io.FileUtil.createTempFile($dir$, $prefix$, $suffix$, true)"> <constraint name="prefix" within="" contains="" /> <constraint name="suffix" within="" contains="" /> <constraint name="dir" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="findAnnotation(name) != null -> hasAnnotation(name)" text="$Instance$.findAnnotation($Parameter$) != null" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Instance$.hasAnnotation($Parameter$)"> + <replaceConfiguration name="findAnnotation(name) != null -> hasAnnotation(name)" text="$Instance$.findAnnotation($Parameter$) != null" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Instance$.hasAnnotation($Parameter$)"> <constraint name="Instance" nameOfExprType="com\.intellij\.psi\.PsiAnnotationOwner" exprTypeWithinHierarchy="true" minCount="0" within="" contains="" /> - <constraint name="Parameter" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Parameter" within="" contains="" /> + <constraint name="__context__" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="findAnnotation(name) != null -> hasAnnotation(name)" text="$Instance$.findAnnotation($Parameter$) != null" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Instance$.hasAnnotation($Parameter$)"> <constraint name="Instance" nameOfExprType="com\.intellij\.psi\.PsiAnnotationOwner" exprTypeWithinHierarchy="true" minCount="0" within="" contains="" /> - <constraint name="Parameter" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Parameter" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="findAnnotation(name) != null -> hasAnnotation(name)" text="$Instance$.findAnnotation($Parameter$) == null " recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="!$Instance$.hasAnnotation($Parameter$)"> <constraint name="Instance" nameOfExprType="com\.intellij\.psi\.PsiAnnotationOwner" exprTypeWithinHierarchy="true" minCount="0" within="" contains="" /> - <constraint name="Parameter" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Parameter" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="findAnnotation(name) can be simplified" uuid="7228acac-afb8-381c-b31f-ad9cdefe3a81" text="$Instance$.findAnnotation($Parameter$) == null " recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="!$Instance$.hasAnnotation($Parameter$)"> <constraint name="Instance" nameOfExprType="com\.intellij\.psi\.PsiAnnotationOwner" exprTypeWithinHierarchy="true" minCount="0" within="" contains="" /> - <constraint name="Parameter" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Parameter" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="incorrect DumbAware check" created="1522680840725" text="$target$ instanceof DumbAware" recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.project.DumbService.isDumbAware($target$)"> @@ -1165,19 +1166,35 @@ <constraint name="target" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="invalid use of ArrayUtil.contains: always returns false" text="com.intellij.util.ArrayUtil.contains($t$, $e$)" recursive="true" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="$e$.contains($t$)"> + <replaceConfiguration name="invalid use of ArrayUtil.contains(): always returns false" uuid="676e5e3d-30ef-3f51-88a6-6366b80d5d76" text="com.intellij.util.ArrayUtil.contains($t$, $e$)" recursive="true" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="$e$.contains($t$)"> <constraint name="__context__" within="" contains="" /> <constraint name="t" within="" contains="" /> <constraint name="e" nameOfExprType="java\.util\.Collection" exprTypeWithinHierarchy="true" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="invalid use of ArrayUtil.contains: always returns false" text="com.intellij.util.ArrayUtil.contains($t$, $e$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="$e$.contains($t$)"> + <replaceConfiguration name="invalid use of ArrayUtil.contains(): always returns false" uuid="676e5e3d-30ef-3f51-88a6-6366b80d5d76" text="com.intellij.util.ArrayUtil.contains($t$, $e$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="$e$.contains($t$)"> <constraint name="__context__" within="" contains="" /> <constraint name="t" within="" contains="" /> <constraint name="e" nameOfExprType="java\.util\.Collection" exprTypeWithinHierarchy="true" within="" contains="" /> </replaceConfiguration> + <replaceConfiguration name="Lambda can be replaced with Pair.comparingByFirst()" text="java.util.Comparator.comparing((com.intellij.openapi.util.Pair $p$) -> $p$.first)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.Pair.comparingByFirst()"> + <constraint name="__context__" script=""__context__.parent instanceof com.intellij.psi.PsiExpressionList"" within="" contains="" /> + <constraint name="p" within="" contains="" /> + </replaceConfiguration> + <replaceConfiguration name="Lambda can be replaced with Pair.comparingByFirst()" text="java.util.Comparator.comparing((com.intellij.openapi.util.Pair $p$) -> $p$.getFirst())" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.Pair.comparingByFirst()"> + <constraint name="__context__" script=""__context__.parent instanceof com.intellij.psi.PsiExpressionList"" within="" contains="" /> + <constraint name="p" within="" contains="" /> + </replaceConfiguration> + <replaceConfiguration name="Lambda can be replaced with Pair.comparingBySecond()" text="java.util.Comparator.comparing((com.intellij.openapi.util.Pair $p$) -> $p$.second)" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.Pair.comparingBySecond()"> + <constraint name="__context__" script=""__context__.parent instanceof com.intellij.psi.PsiExpressionList"" within="" contains="" /> + <constraint name="p" within="" contains="" /> + </replaceConfiguration> + <replaceConfiguration name="Lambda can be replaced with Pair.comparingBySecond()" text="java.util.Comparator.comparing((com.intellij.openapi.util.Pair $p$) -> $p$.getSecond())" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.Pair.comparingBySecond()"> + <constraint name="__context__" script=""__context__.parent instanceof com.intellij.psi.PsiExpressionList"" within="" contains="" /> + <constraint name="p" within="" contains="" /> + </replaceConfiguration> <searchConfiguration name="Logger.getInstance(unknown class)" text="Logger.getInstance("#$c$")" recursive="true" caseInsensitive="true" type="JAVA" pattern_context="default"> - <constraint name="__context__" script=""import com.intellij.psi.* import com.intellij.psi.search.GlobalSearchScope import com.intellij.psi.util.PsiUtil def project = __context__.getProject(); def fqn = c.getValue().substring(1); if (fqn.indexOf('.') == -1) return false; def shortName = com.intellij.openapi.util.text.StringUtil.getShortName(fqn); if (!shortName.equals(com.intellij.openapi.util.text.StringUtil.capitalize(shortName))) return false; def cClass = JavaPsiFacade.getInstance(project).findClass(fqn, GlobalSearchScope.allScope(project)); cClass == null "" target="true" within="" contains="" /> - <constraint name="c" within="" contains="" /> + <constraint name="__context__" script=""import com.intellij.psi.* import com.intellij.psi.search.GlobalSearchScope import com.intellij.psi.util.PsiUtil def project = __context__.getProject(); def fqn = c.getValue().substring(1); if (fqn.indexOf('.') == -1) return false; def shortName = com.intellij.openapi.util.text.StringUtil.getShortName(fqn); if (!shortName.equals(com.intellij.openapi.util.text.StringUtil.capitalize(shortName))) return false; def cClass = JavaPsiFacade.getInstance(project).findClass(fqn, GlobalSearchScope.allScope(project)); cClass == null "" within="" contains="" /> + <constraint name="c" target="true" within="" contains="" /> </searchConfiguration> <replaceConfiguration name="Logger expression can be simplified" uuid="0befec03-d2b3-3838-ada0-363adc05fac7" text="com.intellij.openapi.diagnostic.Logger.getInstance("#" + $c$.class.getName())" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.diagnostic.Logger.getInstance($c$.class)"> <constraint name="c" within="" contains="" /> @@ -1202,7 +1219,7 @@ <constraint name="c" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="Logger expression can be simplified" uuid="0befec03-d2b3-3838-ada0-363adc05fac7" text="Logger.getInstance("#$c$")" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="Logger.getInstance($c$::class.java)"> - <constraint name="__context__" script=""import com.intellij.psi.* def resolveScope = __context__.getContainingFile().getResolveScope() def className = c.getText().substring(1) def psiFacade = JavaPsiFacade.getInstance(__context__.project) def aClass = psiFacade.findClass(className, resolveScope) aClass != null"" target="true" within="" contains="" /> + <constraint name="__context__" script=""import com.intellij.psi.* def resolveScope = __context__.getContainingFile().getResolveScope() def className = c.getText().substring(1) def psiFacade = JavaPsiFacade.getInstance(__context__.project) def aClass = psiFacade.findClass(className, resolveScope) aClass != null"" target="true" within="" contains="" /> <constraint name="c" within="" contains="" /> </replaceConfiguration> <searchConfiguration name="Logger should be a top-level declaration" uuid="03c8b094-627d-3aaa-8d8b-4a66542826cd" description="Creating a logger for each instance of a class isn't optimized. The idiomatic way to create a logger is using a top-level declaration." problemDescriptor="Logger should be a top-level declaration." text="class $Class$ { val $logger$ }" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default"> @@ -1210,12 +1227,12 @@ <constraint name="Class" within="" contains="" /> <constraint name="logger" nameOfExprType="Logger|libraries\.klogging\.BaseLogger" exprTypeWithinHierarchy="true" target="true" within="" contains="" /> </searchConfiguration> - <replaceConfiguration name="Manual TextRange.substring implementation" description="Reports code pattern like str.substring(range.getStartOffset(), range.getEndOffset()). This code could be replaced with range.substring(str)" problemDescriptor="TextRange.substring() could be used" text="$str$.substring($range$.getStartOffset(), $range$.getEndOffset())" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$range$.substring($str$)"> + <replaceConfiguration name="Manual TextRange.substring() implementation" uuid="7eb9e6b2-16c6-3c0e-aa15-b8c0a54a6aee" description="Reports code pattern like str.substring(range.getStartOffset(), range.getEndOffset()). This code could be replaced with range.substring(str)" problemDescriptor="TextRange.substring() could be used" text="$str$.substring($range$.getStartOffset(), $range$.getEndOffset())" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$range$.substring($str$)"> <constraint name="__context__" within="" contains="" /> <constraint name="str" nameOfExprType="java\.lang\.String" within="" contains="" /> <constraint name="range" nameOfExprType="com\.intellij\.openapi\.util\.TextRange" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Manual TextRange.substring implementation" text="$str$.substring($range$.startOffset, $range$.endOffset)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$range$.substring($str$)"> + <replaceConfiguration name="Manual TextRange.substring() implementation" uuid="7eb9e6b2-16c6-3c0e-aa15-b8c0a54a6aee" text="$str$.substring($range$.startOffset, $range$.endOffset)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$range$.substring($str$)"> <constraint name="__context__" within="" contains="" /> <constraint name="str" nameOfExprType="java\.lang\.String" within="" contains="" /> <constraint name="range" nameOfExprType="com\.intellij\.openapi\.util\.TextRange" within="" contains="" /> @@ -1231,11 +1248,11 @@ <constraint name="b" nameOfExprType="ByteArray|Array<Byte>" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <searchConfiguration name="non-static JamAnnotationMeta" created="1523014327447" text="class $Class$ { $Type$ $Variable$ = $Init$; }" recursive="false" caseInsensitive="true" type="JAVA"> + <searchConfiguration name="non-static JamAnnotationMeta" text="class $Class$ { $Type$ $Variable$ = $Init$; }" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default"> <constraint name="Class" within="" contains="" /> <constraint name="Type" regexp="JamAnnotationMeta" within="" contains="" /> <constraint name="Variable" script=""!__context__.hasModifierProperty("static")"" maxCount="2147483647" target="true" within="" contains="" /> - <constraint name="Init" within="" contains="" /> + <constraint name="Init" minCount="0" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </searchConfiguration> <searchConfiguration name="non-static JamAnnotationMeta" text="class $Class$ { val $Variable$ }" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default"> @@ -1289,40 +1306,42 @@ <constraint name="__context__" within="" contains="" /> <constraint name="a" minCount="0" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> - <searchConfiguration name="Potential memory leak: don't hold PsiElement inside quick fix, use SmartPsiElementPointer or instead of; also see LocalQuickFixOnPsiElement" text="class $Class$ { $FieldType$ $FieldName$ = $Init$; }" recursive="false" caseInsensitive="false" type="JAVA"> - <constraint name="Class" script=""import com.intellij.psi.PsiClass import com.intellij.psi.util.InheritanceUtil import com.intellij.psi.util.PsiTreeUtil Object c = __context__ return c instanceof PsiClass && InheritanceUtil.isInheritor(c, "com.intellij.codeInspection.LocalQuickFix") "" within="" contains="" /> - <constraint name="FieldType" script=""import com.intellij.psi.PsiClass import com.intellij.psi.PsiElement import com.intellij.psi.PsiField import com.intellij.psi.util.InheritanceUtil import com.intellij.psi.util.PsiTreeUtil PsiField f = PsiTreeUtil.getParentOfType(__context__, PsiField) return f != null && InheritanceUtil.isInheritor(f.getType(), "com.intellij.psi.PsiElement") "" maxCount="2147483647" within="" contains="" /> + <searchConfiguration name="Potential memory leak: don't hold PsiElement inside quick fix, use SmartPsiElementPointer or instead of; also see LocalQuickFixOnPsiElement" text="class $Class$ { $FieldType$ $FieldName$ = $Init$; }" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default"> + <constraint name="Class" regexp="com.intellij.codeInspection.LocalQuickFix" withinHierarchy="true" within="" contains="" /> + <constraint name="FieldType" regexp="com.intellij.psi.PsiElement" withinHierarchy="true" within="" contains="" /> <constraint name="FieldName" maxCount="2147483647" target="true" within="" contains="" /> - <constraint name="Init" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Init" minCount="0" within="" contains="" /> + <constraint name="__context__" within="" contains="" /> </searchConfiguration> <searchConfiguration name="Potential memory leak: don't hold PsiElement inside quick fix, use SmartPsiElementPointer or instead of; also see LocalQuickFixOnPsiElement" text="class $Class$ { val $FieldName$ }" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default"> <constraint name="Class" regexp="com.intellij.codeInspection.LocalQuickFix" withinHierarchy="true" within="" contains="" /> <constraint name="FieldName" nameOfExprType="PsiElement" exprTypeWithinHierarchy="true" maxCount="2147483647" target="true" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </searchConfiguration> - <replaceConfiguration name="Potential non-desired escape from lambda expression" text="PsiTreeUtil.getParentOfType($Parameter$, PsiMethod.class, true, PsiClass.class)" recursive="false" caseInsensitive="false" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" useStaticImport="true" replacement="PsiTreeUtil.getParentOfType($Parameter$, PsiMethod.class, true, PsiClass.class, PsiLambdaExpression.class)"> - <constraint name="Parameter" minCount="0" maxCount="2147483647" within="" contains="" /> + <replaceConfiguration name="Potential non-desired escape from lambda expression" text="PsiTreeUtil.getParentOfType($Parameter$, PsiMethod.class, true, PsiClass.class)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" useStaticImport="true" replacement="PsiTreeUtil.getParentOfType($Parameter$, PsiMethod.class, true, PsiClass.class, PsiLambdaExpression.class)"> + <constraint name="Parameter" within="" contains="" /> + <constraint name="__context__" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="Potential non-desired escape from lambda expression" text="PsiTreeUtil.getParentOfType($Parameter$, PsiMethod::class.java, true, PsiClass::class.java)" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" useStaticImport="true" replacement="PsiTreeUtil.getParentOfType($Parameter$, PsiMethod::class.java, true, PsiClass::class.java, PsiLambdaExpression::class.java)"> - <constraint name="Parameter" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Parameter" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Presentation setEnabledAndVisible" text="$Var1$.setEnabled($Var2$); $Var1$.setVisible($Var2$); " recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.setEnabledAndVisible($Var2$);"> + <replaceConfiguration name="Presentation setEnabledAndVisible()" uuid="b8a50e24-ab96-3281-a6f3-ef3ee515af02" text="$Var1$.setEnabled($Var2$); $Var1$.setVisible($Var2$); " recursive="false" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.setEnabledAndVisible($Var2$);"> <constraint name="__context__" target="true" within="" contains="" /> <constraint name="Var2" within="" contains="" /> <constraint name="Var1" nameOfExprType="Presentation" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Presentation setEnabledAndVisible" text="$Var1$.setVisible($Var2$); $Var1$.setEnabled($Var2$); " recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.setEnabledAndVisible($Var2$);"> + <replaceConfiguration name="Presentation setEnabledAndVisible()" uuid="b8a50e24-ab96-3281-a6f3-ef3ee515af02" text="$Var1$.setVisible($Var2$); $Var1$.setEnabled($Var2$); " recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.setEnabledAndVisible($Var2$);"> <constraint name="__context__" target="true" within="" contains="" /> <constraint name="Var2" within="" contains="" /> <constraint name="Var1" nameOfExprType="Presentation" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Presentation setEnabledAndVisible" text="$Var1$.isEnabled = $Var2$ $Var1$.isVisible = $Var2$" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.isEnabledAndVisible = $Var2$"> + <replaceConfiguration name="Presentation setEnabledAndVisible()" uuid="b8a50e24-ab96-3281-a6f3-ef3ee515af02" text="$Var1$.isEnabled = $Var2$ $Var1$.isVisible = $Var2$" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.isEnabledAndVisible = $Var2$"> <constraint name="__context__" target="true" within="" contains="" /> <constraint name="Var2" within="" contains="" /> <constraint name="Var1" nameOfExprType="Presentation" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Presentation setEnabledAndVisible" text="$Var1$.isVisible = $Var2$ $Var1$.isEnabled = $Var2$ " recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.isEnabledAndVisible = $Var2$"> + <replaceConfiguration name="Presentation setEnabledAndVisible()" uuid="b8a50e24-ab96-3281-a6f3-ef3ee515af02" text="$Var1$.isVisible = $Var2$ $Var1$.isEnabled = $Var2$ " recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$Var1$.isEnabledAndVisible = $Var2$"> <constraint name="__context__" target="true" within="" contains="" /> <constraint name="Var2" within="" contains="" /> <constraint name="Var1" nameOfExprType="Presentation" within="" contains="" /> @@ -1334,7 +1353,7 @@ <constraint name="psiElement" nameOfExprType="com\.intellij\.psi\.PsiElement" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> - <searchConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents in tests" text="if ($APP$.isUnitTestMode()) { $DO$; } else { $APP2$.$INV$($ARGS$); }" recursive="true" caseInsensitive="true" type="JAVA" pattern_context="default"> + <searchConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents() in tests" uuid="07f04ba3-90ed-3e4d-9f88-e45dfaa05771" text="if ($APP$.isUnitTestMode()) { $DO$; } else { $APP2$.$INV$($ARGS$); }" recursive="true" caseInsensitive="true" type="JAVA" pattern_context="default"> <constraint name="__context__" within="" contains="" /> <constraint name="APP" within="" contains="" /> <constraint name="APP2" within="" contains="" /> @@ -1342,7 +1361,7 @@ <constraint name="ARGS" maxCount="2147483647" within="" contains="" /> <constraint name="DO" maxCount="2147483647" within="" contains="" /> </searchConfiguration> - <replaceConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents in tests" text="if (!$APP$.isUnitTestMode()) { $APP2$.$INV$($ARGS$); } else { $DO$; }" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="if (!$APP$.isUnitTestMode()) { $APP2$.$INV$($ARGS$); } else { $DO$; }"> + <replaceConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents() in tests" uuid="07f04ba3-90ed-3e4d-9f88-e45dfaa05771" text="if (!$APP$.isUnitTestMode()) { $APP2$.$INV$($ARGS$); } else { $DO$; }" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="if (!$APP$.isUnitTestMode()) { $APP2$.$INV$($ARGS$); } else { $DO$; }"> <constraint name="__context__" within="" contains="" /> <constraint name="APP" within="" contains="" /> <constraint name="APP2" within="" contains="" /> @@ -1350,7 +1369,7 @@ <constraint name="ARGS" maxCount="2147483647" within="" contains="" /> <constraint name="DO" maxCount="2147483647" within="" contains="" /> </replaceConfiguration> - <searchConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents in tests" text="if ($APP$.isUnitTestMode()) { $DO$ } else { $APP2$.$INV$($ARGS$) }" recursive="true" caseInsensitive="true" type="Kotlin" pattern_context="default"> + <searchConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents() in tests" uuid="07f04ba3-90ed-3e4d-9f88-e45dfaa05771" text="if ($APP$.isUnitTestMode()) { $DO$ } else { $APP2$.$INV$($ARGS$) }" recursive="true" caseInsensitive="true" type="Kotlin" pattern_context="default"> <constraint name="__context__" within="" contains="" /> <constraint name="APP" within="" contains="" /> <constraint name="APP2" within="" contains="" /> @@ -1358,7 +1377,7 @@ <constraint name="ARGS" maxCount="2147483647" within="" contains="" /> <constraint name="DO" maxCount="2147483647" within="" contains="" /> </searchConfiguration> - <searchConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents in tests" text="if (!$APP$.isUnitTestMode()) { $APP2$.$INV$($ARGS$) } else { $DO$ }" recursive="true" caseInsensitive="true" type="Kotlin" pattern_context="default"> + <searchConfiguration name="remove test-only branch and use UIUtil.dispatchAllInvocationEvents() in tests" uuid="07f04ba3-90ed-3e4d-9f88-e45dfaa05771" text="if (!$APP$.isUnitTestMode()) { $APP2$.$INV$($ARGS$) } else { $DO$ }" recursive="true" caseInsensitive="true" type="Kotlin" pattern_context="default"> <constraint name="__context__" within="" contains="" /> <constraint name="APP" within="" contains="" /> <constraint name="APP2" within="" contains="" /> @@ -1366,11 +1385,11 @@ <constraint name="ARGS" maxCount="2147483647" within="" contains="" /> <constraint name="DO" maxCount="2147483647" within="" contains="" /> </searchConfiguration> - <replaceConfiguration name="Replace explicit RExpression#getType with RTypeUtil#getType" text="((RExpression)$foo$).getType()" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="org.jetbrains.plugins.ruby.ruby.codeInsight.types.RTypeUtil.getType($foo$)"> + <replaceConfiguration name="Replace explicit RExpression#getType() with RTypeUtil#getType()" uuid="260bf7ef-989c-3b5b-b926-edbfeb9271cc" text="((RExpression)$foo$).getType()" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="org.jetbrains.plugins.ruby.ruby.codeInsight.types.RTypeUtil.getType($foo$)"> <constraint name="__context__" within="" contains="" /> <constraint name="foo" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Replace explicit RExpression#getType with RTypeUtil#getType" text="($foo$ as RExpression).type" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="org.jetbrains.plugins.ruby.ruby.codeInsight.types.RTypeUtil.getType($foo$)"> + <replaceConfiguration name="Replace explicit RExpression#getType() with RTypeUtil#getType()" uuid="260bf7ef-989c-3b5b-b926-edbfeb9271cc" text="($foo$ as RExpression).type" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="org.jetbrains.plugins.ruby.ruby.codeInsight.types.RTypeUtil.getType($foo$)"> <constraint name="__context__" within="" contains="" /> <constraint name="foo" within="" contains="" /> </replaceConfiguration> @@ -1378,7 +1397,7 @@ <constraint name="Class" target="true" within="" contains="" /> <constraint name="FieldType" regexp="javax.swing.JComponent" withinHierarchy="true" formalTypeWithinHierarchy="true" within="" contains="" /> <constraint name="FieldName" maxCount="2147483647" within="" contains="" /> - <constraint name="Init" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Init" minCount="0" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </searchConfiguration> <searchConfiguration name="searchable configurable should not contain JComponent fields" text="class $Class$: SearchableConfigurable { @Modifier("Instance") val $FieldName$ = $Init$ fun disposeUIResources() {} }" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default"> @@ -1399,29 +1418,21 @@ <constraint name="a" within="" contains="" /> <constraint name="b" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="$result$ = new boolean[$a$.length]; System.arraycopy($a$, 0, $result$, 0, $a$.length);" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$result$ = $a$.clone();"> - <constraint name="__context__" within="" contains="" /> - <constraint name="result" within="" contains="" /> - <constraint name="a" within="" contains="" /> - </replaceConfiguration> - <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="$result$ = new int[$a$.length]; System.arraycopy($a$, 0, $result$, 0, $a$.length);" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$result$ = $a$.clone();"> + <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="java.util.Arrays.copyOf($original$, $original$.length)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$original$.clone()"> <constraint name="__context__" within="" contains="" /> - <constraint name="result" within="" contains="" /> - <constraint name="a" within="" contains="" /> + <constraint name="original" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="int[] $result$ = new int[$a$.length]; System.arraycopy($a$, 0, $result$, 0, $a$.length);" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="int[] $result$ = $a$.clone();"> + <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="$result$ = new $b$[$a$.length]; System.arraycopy($a$, 0, $result$, 0, $result$.length);" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$result$ = $a$.clone();"> <constraint name="__context__" within="" contains="" /> <constraint name="result" within="" contains="" /> <constraint name="a" within="" contains="" /> + <constraint name="b" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="int[] $result$ = new int[$a$.length]; System.arraycopy($a$, 0, $result$, 0, $result$.length);" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="int[] $result$ = $a$.clone();"> + <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="$b$[] $result$ = new $b$[$a$.length]; System.arraycopy($a$, 0, $result$, 0, $result$.length);" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="true" replacement="$b$[] $result$ = $a$.clone();"> <constraint name="__context__" within="" contains="" /> <constraint name="result" within="" contains="" /> <constraint name="a" within="" contains="" /> - </replaceConfiguration> - <replaceConfiguration name="Simplify array copy" uuid="659d106f-8fba-3493-bc68-22b1511378b7" text="java.util.Arrays.copyOf($original$, $original$.length)" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement="$original$.clone()"> - <constraint name="__context__" within="" contains="" /> - <constraint name="original" within="" contains="" /> + <constraint name="b" within="" contains="" /> </replaceConfiguration> <searchConfiguration name="Storing localized strings in static fields prevents dynamic loading of language bundles" text="$bundle$.$message$("$s$", $p$)" recursive="true" caseInsensitive="true" type="JAVA" pattern_context="default"> <constraint name="__context__" script=""import com.intellij.psi.*; import com.intellij.psi.util.*; PsiElement member = PsiTreeUtil.getParentOfType(__context__, PsiMember.class, PsiLambdaExpression.class) return member instanceof PsiField && member.hasModifierProperty(PsiModifier.STATIC)"" within="" contains="" /> @@ -1636,10 +1647,10 @@ <constraint name="c" nameOfExprType="char" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </searchConfiguration> - <replaceConfiguration name="StringUtil.stripQuotesAroundValue" text="com.intellij.openapi.util.text.StringUtil.stripQuotesAroundValue($Parameter$)" recursive="false" caseInsensitive="false" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.text.StringUtil.unquoteString($Parameter$)"> + <replaceConfiguration name="StringUtil.stripQuotesAroundValue()" uuid="c6a8c3bf-5d86-3fd2-875a-ddbd9c98648a" text="com.intellij.openapi.util.text.StringUtil.stripQuotesAroundValue($Parameter$)" recursive="false" caseInsensitive="false" type="JAVA" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.text.StringUtil.unquoteString($Parameter$)"> <constraint name="Parameter" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="StringUtil.stripQuotesAroundValue" text="com.intellij.openapi.util.text.StringUtil.stripQuotesAroundValue($Parameter$)" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.text.StringUtil.unquoteString($Parameter$)"> + <replaceConfiguration name="StringUtil.stripQuotesAroundValue()" uuid="c6a8c3bf-5d86-3fd2-875a-ddbd9c98648a" text="com.intellij.openapi.util.text.StringUtil.stripQuotesAroundValue($Parameter$)" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default" reformatAccordingToStyle="true" shortenFQN="true" replacement="com.intellij.openapi.util.text.StringUtil.unquoteString($Parameter$)"> <constraint name="Parameter" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </replaceConfiguration> @@ -1653,9 +1664,9 @@ <constraint name="e" nameOfExprType="java\.util\.concurrent\.ExecutorService" exprTypeWithinHierarchy="true" within="" contains="" /> <constraint name="d" within="" contains="" /> </replaceConfiguration> - <replaceConfiguration name="super.update() in AnAction subclass" text="$super$.update($e$);" recursive="true" caseInsensitive="true" type="JAVA" reformatAccordingToStyle="false" shortenFQN="false" replacement=""> + <replaceConfiguration name="super.update() in AnAction subclass" text="$super$.update($e$);" recursive="false" caseInsensitive="true" type="JAVA" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement=""> <constraint name="__context__" target="true" within="" contains="" /> - <constraint name="super" regexp="super" nameOfExprType="AnAction" within="" contains="" /> + <constraint name="super" regexp="super" nameOfExprType="AnAction|DumbAwareAction" within="" contains="" /> <constraint name="e" nameOfExprType="AnActionEvent" within="" contains="" /> </replaceConfiguration> <replaceConfiguration name="super.update() in AnAction subclass" text="$super$.update($e$)" recursive="false" caseInsensitive="true" type="Kotlin" pattern_context="default" reformatAccordingToStyle="false" shortenFQN="false" replacement=""> @@ -1716,9 +1727,9 @@ </searchConfiguration> <searchConfiguration name="Use RecursionManager?" text="class $Class$ { ThreadLocal<$FieldType$> $FieldName$ = $Init$; }" recursive="false" caseInsensitive="false" type="JAVA" pattern_context="default"> <constraint name="Class" within="" contains="" /> - <constraint name="FieldType" regexp="Collection" withinHierarchy="true" maxCount="2147483647" target="true" wholeWordsOnly="true" within="" contains="" /> + <constraint name="FieldType" regexp="Collection" withinHierarchy="true" target="true" within="" contains="" /> <constraint name="FieldName" maxCount="2147483647" within="" contains="" /> - <constraint name="Init" minCount="0" maxCount="2147483647" within="" contains="" /> + <constraint name="Init" minCount="0" within="" contains="" /> <constraint name="__context__" within="" contains="" /> </searchConfiguration> <searchConfiguration name="Use RecursionManager?" text="class $Class$ { val $FieldName$: ThreadLocal<$FieldType$> }" recursive="false" caseInsensitive="false" type="Kotlin" pattern_context="default"> |