1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
|
commit 0cb6965869ab94858d9b843ab5d94f7deaea5dc8
Author: Fabian Meumertzheim <fabian@meumertzhe.im>
Date: Mon Jun 12 16:12:02 2023 +0200
Disable layering_check
protobuf misses a sizeable number of dependency declarations, which
means that `layering_check` has to be disabled for it.
Generated with:
```
buildozer 'add features -layering_check' //src/...:__pkg__
```
Contains only the changes to `package` directives.
diff --git src/BUILD.bazel src/BUILD.bazel
index 0de1a4eb1..b7e405147 100644
--- src/BUILD.bazel
+++ src/BUILD.bazel
@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_filegroup", "pkg_files", "strip_prefix")
load("@upb//cmake:build_defs.bzl", "staleness_test")
load("//conformance:defs.bzl", "conformance_test")
+package(features = ["-layering_check"])
+
pkg_files(
name = "dist_files",
srcs = glob(["**"]),
diff --git src/google/protobuf/BUILD.bazel src/google/protobuf/BUILD.bazel
index 77ed2309f..8c38fb872 100644
--- src/google/protobuf/BUILD.bazel
+++ src/google/protobuf/BUILD.bazel
@@ -13,6 +13,7 @@ package(
"//:__pkg__", # "public" targets are alias rules in //.
"//json:__subpackages__",
],
+ features = ["-layering_check"],
)
proto_library(
diff --git src/google/protobuf/compiler/BUILD.bazel src/google/protobuf/compiler/BUILD.bazel
index a2171c806..8dcd34667 100644
--- src/google/protobuf/compiler/BUILD.bazel
+++ src/google/protobuf/compiler/BUILD.bazel
@@ -13,6 +13,8 @@ load("@rules_proto//proto:defs.bzl", "proto_library")
load("//build_defs:arch_tests.bzl", "aarch64_test", "x86_64_test")
load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS")
+package(features = ["-layering_check"])
+
proto_library(
name = "plugin_proto",
srcs = ["plugin.proto"],
diff --git src/google/protobuf/compiler/allowlists/BUILD.bazel src/google/protobuf/compiler/allowlists/BUILD.bazel
index 569a142fc..0a90b312f 100644
--- src/google/protobuf/compiler/allowlists/BUILD.bazel
+++ src/google/protobuf/compiler/allowlists/BUILD.bazel
@@ -1,7 +1,10 @@
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("//build_defs:cpp_opts.bzl", "COPTS")
-package(default_visibility = ["//visibility:private"])
+package(
+ default_visibility = ["//visibility:private"],
+ features = ["-layering_check"],
+)
cc_library(
name = "allowlist",
diff --git src/google/protobuf/compiler/cpp/BUILD.bazel src/google/protobuf/compiler/cpp/BUILD.bazel
index ac1184d32..deacbf582 100644
--- src/google/protobuf/compiler/cpp/BUILD.bazel
+++ src/google/protobuf/compiler/cpp/BUILD.bazel
@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("@rules_proto//proto:defs.bzl", "proto_library")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "names",
hdrs = ["names.h"],
diff --git src/google/protobuf/compiler/csharp/BUILD.bazel src/google/protobuf/compiler/csharp/BUILD.bazel
index 96b8dcbc0..a2d549f26 100644
--- src/google/protobuf/compiler/csharp/BUILD.bazel
+++ src/google/protobuf/compiler/csharp/BUILD.bazel
@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "names",
hdrs = ["names.h"],
diff --git src/google/protobuf/compiler/java/BUILD.bazel src/google/protobuf/compiler/java/BUILD.bazel
index 94573892c..c94f472d6 100644
--- src/google/protobuf/compiler/java/BUILD.bazel
+++ src/google/protobuf/compiler/java/BUILD.bazel
@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "names",
hdrs = ["names.h"],
diff --git src/google/protobuf/compiler/objectivec/BUILD.bazel src/google/protobuf/compiler/objectivec/BUILD.bazel
index f78990394..6c534219a 100644
--- src/google/protobuf/compiler/objectivec/BUILD.bazel
+++ src/google/protobuf/compiler/objectivec/BUILD.bazel
@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "names",
hdrs = ["names.h"],
diff --git src/google/protobuf/compiler/php/BUILD.bazel src/google/protobuf/compiler/php/BUILD.bazel
index fe9e75c2c..a569a1c9d 100644
--- src/google/protobuf/compiler/php/BUILD.bazel
+++ src/google/protobuf/compiler/php/BUILD.bazel
@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "names",
hdrs = ["names.h"],
diff --git src/google/protobuf/compiler/python/BUILD.bazel src/google/protobuf/compiler/python/BUILD.bazel
index 5d26e0ce9..ce017acf1 100644
--- src/google/protobuf/compiler/python/BUILD.bazel
+++ src/google/protobuf/compiler/python/BUILD.bazel
@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "python",
srcs = [
diff --git src/google/protobuf/compiler/ruby/BUILD.bazel src/google/protobuf/compiler/ruby/BUILD.bazel
index 520b69194..1e437e7bc 100644
--- src/google/protobuf/compiler/ruby/BUILD.bazel
+++ src/google/protobuf/compiler/ruby/BUILD.bazel
@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "ruby",
srcs = ["ruby_generator.cc"],
diff --git src/google/protobuf/compiler/rust/BUILD.bazel src/google/protobuf/compiler/rust/BUILD.bazel
index 7c1f5b856..4a10038d1 100644
--- src/google/protobuf/compiler/rust/BUILD.bazel
+++ src/google/protobuf/compiler/rust/BUILD.bazel
@@ -5,6 +5,8 @@
load("@rules_cc//cc:defs.bzl", "cc_library")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "rust",
srcs = ["generator.cc"],
diff --git src/google/protobuf/io/BUILD.bazel src/google/protobuf/io/BUILD.bazel
index 8f39625c2..fc2f8e002 100644
--- src/google/protobuf/io/BUILD.bazel
+++ src/google/protobuf/io/BUILD.bazel
@@ -6,6 +6,7 @@ load("//build_defs:cpp_opts.bzl", "COPTS")
package(
default_visibility = ["//visibility:public"],
+ features = ["-layering_check"],
)
cc_library(
diff --git src/google/protobuf/json/BUILD.bazel src/google/protobuf/json/BUILD.bazel
index d6019f939..83caca985 100644
--- src/google/protobuf/json/BUILD.bazel
+++ src/google/protobuf/json/BUILD.bazel
@@ -1,10 +1,13 @@
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("//build_defs:cpp_opts.bzl", "COPTS")
-package(default_visibility = [
- "//pkg:__pkg__",
- "//src/google/protobuf/json:__pkg__",
-])
+package(
+ default_visibility = [
+ "//pkg:__pkg__",
+ "//src/google/protobuf/json:__pkg__",
+ ],
+ features = ["-layering_check"],
+)
licenses(["notice"])
diff --git src/google/protobuf/stubs/BUILD.bazel src/google/protobuf/stubs/BUILD.bazel
index c8fc3e9d0..9521f5103 100644
--- src/google/protobuf/stubs/BUILD.bazel
+++ src/google/protobuf/stubs/BUILD.bazel
@@ -7,6 +7,7 @@ load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS")
package(
default_visibility = ["//:__subpackages__"],
+ features = ["-layering_check"],
)
cc_library(
diff --git src/google/protobuf/testing/BUILD.bazel src/google/protobuf/testing/BUILD.bazel
index 572c1f9f4..d10435cce 100644
--- src/google/protobuf/testing/BUILD.bazel
+++ src/google/protobuf/testing/BUILD.bazel
@@ -5,7 +5,10 @@ load("@rules_cc//cc:defs.bzl", "cc_library")
load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS")
-package(default_visibility = ["//:__subpackages__"])
+package(
+ default_visibility = ["//:__subpackages__"],
+ features = ["-layering_check"],
+)
cc_library(
name = "testing",
diff --git src/google/protobuf/util/BUILD.bazel src/google/protobuf/util/BUILD.bazel
index 3afe464cf..03a3045b3 100644
--- src/google/protobuf/util/BUILD.bazel
+++ src/google/protobuf/util/BUILD.bazel
@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix")
load("@rules_proto//proto:defs.bzl", "proto_library")
load("//build_defs:cpp_opts.bzl", "COPTS")
+package(features = ["-layering_check"])
+
cc_library(
name = "delimited_message_util",
srcs = ["delimited_message_util.cc"],
|
