diff options
author | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2022-01-08 02:03:42 +0000 |
---|---|---|
committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2022-01-08 02:03:42 +0000 |
commit | 286ad82330f5c7d694ca42863bf07a965f9b48c1 (patch) | |
tree | 123d9a48853401e3274e8842df926dd8d4e93eaf | |
parent | f9ffa1a2c74f3e71421ab56c56f184dda6c6235d (diff) | |
parent | e00b7a33847832df81b9f5bfc4c5df0be2e4d863 (diff) | |
download | icu-android12L-d2-s7-release.tar.gz |
Snap for 8055317 from e00b7a33847832df81b9f5bfc4c5df0be2e4d863 to sc-d2-releaseandroid-12.1.0_r26android-12.1.0_r25android-12.1.0_r24android-12.1.0_r23android-12.1.0_r18android-12.1.0_r17android-12.1.0_r16android-12.1.0_r15android-12.1.0_r14android-12.1.0_r13android-12.1.0_r12android12L-d2-s8-releaseandroid12L-d2-s7-releaseandroid12L-d2-s6-releaseandroid12L-d2-s5-releaseandroid12L-d2-s4-releaseandroid12L-d2-s3-releaseandroid12L-d2-s2-releaseandroid12L-d2-s1-releaseandroid12L-d2-release
Change-Id: Ia734090351f38119d3a6c793caed12281613864e
-rw-r--r-- | icu4c/source/test/cintltst/ccaltst.c | 10 | ||||
-rw-r--r-- | icu4c/source/test/intltest/tztest.cpp | 9 | ||||
-rw-r--r-- | icu4j/main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneTest.java | 6 |
3 files changed, 16 insertions, 9 deletions
diff --git a/icu4c/source/test/cintltst/ccaltst.c b/icu4c/source/test/cintltst/ccaltst.c index b6412c8a2..57cfe1d37 100644 --- a/icu4c/source/test/cintltst/ccaltst.c +++ b/icu4c/source/test/cintltst/ccaltst.c @@ -118,6 +118,7 @@ static void TestCalendar() char tempMsgBuf2[256]; // u_austrcpy() of some formatted dates & times. UChar zone1[64], zone2[64]; const char *tzver = 0; + int32_t tzverLen = 0; UChar canonicalID[64]; UBool isSystemID = FALSE; const UCalGetTypeTest * ucalGetTypeTestPtr; @@ -272,10 +273,13 @@ static void TestCalendar() tzver = ucal_getTZDataVersion(&status); if (U_FAILURE(status)) { log_err_status(status, "FAIL: ucal_getTZDataVersion() => %s\n", u_errorName(status)); - } else if (uprv_strlen(tzver) != 5 /*4 digits + 1 letter*/) { - log_err("FAIL: Bad version string was returned by ucal_getTZDataVersion\n"); } else { - log_verbose("PASS: ucal_getTZDataVersion returned %s\n", tzver); + tzverLen = uprv_strlen(tzver); + if (tzverLen == 5 || tzverLen == 6 /* 4 digits + 1 or 2 letters */) { + log_verbose("PASS: ucal_getTZDataVersion returned %s\n", tzver); + } else { + log_err("FAIL: Bad version string was returned by ucal_getTZDataVersion\n"); + } } /*Testing ucal_getCanonicalTimeZoneID*/ diff --git a/icu4c/source/test/intltest/tztest.cpp b/icu4c/source/test/intltest/tztest.cpp index b877db516..376370051 100644 --- a/icu4c/source/test/intltest/tztest.cpp +++ b/icu4c/source/test/intltest/tztest.cpp @@ -152,10 +152,13 @@ TimeZoneTest::TestGenericAPI() const char* tzver = TimeZone::getTZDataVersion(status); if (U_FAILURE(status)) { errcheckln(status, "FAIL: getTZDataVersion failed - %s", u_errorName(status)); - } else if (uprv_strlen(tzver) != 5 /* 4 digits + 1 letter */) { - errln((UnicodeString)"FAIL: getTZDataVersion returned " + tzver); } else { - logln((UnicodeString)"tzdata version: " + tzver); + int32_t tzverLen = uprv_strlen(tzver); + if (tzverLen == 5 || tzverLen == 6 /* 4 digits + 1 or 2 letters */) { + logln((UnicodeString)"tzdata version: " + tzver); + } else { + errln((UnicodeString)"FAIL: getTZDataVersion returned " + tzver); + } } } diff --git a/icu4j/main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneTest.java b/icu4j/main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneTest.java index 180894db9..13880884d 100644 --- a/icu4j/main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneTest.java +++ b/icu4j/main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneTest.java @@ -551,10 +551,10 @@ public class TimeZoneTest extends TestFmwk String tzver = TimeZone.getTZDataVersion(); - if (tzver.length() != 5 /* 4 digits + 1 letter */) { - errln("FAIL: getTZDataVersion returned " + tzver); - } else { + if (tzver != null && (tzver.length() == 5 || tzver.length() == 6) /* 4 digits + 1 or 2 letters */ ) { logln("PASS: tzdata version: " + tzver); + } else { + errln("FAIL: getTZDataVersion returned " + tzver); } } |