diff options
| author | Robert Findley <rfindley@google.com> | 2023-03-06 15:00:24 -0500 |
|---|---|---|
| committer | Robert Findley <rfindley@google.com> | 2023-03-07 14:48:13 +0000 |
| commit | 031fc75960d487b0b15db12fb328676236a3a39c (patch) | |
| tree | 00a56583aae9a84d7c1b17fbf2c53ab70f23d6b8 | |
| parent | f477bf4a4181665f9244412427a423fe7e7f0c19 (diff) | |
| download | golang-x-tools-031fc75960d487b0b15db12fb328676236a3a39c.tar.gz | |
gopls/internal/regtest/bench: don't run the iwl test with -short
The new InitialWorkspaceLoad benchmark relies on a memstats command that
does not exist in the released version of gopls (v0.11.0). We're
configuring x/benchmarks to run with -short, so use this to guard
against breaking the benchmark suite with this new test.
Change-Id: I64e673fca793c51bd17d0245330543402fd86ec8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/473677
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
| -rw-r--r-- | gopls/internal/regtest/bench/iwl_test.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gopls/internal/regtest/bench/iwl_test.go b/gopls/internal/regtest/bench/iwl_test.go index 974fc1eb1..352078e7f 100644 --- a/gopls/internal/regtest/bench/iwl_test.go +++ b/gopls/internal/regtest/bench/iwl_test.go @@ -16,6 +16,11 @@ import ( // BenchmarkInitialWorkspaceLoad benchmarks the initial workspace load time for // a new editing session. func BenchmarkInitialWorkspaceLoad(b *testing.B) { + if testing.Short() { + // TODO(rfindley): remove this skip once the released gopls version + // supports the memstats command. + b.Skip("temporarily skipping as baseline gopls versions do not support the memstats command") + } tests := []struct { repo string file string |