aboutsummaryrefslogtreecommitdiff
path: root/proto/encode_test.go
diff options
context:
space:
mode:
Diffstat (limited to 'proto/encode_test.go')
-rw-r--r--proto/encode_test.go321
1 files changed, 64 insertions, 257 deletions
diff --git a/proto/encode_test.go b/proto/encode_test.go
index 967def78..1909f110 100644
--- a/proto/encode_test.go
+++ b/proto/encode_test.go
@@ -1,278 +1,85 @@
-// Copyright 2019 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
+// Go support for Protocol Buffers - Google's data interchange format
+//
+// Copyright 2010 The Go Authors. All rights reserved.
+// https://github.com/golang/protobuf
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// +build go1.7
package proto_test
import (
- "bytes"
- "fmt"
- "math"
- "reflect"
+ "strconv"
"testing"
- "github.com/google/go-cmp/cmp"
-
- "google.golang.org/protobuf/encoding/prototext"
- "google.golang.org/protobuf/encoding/protowire"
- "google.golang.org/protobuf/proto"
- pref "google.golang.org/protobuf/reflect/protoreflect"
-
- "google.golang.org/protobuf/internal/errors"
- orderpb "google.golang.org/protobuf/internal/testprotos/order"
- testpb "google.golang.org/protobuf/internal/testprotos/test"
- test3pb "google.golang.org/protobuf/internal/testprotos/test3"
+ "github.com/golang/protobuf/proto"
+ tpb "github.com/golang/protobuf/proto/proto3_proto"
+ "github.com/golang/protobuf/ptypes"
)
-func TestEncode(t *testing.T) {
- for _, test := range testValidMessages {
- for _, want := range test.decodeTo {
- t.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(t *testing.T) {
- opts := proto.MarshalOptions{
- AllowPartial: test.partial,
- }
- wire, err := opts.Marshal(want)
- if err != nil {
- t.Fatalf("Marshal error: %v\nMessage:\n%v", err, prototext.Format(want))
- }
-
- size := proto.Size(want)
- if size != len(wire) {
- t.Errorf("Size and marshal disagree: Size(m)=%v; len(Marshal(m))=%v\nMessage:\n%v", size, len(wire), prototext.Format(want))
- }
-
- got := want.ProtoReflect().New().Interface()
- uopts := proto.UnmarshalOptions{
- AllowPartial: test.partial,
- }
- if err := uopts.Unmarshal(wire, got); err != nil {
- t.Errorf("Unmarshal error: %v\nMessage:\n%v", err, prototext.Format(want))
- return
- }
- if !proto.Equal(got, want) && got.ProtoReflect().IsValid() && want.ProtoReflect().IsValid() {
- t.Errorf("Unmarshal returned unexpected result; got:\n%v\nwant:\n%v", prototext.Format(got), prototext.Format(want))
- }
- })
- }
- }
-}
+var (
+ blackhole []byte
+)
-func TestEncodeDeterministic(t *testing.T) {
- for _, test := range testValidMessages {
- for _, want := range test.decodeTo {
- t.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(t *testing.T) {
- opts := proto.MarshalOptions{
- Deterministic: true,
- AllowPartial: test.partial,
- }
- wire, err := opts.Marshal(want)
+// BenchmarkAny creates increasingly large arbitrary Any messages. The type is always the
+// same.
+func BenchmarkAny(b *testing.B) {
+ data := make([]byte, 1<<20)
+ quantum := 1 << 10
+ for i := uint(0); i <= 10; i++ {
+ b.Run(strconv.Itoa(quantum<<i), func(b *testing.B) {
+ for k := 0; k < b.N; k++ {
+ inner := &tpb.Message{
+ Data: data[:quantum<<i],
+ }
+ outer, err := ptypes.MarshalAny(inner)
if err != nil {
- t.Fatalf("Marshal error: %v\nMessage:\n%v", err, prototext.Format(want))
+ b.Error("wrong encode", err)
}
- wire2, err := opts.Marshal(want)
+ raw, err := proto.Marshal(&tpb.Message{
+ Anything: outer,
+ })
if err != nil {
- t.Fatalf("Marshal error: %v\nMessage:\n%v", err, prototext.Format(want))
- }
- if !bytes.Equal(wire, wire2) {
- t.Fatalf("deterministic marshal returned varying results:\n%v", cmp.Diff(wire, wire2))
- }
-
- got := want.ProtoReflect().New().Interface()
- uopts := proto.UnmarshalOptions{
- AllowPartial: test.partial,
- }
- if err := uopts.Unmarshal(wire, got); err != nil {
- t.Errorf("Unmarshal error: %v\nMessage:\n%v", err, prototext.Format(want))
- return
- }
- if !proto.Equal(got, want) && got.ProtoReflect().IsValid() && want.ProtoReflect().IsValid() {
- t.Errorf("Unmarshal returned unexpected result; got:\n%v\nwant:\n%v", prototext.Format(got), prototext.Format(want))
- }
- })
- }
- }
-}
-
-func TestEncodeRequiredFieldChecks(t *testing.T) {
- for _, test := range testValidMessages {
- if !test.partial {
- continue
- }
- for _, m := range test.decodeTo {
- t.Run(fmt.Sprintf("%s (%T)", test.desc, m), func(t *testing.T) {
- _, err := proto.Marshal(m)
- if err == nil {
- t.Fatalf("Marshal succeeded (want error)\nMessage:\n%v", prototext.Format(m))
+ b.Error("wrong encode", err)
}
- })
- }
- }
-}
-
-func TestEncodeAppend(t *testing.T) {
- want := []byte("prefix")
- got := append([]byte(nil), want...)
- got, err := proto.MarshalOptions{}.MarshalAppend(got, &test3pb.TestAllTypes{
- SingularString: "value",
- })
- if err != nil {
- t.Fatal(err)
- }
- if !bytes.HasPrefix(got, want) {
- t.Fatalf("MarshalAppend modified prefix: got %v, want prefix %v", got, want)
- }
-}
-
-func TestEncodeInvalidMessages(t *testing.T) {
- for _, test := range testInvalidMessages {
- for _, m := range test.decodeTo {
- if !m.ProtoReflect().IsValid() {
- continue
+ blackhole = raw
}
- t.Run(fmt.Sprintf("%s (%T)", test.desc, m), func(t *testing.T) {
- opts := proto.MarshalOptions{
- AllowPartial: test.partial,
- }
- got, err := opts.Marshal(m)
- if err == nil {
- t.Fatalf("Marshal unexpectedly succeeded\noutput bytes: [%x]\nMessage:\n%v", got, prototext.Format(m))
- }
- if !errors.Is(err, proto.Error) {
- t.Fatalf("Marshal error is not a proto.Error: %v", err)
- }
- })
- }
- }
-}
-
-func TestEncodeOneofNilWrapper(t *testing.T) {
- m := &testpb.TestAllTypes{OneofField: (*testpb.TestAllTypes_OneofUint32)(nil)}
- b, err := proto.Marshal(m)
- if err != nil {
- t.Fatal(err)
- }
- if len(b) > 0 {
- t.Errorf("Marshal return non-empty, want empty")
- }
-}
-
-func TestMarshalAppendAllocations(t *testing.T) {
- m := &test3pb.TestAllTypes{SingularInt32: 1}
- size := proto.Size(m)
- const count = 1000
- b := make([]byte, size)
- // AllocsPerRun returns an integral value.
- marshalAllocs := testing.AllocsPerRun(count, func() {
- _, err := proto.MarshalOptions{}.MarshalAppend(b[:0], m)
- if err != nil {
- t.Fatal(err)
- }
- })
- b = nil
- marshalAppendAllocs := testing.AllocsPerRun(count, func() {
- var err error
- b, err = proto.MarshalOptions{}.MarshalAppend(b, m)
- if err != nil {
- t.Fatal(err)
- }
- })
- if marshalAllocs != marshalAppendAllocs {
- t.Errorf("%v allocs/op when writing to a preallocated buffer", marshalAllocs)
- t.Errorf("%v allocs/op when repeatedly appending to a slice", marshalAppendAllocs)
- t.Errorf("expect amortized allocs/op to be identical")
- }
-}
-
-func TestEncodeOrder(t *testing.T) {
- // We make no guarantees about the stability of wire marshal output.
- // The order in which fields are marshaled may change over time.
- // If deterministic marshaling is not enabled, it may change over
- // successive calls to proto.Marshal in the same binary.
- //
- // Unfortunately, many users have come to rely on the specific current
- // wire marshal output. Perhaps someday we will choose to deliberately
- // change the marshal output; until that day comes, this test verifies
- // that we don't unintentionally change it.
- m := &orderpb.Message{
- Field_1: proto.String("one"),
- Field_2: proto.String("two"),
- Field_20: proto.String("twenty"),
- Oneof_1: &orderpb.Message_Field_10{"ten"},
- }
- proto.SetExtension(m, orderpb.E_Field_30, "thirty")
- proto.SetExtension(m, orderpb.E_Field_31, "thirty-one")
- proto.SetExtension(m, orderpb.E_Field_32, "thirty-two")
- want := []pref.FieldNumber{
- 30, 31, 32, // extensions first, in number order
- 1, 2, 20, // non-extension, non-oneof in number order
- 10, // oneofs last, undefined order
- }
-
- // Test with deterministic serialization, since fields are not sorted without
- // it when -tags=protoreflect.
- b, err := proto.MarshalOptions{Deterministic: true}.Marshal(m)
- if err != nil {
- t.Fatal(err)
- }
- var got []pref.FieldNumber
- for len(b) > 0 {
- num, _, n := protowire.ConsumeField(b)
- if n < 0 {
- t.Fatal(protowire.ParseError(n))
- }
- b = b[n:]
- got = append(got, num)
- }
- if !reflect.DeepEqual(got, want) {
- t.Errorf("unexpected field marshal order:\ngot: %v\nwant: %v\nmessage:\n%v", got, want, m)
- }
-}
-
-func TestEncodeLarge(t *testing.T) {
- // Encode/decode a message large enough to overflow a 32-bit size cache.
- t.Skip("too slow and memory-hungry to run all the time")
- size := int64(math.MaxUint32 + 1)
- m := &testpb.TestAllTypes_NestedMessage{
- Corecursive: &testpb.TestAllTypes{
- OptionalBytes: make([]byte, size),
- },
- }
- b, err := proto.Marshal(m)
- if err != nil {
- t.Fatalf("Marshal: %v", err)
- }
- if got, want := len(b), proto.Size(m); got != want {
- t.Fatalf("Size(m) = %v, but len(Marshal(m)) = %v", got, want)
- }
- if err := proto.Unmarshal(b, m); err != nil {
- t.Fatalf("Unmarshal: %v", err)
- }
- if got, want := int64(len(m.Corecursive.OptionalBytes)), size; got != want {
- t.Errorf("after round-trip marshal, got len(m.OptionalBytes) = %v, want %v", got, want)
+ })
}
}
-// TestEncodeEmpty tests for boundary conditions when producing an empty output.
-// These tests are not necessarily a statement of proper behavior,
-// but exist to detect accidental changes in behavior.
-func TestEncodeEmpty(t *testing.T) {
- for _, m := range []proto.Message{nil, (*testpb.TestAllTypes)(nil), &testpb.TestAllTypes{}} {
- isValid := m != nil && m.ProtoReflect().IsValid()
-
- b, err := proto.Marshal(m)
+// BenchmarkEmpty measures the overhead of doing the minimal possible encode.
+func BenchmarkEmpty(b *testing.B) {
+ for i := 0; i < b.N; i++ {
+ raw, err := proto.Marshal(&tpb.Message{})
if err != nil {
- t.Errorf("proto.Marshal() = %v", err)
- }
- if isNil := b == nil; isNil == isValid {
- t.Errorf("proto.Marshal() == nil: %v, want %v", isNil, !isValid)
- }
-
- b, err = proto.MarshalOptions{}.Marshal(m)
- if err != nil {
- t.Errorf("proto.MarshalOptions{}.Marshal() = %v", err)
- }
- if isNil := b == nil; isNil == isValid {
- t.Errorf("proto.MarshalOptions{}.Marshal() = %v, want %v", isNil, !isValid)
+ b.Error("wrong encode", err)
}
+ blackhole = raw
}
}