aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbromano <bromano@snapchat.com>2024-04-26 17:34:32 -0700
committerfalhassen <falhassen@users.noreply.github.com>2024-04-29 10:23:23 -0700
commita7351b0ecf6656ad937fbc52fe9e90d3b289c265 (patch)
treebfde1c2a53e86a802293b6d58bcc5fec94e22d3c
parentacced70df733f34a2c28311e0625829af8ca4bc1 (diff)
downloadglide-upstream-master.tar.gz
Avoid referencing resource names within Resource Loaderupstream-master
-rw-r--r--library/src/main/java/com/bumptech/glide/load/model/ResourceLoader.java4
-rw-r--r--library/test/src/test/java/com/bumptech/glide/load/model/ResourceLoaderTest.java2
2 files changed, 2 insertions, 4 deletions
diff --git a/library/src/main/java/com/bumptech/glide/load/model/ResourceLoader.java b/library/src/main/java/com/bumptech/glide/load/model/ResourceLoader.java
index 1175315a..ad48104b 100644
--- a/library/src/main/java/com/bumptech/glide/load/model/ResourceLoader.java
+++ b/library/src/main/java/com/bumptech/glide/load/model/ResourceLoader.java
@@ -52,9 +52,7 @@ public class ResourceLoader<Data> implements ModelLoader<Integer, Data> {
+ "://"
+ resources.getResourcePackageName(model)
+ '/'
- + resources.getResourceTypeName(model)
- + '/'
- + resources.getResourceEntryName(model));
+ + model);
} catch (Resources.NotFoundException e) {
if (Log.isLoggable(TAG, Log.WARN)) {
Log.w(TAG, "Received invalid resource id: " + model, e);
diff --git a/library/test/src/test/java/com/bumptech/glide/load/model/ResourceLoaderTest.java b/library/test/src/test/java/com/bumptech/glide/load/model/ResourceLoaderTest.java
index 1bda30e2..708dba9d 100644
--- a/library/test/src/test/java/com/bumptech/glide/load/model/ResourceLoaderTest.java
+++ b/library/test/src/test/java/com/bumptech/glide/load/model/ResourceLoaderTest.java
@@ -49,7 +49,7 @@ public class ResourceLoaderTest {
@Test
public void testCanHandleId() {
int id = android.R.drawable.star_off;
- Uri contentUri = Uri.parse("android.resource://android/drawable/star_off");
+ Uri contentUri = Uri.parse("android.resource://android/" + String.valueOf(id));
when(uriLoader.buildLoadData(eq(contentUri), anyInt(), anyInt(), any(Options.class)))
.thenReturn(new ModelLoader.LoadData<>(key, fetcher));