summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndroid Build Coastguard Worker <android-build-coastguard-worker@google.com>2022-12-14 02:28:20 +0000
committerAndroid Build Coastguard Worker <android-build-coastguard-worker@google.com>2022-12-14 02:28:20 +0000
commit91b3f6dd9b079ca48119e1dae34c887b6b641202 (patch)
tree3501dadfc8a8559645900663b74f481da07c113f
parent596fa8888fd77d61c9730be16271821ff0515d0e (diff)
parent2e02df8552fcfb0facd2d1e324b227190a73a7bb (diff)
downloadexpat-91b3f6dd9b079ca48119e1dae34c887b6b641202.tar.gz
Change-Id: Ic5d7aa2ed46828a29153cae6a457ff80efb57f58
-rw-r--r--lib/xmlparse.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/lib/xmlparse.c b/lib/xmlparse.c
index 7db28d07..7e981919 100644
--- a/lib/xmlparse.c
+++ b/lib/xmlparse.c
@@ -1066,6 +1066,14 @@ parserCreate(const XML_Char *encodingName,
parserInit(parser, encodingName);
if (encodingName && ! parser->m_protocolEncodingName) {
+ if (dtd) {
+ // We need to stop the upcoming call to XML_ParserFree from happily
+ // destroying parser->m_dtd because the DTD is shared with the parent
+ // parser and the only guard that keeps XML_ParserFree from destroying
+ // parser->m_dtd is parser->m_isParamEntity but it will be set to
+ // XML_TRUE only later in XML_ExternalEntityParserCreate (or not at all).
+ parser->m_dtd = NULL;
+ }
XML_ParserFree(parser);
return NULL;
}