1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
|
////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code for adherence to a set of rules.
// Copyright (C) 2001-2017 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
////////////////////////////////////////////////////////////////////////////////
package com.puppycrawl.tools.checkstyle.checks.coding;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_ASSIGN;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_EXPR;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_IDENT;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_LAMBDA;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_LITERAL;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_RETURN;
import static com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck.MSG_STRING;
import org.junit.Assert;
import org.junit.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.utils.CommonUtils;
/**
* Test fixture for the UnnecessaryParenthesesCheck.
*
* @author Eric K. Roe
*/
public class UnnecessaryParenthesesCheckTest extends AbstractModuleTestSupport {
@Override
protected String getPackageLocation() {
return "com/puppycrawl/tools/checkstyle/checks/coding/unnecessaryparentheses";
}
@Test
public void testDefault() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(UnnecessaryParenthesesCheck.class);
final String[] expected = {
"5:22: " + getCheckMessage(MSG_ASSIGN),
"5:29: " + getCheckMessage(MSG_EXPR),
"5:31: " + getCheckMessage(MSG_IDENT, "i"),
"5:46: " + getCheckMessage(MSG_ASSIGN),
"6:15: " + getCheckMessage(MSG_ASSIGN),
"7:14: " + getCheckMessage(MSG_IDENT, "x"),
"7:17: " + getCheckMessage(MSG_ASSIGN),
"8:15: " + getCheckMessage(MSG_ASSIGN),
"9:14: " + getCheckMessage(MSG_IDENT, "x"),
"9:17: " + getCheckMessage(MSG_ASSIGN),
"12:22: " + getCheckMessage(MSG_ASSIGN),
"12:30: " + getCheckMessage(MSG_IDENT, "i"),
"12:46: " + getCheckMessage(MSG_ASSIGN),
"16:17: " + getCheckMessage(MSG_LITERAL, "0"),
"26:11: " + getCheckMessage(MSG_ASSIGN),
"30:11: " + getCheckMessage(MSG_ASSIGN),
"32:11: " + getCheckMessage(MSG_ASSIGN),
"34:11: " + getCheckMessage(MSG_ASSIGN),
"35:16: " + getCheckMessage(MSG_IDENT, "a"),
"36:14: " + getCheckMessage(MSG_IDENT, "a"),
"36:20: " + getCheckMessage(MSG_IDENT, "b"),
"36:26: " + getCheckMessage(MSG_LITERAL, "600"),
"36:40: " + getCheckMessage(MSG_LITERAL, "12.5f"),
"36:56: " + getCheckMessage(MSG_IDENT, "arg2"),
"37:14: " + getCheckMessage(MSG_STRING, "\"this\""),
"37:25: " + getCheckMessage(MSG_STRING, "\"that\""),
"38:11: " + getCheckMessage(MSG_ASSIGN),
"38:14: " + getCheckMessage(MSG_STRING, "\"this is a really, really...\""),
"40:16: " + getCheckMessage(MSG_RETURN),
"44:21: " + getCheckMessage(MSG_LITERAL, "1"),
"44:26: " + getCheckMessage(MSG_LITERAL, "13.5"),
"45:22: " + getCheckMessage(MSG_LITERAL, "true"),
"46:17: " + getCheckMessage(MSG_IDENT, "b"),
"50:17: " + getCheckMessage(MSG_ASSIGN),
"52:11: " + getCheckMessage(MSG_ASSIGN),
"54:16: " + getCheckMessage(MSG_RETURN),
"64:13: " + getCheckMessage(MSG_EXPR),
"68:16: " + getCheckMessage(MSG_EXPR),
"73:19: " + getCheckMessage(MSG_EXPR),
"74:23: " + getCheckMessage(MSG_LITERAL, "4000"),
"79:19: " + getCheckMessage(MSG_ASSIGN),
"81:11: " + getCheckMessage(MSG_ASSIGN),
"81:16: " + getCheckMessage(MSG_LITERAL, "3"),
"82:39: " + getCheckMessage(MSG_ASSIGN),
};
verify(checkConfig, getPath("InputUnnecessaryParenthesesOperatorsAndCasts.java"), expected);
}
@Test
public void test15Extensions() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(UnnecessaryParenthesesCheck.class);
final String[] expected = CommonUtils.EMPTY_STRING_ARRAY;
verify(checkConfig, getPath("InputUnnecessaryParentheses15Extensions.java"), expected);
}
@Test
public void testLambdas() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(UnnecessaryParenthesesCheck.class);
checkConfig.addAttribute("tokens", "LAMBDA");
final String[] expected = {
"10:35: " + getCheckMessage(MSG_LAMBDA),
"11:35: " + getCheckMessage(MSG_LAMBDA),
"18:18: " + getCheckMessage(MSG_LAMBDA),
"19:57: " + getCheckMessage(MSG_LAMBDA),
"38:25: " + getCheckMessage(MSG_LAMBDA),
"38:33: " + getCheckMessage(MSG_LAMBDA),
"41:25: " + getCheckMessage(MSG_LAMBDA),
"44:31: " + getCheckMessage(MSG_LAMBDA),
};
verify(checkConfig, getPath("InputUnnecessaryParenthesesLambdas.java"), expected);
}
@Test
public void testTokensNotNull() {
final UnnecessaryParenthesesCheck check = new UnnecessaryParenthesesCheck();
Assert.assertNotNull("Acceptable tokens should not be null", check.getAcceptableTokens());
Assert.assertNotNull("Default tokens should not be null", check.getDefaultTokens());
Assert.assertNotNull("Required tokens should not be null", check.getRequiredTokens());
}
}
|
