1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
|
////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code for adherence to a set of rules.
// Copyright (C) 2001-2017 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
////////////////////////////////////////////////////////////////////////////////
package com.puppycrawl.tools.checkstyle.checks.coding;
import static com.puppycrawl.tools.checkstyle.checks.coding.IllegalTypeCheck.MSG_KEY;
import java.io.File;
import org.junit.Assert;
import org.junit.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
import com.puppycrawl.tools.checkstyle.utils.CommonUtils;
public class IllegalTypeCheckTest extends AbstractModuleTestSupport {
@Override
protected String getPackageLocation() {
return "com/puppycrawl/tools/checkstyle/checks/coding/illegaltype";
}
@Test
public void testValidateAbstractClassNamesSetToTrue() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("validateAbstractClassNames", "true");
final String[] expected = {
"27:5: " + getCheckMessage(MSG_KEY, "AbstractClass"),
"29:37: " + getCheckMessage(MSG_KEY, "AbstractClass"),
"33:12: " + getCheckMessage(MSG_KEY, "AbstractClass"),
};
verify(checkConfig, getPath("InputIllegalTypeAbstractClassNames.java"), expected);
}
@Test
public void testValidateAbstractClassNamesSetToFalse() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("validateAbstractClassNames", "false");
final String[] expected = CommonUtils.EMPTY_STRING_ARRAY;
verify(checkConfig, getPath("InputIllegalTypeAbstractClassNames.java"), expected);
}
@Test
public void testDefaults() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
final String[] expected = {
"16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
"17:13: " + getCheckMessage(MSG_KEY, "TreeSet"),
};
verify(checkConfig, getPath("InputIllegalType.java"), expected);
}
@Test
public void testIgnoreMethodNames() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("ignoredMethodNames", "table2");
checkConfig.addAttribute("validateAbstractClassNames", "true");
final String[] expected = {
"6:13: " + getCheckMessage(MSG_KEY, "AbstractClass"),
"9:13: " + getCheckMessage(MSG_KEY,
"com.puppycrawl.tools.checkstyle.checks.coding.illegaltype."
+ "InputIllegalType.AbstractClass"),
"16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
};
verify(checkConfig, getPath("InputIllegalType.java"), expected);
}
@Test
public void testFormat() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("format", "^$");
final String[] expected = {
"16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
"17:13: " + getCheckMessage(MSG_KEY, "TreeSet"),
};
verify(checkConfig, getPath("InputIllegalType.java"), expected);
}
@Test
public void testLegalAbstractClassNames() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("validateAbstractClassNames", "true");
checkConfig.addAttribute("legalAbstractClassNames", "AbstractClass");
final String[] expected = {
"9:13: " + getCheckMessage(MSG_KEY,
"com.puppycrawl.tools.checkstyle.checks.coding.illegaltype."
+ "InputIllegalType.AbstractClass"),
"16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
"17:13: " + getCheckMessage(MSG_KEY, "TreeSet"),
};
verify(checkConfig, getPath("InputIllegalType.java"), expected);
}
@Test
public void testSameFileNameFalsePositive() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("illegalClassNames", "java.util.GregorianCalendar, SubCalendar, "
+ "java.util.List");
final String[] expected = {
"12:5: " + getCheckMessage(MSG_KEY, "SubCalendar"),
"27:5: " + getCheckMessage(MSG_KEY, "java.util.List"),
};
verify(checkConfig, getPath("InputIllegalTypeSameFileName.java"), expected);
}
@Test
public void testSameFileNameGeneral() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("illegalClassNames",
"List, InputIllegalTypeGregorianCalendar, java.io.File, ArrayList, Boolean");
final String[] expected = {
"10:5: " + getCheckMessage(MSG_KEY, "InputIllegalTypeGregorianCalendar"),
"16:23: " + getCheckMessage(MSG_KEY, "InputIllegalTypeGregorianCalendar"),
"24:9: " + getCheckMessage(MSG_KEY, "List"),
"25:9: " + getCheckMessage(MSG_KEY, "java.io.File"),
"27:5: " + getCheckMessage(MSG_KEY, "java.util.List"),
"28:13: " + getCheckMessage(MSG_KEY, "ArrayList"),
"29:13: " + getCheckMessage(MSG_KEY, "Boolean"),
"30:13: " + getCheckMessage(MSG_KEY, "Boolean"),
"31:13: " + getCheckMessage(MSG_KEY, "Boolean"),
};
verify(checkConfig, getPath("InputIllegalTypeSameFileName.java"), expected);
}
@Test
public void testStarImports() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("illegalClassNames", "List");
final String[] expected = {
"10:5: " + getCheckMessage(MSG_KEY, "List"),
};
verify(checkConfig, getPath("InputIllegalTypeStarImports.java"), expected);
}
@Test
public void testStaticImports() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("illegalClassNames", "SomeStaticClass");
checkConfig.addAttribute("ignoredMethodNames", "foo1");
final String[] expected = {
"13:6: " + getCheckMessage(MSG_KEY, "SomeStaticClass"),
"15:31: " + getCheckMessage(MSG_KEY, "SomeStaticClass"),
};
verify(checkConfig, getPath("InputIllegalTypeStaticImports.java"), expected);
}
@Test
public void testMemberModifiers() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("validateAbstractClassNames", "true");
checkConfig.addAttribute("memberModifiers", "LITERAL_PRIVATE, LITERAL_PROTECTED,"
+ " LITERAL_STATIC");
final String[] expected = {
"6:13: " + getCheckMessage(MSG_KEY, "AbstractClass"),
"9:13: " + getCheckMessage(MSG_KEY,
"com.puppycrawl.tools.checkstyle.checks.coding.illegaltype."
+ "InputIllegalTypeMemberModifiers.AbstractClass"),
"16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
"17:13: " + getCheckMessage(MSG_KEY, "TreeSet"),
"23:15: " + getCheckMessage(MSG_KEY,
"com.puppycrawl.tools.checkstyle.checks.coding.illegaltype."
+ "InputIllegalTypeMemberModifiers.AbstractClass"),
"25:25: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
"33:15: " + getCheckMessage(MSG_KEY, "AbstractClass"),
};
verify(checkConfig, getPath("InputIllegalTypeMemberModifiers.java"), expected);
}
@Test
public void testClearDataBetweenFiles() throws Exception {
final DefaultConfiguration checkConfig = createModuleConfig(IllegalTypeCheck.class);
final String violationFile = getPath("InputIllegalType.java");
checkConfig.addAttribute("illegalClassNames", "java.util.TreeSet");
final String[] expected = {
"16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"),
"17:13: " + getCheckMessage(MSG_KEY, "TreeSet"),
};
verify(createChecker(checkConfig), new File[] {
new File(violationFile),
new File(getPath("InputIllegalTypeSimilarClassName.java")),
}, violationFile, expected);
}
@Test
public void testTokensNotNull() {
final IllegalTypeCheck check = new IllegalTypeCheck();
Assert.assertNotNull("Acceptable tokens should not be null", check.getAcceptableTokens());
Assert.assertNotNull("Default tokens should not be null", check.getDefaultTokens());
Assert.assertNotNull("Required tokens should not be null", check.getRequiredTokens());
}
@Test
public void testImproperToken() {
final IllegalTypeCheck check = new IllegalTypeCheck();
final DetailAST classDefAst = new DetailAST();
classDefAst.setType(TokenTypes.CLASS_DEF);
try {
check.visitToken(classDefAst);
Assert.fail("IllegalStateException is expected");
}
catch (IllegalStateException ex) {
// it is OK
}
}
}
|
