aboutsummaryrefslogtreecommitdiff
path: root/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java
diff options
context:
space:
mode:
Diffstat (limited to 'src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java')
-rw-r--r--src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java19
1 files changed, 14 insertions, 5 deletions
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java
index a6f08bf1d..f769c754c 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java
@@ -392,6 +392,10 @@ public class ImportOrderCheck
}
doVisitToken(ident, isStatic, isStaticAndNotLastImport);
+ if (isStaticAndNotLastImport && !beforeFirstImport) {
+ log(ident.getLineNo(), MSG_ORDERING, ident.getText());
+ }
+
}
else if (option == ImportOrderOption.BOTTOM) {
@@ -401,6 +405,10 @@ public class ImportOrderCheck
}
doVisitToken(ident, isStatic, isLastImportAndNonStatic);
+ if (isLastImportAndNonStatic) {
+ log(ident.getLineNo(), MSG_ORDERING, ident.getText());
+ }
+
}
else if (option == ImportOrderOption.ABOVE) {
// previous non-static but current is static
@@ -440,14 +448,15 @@ public class ImportOrderCheck
final int groupIdx = getGroupNumber(name);
final int line = ident.getLineNo();
- if (isInSameGroup(groupIdx, isStatic)) {
- doVisitTokenInSameGroup(isStatic, previous, name, line);
- }
- else if (groupIdx > lastGroup) {
- if (!beforeFirstImport && separated && line - lastImportLine < 2) {
+ if (groupIdx > lastGroup) {
+ if (!beforeFirstImport && separated && line - lastImportLine < 2
+ && !isInSameGroup(groupIdx, isStatic)) {
log(line, MSG_SEPARATION, name);
}
}
+ else if (isInSameGroup(groupIdx, isStatic)) {
+ doVisitTokenInSameGroup(isStatic, previous, name, line);
+ }
else {
log(line, MSG_ORDERING, name);
}