diff options
| author | Adam Langley <agl@chromium.org> | 2018-03-30 14:28:51 -0700 |
|---|---|---|
| committer | Adam Vartanian <flooey@google.com> | 2018-04-04 10:19:38 +0100 |
| commit | d494bf0220b56b302497738b294d836da2415df1 (patch) | |
| tree | f5372d2dfe0d2083f58884a42bd1c8f469ce4d52 | |
| parent | 3ef76b39e2b1b3ce091b518cb4f4b9f7a9d3abeb (diff) | |
| download | boringssl-pie-dr1-dev.tar.gz | |
Cherry-pick Fiat P-256 fix.android-9.0.0_r30android-9.0.0_r22android-9.0.0_r21android-9.0.0_r20android-9.0.0_r19android-9.0.0_r16android-9.0.0_r12android-9.0.0_r11pie-qpr1-s3-releasepie-qpr1-s2-releasepie-qpr1-s1-releasepie-qpr1-releasepie-dr1-releasepie-dr1-devpie-dev
This change cherry-picks BoringSSL's 5fca61391822252baf3dc37529ba02f6d7611acf:
Fix typo in point_add.
Rather than writing the answer into the output, it wrote it into some
awkwardly-named temporaries. Thanks to Daniel Hirche for reporting this
issue!
Bug: chromium:825273
Reviewed-on: https://boringssl-review.googlesource.com/26785
Reviewed-by: Adam Langley <agl@google.com>
Test: deployed internally without issues and in Chromium trunk.
(cherry picked from commit 4613b5a4482c911e9b4ab5fe1ef8ea5321070b67)
Bug: 77520979
Change-Id: I0adb747694d745dc8583e402a270f8113fbe1d9c
Merged-In: Ib055444e3e06fbcce8b07c2b9e8355f98bde0786
| -rw-r--r-- | src/third_party/fiat/p256.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/third_party/fiat/p256.c b/src/third_party/fiat/p256.c index f1d53165..2fe2f867 100644 --- a/src/third_party/fiat/p256.c +++ b/src/third_party/fiat/p256.c @@ -1120,7 +1120,7 @@ static void point_add(fe x3, fe y3, fe z3, const fe x1, limb_t yneq = fe_nz(r); if (!xneq && !yneq && z1nz && z2nz) { - point_double(x_out, y_out, z_out, x1, y1, z1); + point_double(x3, y3, z3, x1, y1, z1); return; } |