| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
|
Backport !3582 “Buffer needs to be aligned correctly to receive linux_dirent64.” to glib-2-76
See merge request GNOME/glib!3615
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
|
|
Backport !3539 “gdbusmessage: Validate required headers have the right type” to glib-2-76
See merge request GNOME/glib!3558
|
|
Backport !3555 “gkeyfile: Fix overwriting of GError” to glib-2-76
See merge request GNOME/glib!3557
|
|
The fields are fully validated in `validate_headers()` in
`gdbusmessage.c` now, so the connection code should be able to rely on
the required ones being non-`NULL`.
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
Helps: #3061
|
|
`object_path` and `path` were doing exactly the same thing here.
This introduces no functional changes.
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
|
|
We already validated that the required headers for each type of D-Bus
message were present. However, we didn’t validate that they contained a
variant of the right type. This could lead to functions like
`g_dbus_message_get_path()` returning `NULL` unexpectedly.
This failure could only be hit when using GDBus in peer-to-peer mode, or
with a D-Bus server which didn’t validate the headers itself. The
reference D-Bus server does validate the headers, and doesn’t forward
invalid messages to clients.
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
Fixes: #3061
|
|
When parsing a line of "key3=foo\i\" in a keyfile,
g_key_file_parse_value_as_string currently first sets the error to
'contains invalid escape' and later to 'contains escape character at end
of line'.
This leaks the first GError and causes the following warning message:
Error set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is
NULL before it's set. The overwriting error message was: Key file
contains escape character at end of line
Fix this by returning when an error is detected. As we may have
collected data in pieces, we instead collect to a tmp_pieces GSList and
free it on error.
|
|
Backport !3554 “gresourcefile: Fix crash if called with a badly escaped URI” to glib-2-76
See merge request GNOME/glib!3556
|
|
Return an invalid `GFile` instead, as is the custom for VFS functions.
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
Fixes: #3090
|
|
Backport !3547 “glib/gfileutils.c: use 64 bits for value in get_tmp_file()” to glib-2-76
See merge request GNOME/glib!3549
|
|
On 32 bit systems 'long' value will overflow in 2038 and become negative.
As it is used to index into letters array, and % operation preserves signs,
data corruption will then occur.
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
|
|
Backport !3529 “gmenuexporter: synchronization in org_gtk_Menus_get_interface.” to glib-2-76
See merge request GNOME/glib!3531
|
|
Protects the mutation inside org_gtk_Menus_get_interface with
g_once_init_{enter,leave}.
Fixes #3051.
|
|
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
|
Backport !3473 ”glib: reset errno to 0 when futex() returns EAGAIN” to glib-2-76
See merge request GNOME/glib!3479
|
|
Backport !3482 “glocalfileinfo: Fix incorrect use of struct statx.st_mtimensec on Android” to glib-2-76
See merge request GNOME/glib!3492
|
|
For some reason, `time_t` is defined as being 32 bits wide on that
platform, which causes truncation of the timestamps from `struct stat`.
Avoid that problem by consistently using a 64-bit return value from the
`struct stat` accessors.
Helps: #3039
|
|
`_g_stat_has_field (statbuf, G_LOCAL_FILE_STAT_FIELD_ATIME)` will always
return `TRUE` on Windows (since it uses a basic `struct stat`), so the
platform-inspecific code is equivalent to the Windows-specific code.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
|
`GLocalFileStat` is a platform-specific abstraction around `struct stat`
or `struct statx`. If `struct statx` is available, it will use that by
preference as it has more features.
`glocalfileinfo.c` was, in some places, incorrectly accessing the fields
of `GLocalFileStat` directly rather than through its `_g_stat_*()`
getters. While it correctly accounted for the platform-specific
differences between `st_mtimensec` and `st_mtim.tv_nsec`, it hadn’t been
updated to deal with `stx_mtime`.
On Android, `st_mtimensec` is defined as a fallback for
`st_mtim.tv_nsec` (even though it doesn’t need to be). This caused GLib
to take the `st_mtimensec` code path rather than the `stx_mtime` code
path, and hence try to dereference `st_mtim` in a `struct statx`.
Fix that by correctly using the `_g_stat_*()` getters consistently.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #3039
|
|
|
|
'glib-2-76'
Backport !3468 “Avoid stack overflow in gspawn on macOS” to glib-2-76
See merge request GNOME/glib!3480
|
|
|
|
|
|
|
|
|
|
'glib-2-76'
Backport !3446 “glib-compile-resources: Fix non-ASCII arg parsing on Windows” to glib-2-76
See merge request GNOME/glib!3447
|
|
When the source directory contains non-ASCII symbols,
argument parsing previously failed on MINGW64.
Fixes: #3003
|
|
When the source directory contains non-ASCII symbols,
argument parsing previously failed on MINGW64.
Fixes: #3003
|
|
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
|
|
Backport !3430 “gobject_gdb.py: fix regression caused by bfbe7127d5” to glib-2-76
See merge request GNOME/glib!3434
|
