diff options
| author | Alex Eagle <alex@aspect.dev> | 2023-11-01 07:35:00 -0700 |
|---|---|---|
| committer | Alex Eagle <alex@aspect.dev> | 2023-11-01 07:35:00 -0700 |
| commit | ec3afe01cd88265978b4dfe276171844da2a9929 (patch) | |
| tree | e071d2d7525a3ea3b2eb532272e6d51d588abd79 | |
| parent | f925776ac6685cb05c0bc9705dc6639a4e34f99f (diff) | |
| download | bazelbuild-rules-proto-ec3afe01cd88265978b4dfe276171844da2a9929.tar.gz | |
style: code review comments
| -rw-r--r-- | .bcr/metadata.template.json | 9 | ||||
| -rw-r--r-- | .github/workflows/release_prep.sh | 10 |
2 files changed, 8 insertions, 11 deletions
diff --git a/.bcr/metadata.template.json b/.bcr/metadata.template.json index 4c900e8..79772a7 100644 --- a/.bcr/metadata.template.json +++ b/.bcr/metadata.template.json @@ -2,8 +2,11 @@ "homepage": "https://github.com/bazelbuild/rules_proto", "maintainers": [ { - "github": "comius", - "name": "Ivo List" + "github": "googleberg", + "name": "Jerry Berg" + }, + { + "github": "zhangskz" }, { "email": "alex@aspect.dev", @@ -17,7 +20,7 @@ } ], "versions": [], - "yanked_versions": {} + "yanked_versions": {}, "repository": [ "github:bazelbuild/rules_proto" ] diff --git a/.github/workflows/release_prep.sh b/.github/workflows/release_prep.sh index 9197c4f..8fc1749 100644 --- a/.github/workflows/release_prep.sh +++ b/.github/workflows/release_prep.sh @@ -11,13 +11,7 @@ readonly TAG=${GITHUB_REF_NAME} readonly PREFIX="rules_proto-${TAG}" readonly ARCHIVE="${PREFIX}.tar.gz" -# Configuration for 'git archive' -# see https://git-scm.com/docs/git-archive/2.40.0#ATTRIBUTES -cat >.git/info/attributes <<EOF -# Omit folders that users don't need, making the distribution artifact smaller -tests export-ignore -EOF - +# NB: configuration for 'git archive' is in /.gitattributes git archive --format=tar --prefix=${PREFIX}/ ${TAG} | gzip > $ARCHIVE SHA=$(shasum -a 256 $ARCHIVE | awk '{print $1}') @@ -25,7 +19,7 @@ SHA=$(shasum -a 256 $ARCHIVE | awk '{print $1}') cat << EOF ## Using bzlmod with Bazel 6 or later: -1. Add \`common --enable_bzlmod\` to \`.bazelrc\`. +1. [Bazel 6] Add \`common --enable_bzlmod\` to \`.bazelrc\`. 2. Add to your \`MODULE.bazel\` file: |