diff options
| author | Josh Gao <jmgao@google.com> | 2017-10-16 14:10:08 -0700 |
|---|---|---|
| committer | Josh Gao <jmgao@google.com> | 2017-10-18 16:23:17 -0700 |
| commit | 91d19d565c6f401c1349cd4999eeb38d9b9fa942 (patch) | |
| tree | 3279c97e78cf501037196b7630ed6309f9073646 | |
| parent | 2f33ad21a5c3688c33c1f36665216d76bac47f2c (diff) | |
| download | art-oreo-mr1-dev.tar.gz | |
signal_catcher: print errno when tombstoned_notify_completion fails.oreo-mr1-dev
Failure here could either be someone internal closing our FD (EBADF) or
tombstoned closing its end of the socket (EPIPE). Print the error to
disambiguate the cases.
Bug: 67805174
Test: treehugger
Change-Id: Ie35cb31218b5bb08757e61360c6539d39eece08b
(cherry picked from commit ff9e43fa6dcd44cecb81149c8410c071ef840723)
| -rw-r--r-- | runtime/signal_catcher.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/runtime/signal_catcher.cc b/runtime/signal_catcher.cc index f0b6ee4a58..523584e352 100644 --- a/runtime/signal_catcher.cc +++ b/runtime/signal_catcher.cc @@ -169,7 +169,7 @@ void SignalCatcher::Output(const std::string& s) { #if defined(ART_TARGET_ANDROID) if (use_tombstoned_stack_trace_fd_ && !tombstoned_notify_completion(tombstone_fd)) { - LOG(WARNING) << "Unable to notify tombstoned of dump completion."; + PLOG(WARNING) << "Unable to notify tombstoned of dump completion"; } #endif } |