aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulien Duraj <julien.duraj@linaro.org>2019-08-29 17:17:05 +0100
committerJulien Duraj <julien.duraj@linaro.org>2019-09-02 10:36:44 +0100
commite8e4ec4fbb83ae8a003ee8a7979bc324c6a0f4bc (patch)
treebe92095bf9e323e9e44c32d27b3b0f5695be7bd9
parentc3f4acca9caf04ef8788355c2be11a3a68ace5ad (diff)
downloadart-testing-e8e4ec4fbb83ae8a003ee8a7979bc324c6a0f4bc.tar.gz
framework: fix Java checkstyle errors.
Change-Id: I20c6d6a9f42db87dffb241d86065821165b6702d
-rw-r--r--framework/org/linaro/bench/Benchmark.java14
-rw-r--r--framework/org/linaro/bench/RunBench.java6
-rw-r--r--framework/org/linaro/bench/Util.java2
3 files changed, 12 insertions, 10 deletions
diff --git a/framework/org/linaro/bench/Benchmark.java b/framework/org/linaro/bench/Benchmark.java
index d9abc42..30a7b5a 100644
--- a/framework/org/linaro/bench/Benchmark.java
+++ b/framework/org/linaro/bench/Benchmark.java
@@ -177,24 +177,24 @@ public class Benchmark {
public boolean accept(Method method);
}
- private final static class SetupMethodSelector implements MethodSelector {
+ private static final class SetupMethodSelector implements MethodSelector {
public boolean accept(Method method) {
return method.getName().startsWith(SETUP_METHOD_PREFIX) && method.getParameterCount() == 0;
}
}
- private static boolean DoesMethodHaveOneIntParam(Method method) {
+ private static boolean doesMethodHaveOneIntParam(Method method) {
return method.getParameterCount() == 1 && method.getParameterTypes()[0] == int.class;
}
- private final static class TimeBenchmarkMethodSelector implements MethodSelector {
+ private static final class TimeBenchmarkMethodSelector implements MethodSelector {
public boolean accept(Method method) {
return method.getName().startsWith(TIME_BENCH_METHOD_PREFIX)
- && DoesMethodHaveOneIntParam(method);
+ && doesMethodHaveOneIntParam(method);
}
}
- private final static class ParticularBenchmarkMethodSelector implements MethodSelector {
+ private static final class ParticularBenchmarkMethodSelector implements MethodSelector {
private String particularBenchMethodName;
public ParticularBenchmarkMethodSelector(String methodName) {
@@ -203,11 +203,11 @@ public class Benchmark {
public boolean accept(Method method) {
return method.getName().equals(particularBenchMethodName)
- && DoesMethodHaveOneIntParam(method);
+ && doesMethodHaveOneIntParam(method);
}
}
- private final static class VerifyMethodSelector implements MethodSelector {
+ private static final class VerifyMethodSelector implements MethodSelector {
public boolean accept(Method method) {
return method.getName().startsWith(VERIFY_BENCH_METHOD_PREFIX)
&& method.getReturnType() == boolean.class
diff --git a/framework/org/linaro/bench/RunBench.java b/framework/org/linaro/bench/RunBench.java
index 11517f0..2dae5da 100644
--- a/framework/org/linaro/bench/RunBench.java
+++ b/framework/org/linaro/bench/RunBench.java
@@ -54,10 +54,12 @@ public class RunBench {
benchmarkTargetRunTimeNs);
Benchmark.Result[] results = benchmark.run();
int verifyFailures = 0;
- if (verify)
+ if (verify) {
verifyFailures = benchmark.verify();
- for (Benchmark.Result result : results)
+ }
+ for (Benchmark.Result result : results) {
System.out.println(result.toString());
+ }
if (verifyFailures > 0) {
return 1;
}
diff --git a/framework/org/linaro/bench/Util.java b/framework/org/linaro/bench/Util.java
index 66ce1a6..9c5bd37 100644
--- a/framework/org/linaro/bench/Util.java
+++ b/framework/org/linaro/bench/Util.java
@@ -17,8 +17,8 @@
package org.linaro.bench;
-import java.io.ByteArrayOutputStream;
import java.io.BufferedReader;
+import java.io.ByteArrayOutputStream;
import java.io.FileReader;
import java.io.IOException;
import java.io.OutputStream;