diff options
| author | Dotan Barak <dotanb@dev.mellanox.co.il> | 2016-06-22 17:27:31 +0300 |
|---|---|---|
| committer | popcornmix <popcornmix@gmail.com> | 2016-08-23 14:58:51 +0100 |
| commit | 1d6e7083134ff5edf53d1560d74cca7ca0b0904c (patch) | |
| tree | a9ded6340fca56426865c9992517a44220991294 | |
| parent | 8f3150664da2ae1d8a26deaad55801ef284c3099 (diff) | |
| download | pi-v4.4-1d6e7083134ff5edf53d1560d74cca7ca0b0904c.tar.gz | |
IB/mlx4: Fix memory leak if QP creation failed
commit 5b420d9cf7382c6e1512e96e02d18842d272049c upstream.
When RC, UC, or RAW QPs are created, a qp object is allocated (kzalloc).
If at a later point (in procedure create_qp_common) the qp creation fails,
this qp object must be freed.
Fixes: 1ffeb2eb8be99 ("IB/mlx4: SR-IOV IB context objects and proxy/tunnel SQP support")
Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/infiniband/hw/mlx4/qp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c index 482e9783641a..ea1e2ddaddf5 100644 --- a/drivers/infiniband/hw/mlx4/qp.c +++ b/drivers/infiniband/hw/mlx4/qp.c @@ -1162,8 +1162,10 @@ struct ib_qp *mlx4_ib_create_qp(struct ib_pd *pd, { err = create_qp_common(to_mdev(pd->device), pd, init_attr, udata, 0, &qp, gfp); - if (err) + if (err) { + kfree(qp); return ERR_PTR(err); + } qp->ibqp.qp_num = qp->mqp.qpn; qp->xrcdn = xrcdn; |