summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-21Snap for 8626064 from 2f505b46955ab7619f8652b19dc9888be4db487e to ↵aml_go_ads_330915100aml_go_ads_330915000aml_go_ads_330913000android13-mainline-go-adservices-releaseAndroid Build Coastguard Worker
mainline-go-adservices-release Change-Id: Iffd0e314d7306f0bd2028909ed041e04d27ab03e
2022-05-09wlan: support multiple nvram/clmandroid13-devRoger Wang
Extend supporting table Bug: 231662351 Bug: 231661700 Test: files can be loaded correctly Change-Id: Ib339b0c7d4b5a1e1b2bb34da22755dd14100a08e
2022-04-28Snap for 8505378 from 79464da5e668de737368f899dac7d730fb8aacc5 to ↵Android Build Coastguard Worker
mainline-go-adservices-release Change-Id: I0a424c70f27ee37ba9b07821276e2e2e67362179
2022-04-22Merge "HAL: Added attributes for PKTID to the event handler for ↵TreeHugger Robot
GOOGLE_FILE_DUMP_EVENT" into tm-dev
2022-04-22Fix for deadlock between hal cmd and event based cmd.Ajay Davanageri
Local pthread_mutex_lock in handleResponse() is not required, as all the vendor hal apis from legacy Hal are protected with the GlobalLock . bug:228092853 Test: Verified on oriole platform Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.com> Change-Id: I77df86dd3f794c4e260af60d979ff81c7074ef9e
2022-04-21HAL: Added attributes for PKTID to the event handler for GOOGLE_FILE_DUMP_EVENTAjay Davanageri
When DHD sends GOOGLE_FILE_DUMP_EVENT, PKTID logs are included as well. In order to dump them properly, some attributes for PKTID logs have been added. Bug: 229551181 Test: verified on device and PKDID dump can be find in debug dump. Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.com> Change-Id: I4a49db204dac945bb352911f79963d0673333889
2022-04-15Implementation of chre nan apis, nan status callbacks to chre and pre-emptionnaveen.cprg
Bug: 206614765 Test: Have CHRE interact with APIs and validate NAN session starts Test: Use halutil commands to verify no crash happens Signed-off-by: naveen.cprg <naveen.cprg@broadcom.com> Change-Id: Ie181c0e666365cc5630b2461f2c13fa609698610
2022-03-22Fix to prevent the hal crash during the event_loop path.Ajay Davanageri
Bug: 217699915 Test: Verified build in hikey960 Test: Basic function works fine on C10 Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.com> Change-Id: I296ff7dc075fde574b5ec1356fd79f99117ef52a
2022-03-15Merge "HAL: Add RING_DUMP feature to avoid overrun socket buffer" into tm-devRoger Wang
2022-03-14HAL: Add RING_DUMP feature to avoid overrun socket bufferDennis Jeon
When dhd_mem_dump() ocrrus, DHD sends bulky data to HAL through netlink socket for debugging. This sometimes overruns the socket buffer and drops important events. To avoid this, replace socket event-based communication with memcpy-based(copy_to_user) for vulky data BUG: 205673231 Test: sanity test passed Signed-off-by: Dennis Jeon <dennis.jeon@broadcom.corp-partner.google.com> Change-Id: I3e324ae528752069943cbfaca08c98cf90edddf7
2022-03-10Fix for second enable failure to handle the instant mode channel.Ajay Davanageri
Bug: 219106895 Test: Verified ACTS on oriole platform Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.com> Change-Id: Ibd74ea10e51c0438f0f24cfad8eb7527fbd365f4 (cherry picked from commit b9d7856f62d9daf1c0326964e044efb4f7ee9c32) Merged-In: Ibd74ea10e51c0438f0f24cfad8eb7527fbd365f4
2022-03-09[automerger skipped] Merge "Merge Android 12L" am: ceafbfa033 -s ours am: ↵Xin Li
10ea65c0a1 -s ours am: 01303706e3 -s ours am skip reason: Merged-In I3f481ff3c48d84971d4a499648e688eaed4637fe with SHA-1 d7cf82ba13 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/2013321 Change-Id: I5c8568942d585385ddab683ddca604852702d843
2022-03-09[automerger skipped] Merge Android 12L am: 3de1bc349d -s ours am: 9952216f43 ↵Xin Li
-s ours am: e66e53338a -s ours am skip reason: Merged-In I3f481ff3c48d84971d4a499648e688eaed4637fe with SHA-1 d7cf82ba13 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/2013321 Change-Id: I96b1b2014bb5be0587dce6ba66168eb04f2778ca
2022-03-08[automerger skipped] Merge "Merge Android 12L" am: ceafbfa033 -s ours am: ↵Xin Li
10ea65c0a1 -s ours am skip reason: Merged-In I3f481ff3c48d84971d4a499648e688eaed4637fe with SHA-1 d7cf82ba13 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/2013321 Change-Id: I0500ecf53bebb13a6bcf328a0409828d6fd45cfe
2022-03-08[automerger skipped] Merge Android 12L am: 3de1bc349d -s ours am: 9952216f43 ↵Xin Li
-s ours am skip reason: Merged-In I3f481ff3c48d84971d4a499648e688eaed4637fe with SHA-1 d7cf82ba13 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/2013321 Change-Id: I570ce1275576f75339e5b5a3f2e2b86ecbb45d8b
2022-03-08[automerger skipped] Merge "Merge Android 12L" am: ceafbfa033 -s oursXin Li
am skip reason: Merged-In I3f481ff3c48d84971d4a499648e688eaed4637fe with SHA-1 d7cf82ba13 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/2013321 Change-Id: If5209314fb32cf52cf8bef39a23d2a86e60700a2
2022-03-08[automerger skipped] Merge Android 12L am: 3de1bc349d -s oursXin Li
am skip reason: Merged-In I3f481ff3c48d84971d4a499648e688eaed4637fe with SHA-1 d7cf82ba13 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/2013321 Change-Id: Ia46f68adf6195f84a7b691075903f56b99aef133
2022-03-08Merge "Merge Android 12L"Xin Li
2022-03-07Support for HAL API to get the simultaneous Radio Capability of the ChipAjay
Bug: 208877624 Test: Verified on hikey960 using the halutil cli halutil -getSupportedRadioMatrix Signed-off-by: Ajay <ajay.davanageri@broadcom.com> Change-Id: I191c6553a03eef8e93a45f8854c97468da7cf75a
2022-03-08Merge Android 12LXin Li
Bug: 222710654 Merged-In: I3f481ff3c48d84971d4a499648e688eaed4637fe Change-Id: I0ddd898504dad331d78be86320559d99cc4c4f3a
2022-02-14[automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: ↵Xin Li
d7cf82ba13 -s ours am: 6cf75bc4c5 -s ours am skip reason: Merged-In Icf4354c4eee74cac3ebedcaba1116320e750b2a3 with SHA-1 c835c0483b is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/16844480 Change-Id: Ia4a9835bdad3afeb5ad7d775545c4a0dee2bba4a
2022-02-14[automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: ↵Xin Li
d7cf82ba13 -s ours am skip reason: Merged-In Icf4354c4eee74cac3ebedcaba1116320e750b2a3 with SHA-1 c835c0483b is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/16844480 Change-Id: I9c7195ece36a822f6cc5cb9f1596132bd053b17f
2022-02-11Fix for aware enable failure caused due to invalid instant mode channelAjay Davanageri
Added enable instant mode and config checks before processing it down to the driver. Bug: 216658673 Test: Verified ACTS on oriole platform Test: sanity test passed Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.com> Change-Id: I8d8310145ee4052b1851be85eb45acc678ca4092
2022-02-11Merge sc-v2-dev-plus-aosp-without-vendor@8084891sam_222710654Xin Li
Bug: 214455710 Merged-In: Icf4354c4eee74cac3ebedcaba1116320e750b2a3 Change-Id: I3f481ff3c48d84971d4a499648e688eaed4637fe
2022-01-15Merge "HAL: Support NAN3.1"Edmond Chung
2022-01-14Extending Radio stats for supported radios.Ajay Davanageri
Bug: 208371177 Test: Verified on pixel6/hikey960 Test: Passed sanity test Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.corp-partner.google.com> Change-Id: I06d5ad2667b628f1363a5a1ea7cc393e6097fd36
2022-01-14HAL: Support NAN3.1Swaraj.Vutturi
Bug: 193761115 Test: Verified on Hikey960 platform. Signed-off-by: Swaraj.Vutturi <swaraj.vutturi@broadcom.corp-partner.google.com> Change-Id: Iddf9d4132234ccdae92d228c09f4f82eb0bb9ad8
2022-01-06Add OWNERS fileEtan Cohen
Bug: 213465444 Test: N/A Change-Id: I23b1e1dfcb574a2ed9803f68120e7b4a79d45c76
2021-12-22[automerger skipped] HAL: Fixed vendor HAL crash due to missing ↵Damon Kim
unregisterVendorHandler() in some failure case am: c835c0483b am: fd39d364f5 -s ours am skip reason: Merged-In Icf4354c4eee74cac3ebedcaba1116320e750b2a3 with SHA-1 9d4683f3e3 is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/16518321 Change-Id: I6e8dceada00493bb92e9896d419d5655c6d3031d
2021-12-22HAL: Fixed vendor HAL crash due to missing unregisterVendorHandler() in some ↵Damon Kim
failure case am: c835c0483b Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/16518321 Change-Id: I21ef91c9b1b89e12a997e885e3d7c654a182357b
2021-12-22HAL: Fixed vendor HAL crash due to missing unregisterVendorHandler() in some ↵android-12.1.0_r9android-12.1.0_r8android-12.1.0_r7android-12.1.0_r22android-12.1.0_r21android-12.1.0_r20android-12.1.0_r19android-12.1.0_r11android-12.1.0_r10android12L-devandroid12-qpr3-s7-releaseandroid12-qpr3-s6-releaseandroid12-qpr3-s5-releaseandroid12-qpr3-s4-releaseandroid12-qpr3-s3-releaseandroid12-qpr3-s2-releaseandroid12-qpr3-s1-releaseandroid12-qpr3-releaseDamon Kim
failure case WifiNative Failure(HAL crash) happened in vendor hal library due to FORTIFY abort. According to the FORTIFY message, it caused by pthread_mutex_destroy called on a destroyed mutex. The situation is as follows: ----------------------- 1. RTT cmd failed, so that cmd unregistered, cmd object destroyed. But, vendor handler is still exist in the related list. 2. RTT event received. It handled in internal_valid_message_handler() since the record of RTT vendor handler is still exist. 3. Finally, FORTIFY abort detected when pthread_mutext_destroy() on destroyed memory during releaseRef() |- internal_valid_message_handler() |- cmd->releaseRef() |- destructor chains called |- ... |- ~Condition() /* crashed here when try to destroy mMutex member */ ----------------------- Hence, this won't be happened if unregisterVendorhandler() called properly in some failure cases. In case of RTT cmd failure, unregisterVendorhandler() should be called before wifi_unregister_cmd() & object destroyed. In addition, all places with this pattern have been fixed together. Bug: 210167945 Test: Local build done for Hikey960/Android 12(S), basic Wi-Fi functions worked well. Test: passed sanity test Change-Id: Icf4354c4eee74cac3ebedcaba1116320e750b2a3 Merged-In: Icf4354c4eee74cac3ebedcaba1116320e750b2a3 (cherry picked from commit 9d4683f3e3304848b3bfd883ade0649bb024573b)
2021-12-22Merge "HAL: Fixed vendor HAL crash due to missing unregisterVendorHandler() ↵Roger Wang
in some failure case"
2021-12-22HAL: Fixed vendor HAL crash due to missing unregisterVendorHandler() in some ↵Damon Kim
failure case WifiNative Failure(HAL crash) happened in vendor hal library due to FORTIFY abort. According to the FORTIFY message, it caused by pthread_mutex_destroy called on a destroyed mutex. The situation is as follows: ----------------------- 1. RTT cmd failed, so that cmd unregistered, cmd object destroyed. But, vendor handler is still exist in the related list. 2. RTT event received. It handled in internal_valid_message_handler() since the record of RTT vendor handler is still exist. 3. Finally, FORTIFY abort detected when pthread_mutext_destroy() on destroyed memory during releaseRef() |- internal_valid_message_handler() |- cmd->releaseRef() |- destructor chains called |- ... |- ~Condition() /* crashed here when try to destroy mMutex member */ ----------------------- Hence, this won't be happened if unregisterVendorhandler() called properly in some failure cases. In case of RTT cmd failure, unregisterVendorhandler() should be called before wifi_unregister_cmd() & object destroyed. In addition, all places with this pattern have been fixed together. Bug: 207297786 Test: Local build done for Hikey960/Android 12(S), basic Wi-Fi functions worked well. Test: passed sanity test Change-Id: Icf4354c4eee74cac3ebedcaba1116320e750b2a3
2021-12-20Merge "compiler warning for unused variables"Sunil Ravi
2021-12-17Merge "Fix missing comma" am: 398f4a07e1 am: af97769c0a am: 749b055f1a am: ↵Treehugger Robot
2d3d30d690 Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1927218 Change-Id: I865699411f45f861c645406c3107c32637592784
2021-12-17Merge "Fix missing comma" am: 398f4a07e1 am: af97769c0a am: 749b055f1aTreehugger Robot
Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1927218 Change-Id: I6207e5bc94265489cd0dbb83f70de6004f761f72
2021-12-17Merge "Fix missing comma" am: 398f4a07e1 am: af97769c0aTreehugger Robot
Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1927218 Change-Id: Iae70b82586cc3aa736b05d439feca93dee54204b
2021-12-17Merge "Fix missing comma" am: 398f4a07e1Treehugger Robot
Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1927218 Change-Id: I1dbb0b73514159b0a96f44993540f698e35d1758
2021-12-17Merge "Fix missing comma"android-t-preview-2android-t-preview-1android-t-beta-3android-s-v2-beta-3android-s-qpr3-beta-1android-t-preview-1android-s-v2-beta-3android-s-qpr3-beta-1Treehugger Robot
2021-12-17Fix missing commaYi Kong
This is discovered by Clang's -Wstring-concatenation diagnostic. Change-Id: I6a46d8e1315982a0f8dfadd77cfe6747ec00be6c
2021-12-14[automerger skipped] Merge "Merge Android 12 QPR1" am: d41b719e63 -s ours ↵Xin Li
am: 2cfa38c034 -s ours am: 2e5c371203 -s ours am: c80f106b5b -s ours am skip reason: Merged-In I5fe51e116f4a99c3cdf0aadbeae4f8706499a1b1 with SHA-1 a81d4a87d0 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1921957 Change-Id: If4193909539c469727f478dbe0c8a8b0f069398e
2021-12-14[automerger skipped] Merge "Merge Android 12 QPR1" am: d41b719e63 -s ours ↵Xin Li
am: 2cfa38c034 -s ours am: 2e5c371203 -s ours am skip reason: Merged-In I5fe51e116f4a99c3cdf0aadbeae4f8706499a1b1 with SHA-1 a81d4a87d0 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1921957 Change-Id: I4043d166810873e5645311b45468d48e388a8d17
2021-12-14compiler warning for unused variablesSunil Ravi
Removed unused variables. Bug: 210714284 Test: STA connected to AP Change-Id: Iecac67da5675e65f7f4130ef7e7d71c94d57dfed
2021-12-14[automerger skipped] Merge "Merge Android 12 QPR1" am: d41b719e63 -s ours ↵Xin Li
am: 2cfa38c034 -s ours am skip reason: Merged-In I5fe51e116f4a99c3cdf0aadbeae4f8706499a1b1 with SHA-1 a81d4a87d0 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1921957 Change-Id: I9d317a7e8cb594055c03b69ef853ab2d7dd9d4b0
2021-12-14[automerger skipped] Merge "Merge Android 12 QPR1" am: d41b719e63 -s oursXin Li
am skip reason: Merged-In I5fe51e116f4a99c3cdf0aadbeae4f8706499a1b1 with SHA-1 a81d4a87d0 is already in history Original change: https://android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/1921957 Change-Id: Ic129635172b7805aa8469139b4b795c25a46a076
2021-12-14Merge "Merge Android 12 QPR1"Xin Li
2021-12-14Merge Android 12 QPR1Xin Li
Bug: 210511427 Merged-In: I5fe51e116f4a99c3cdf0aadbeae4f8706499a1b1 Change-Id: I7b3a2852d6ddaa529db2286e809a5fe8d2b7a56c
2021-12-08HAL: Fixed vendor HAL crash due to use-after-free am: 1bdf26126f am: b46c3bd5aaDamon Kim
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/16418512 Change-Id: Ia99ff8852fcefc8c083dfc339ff3563dffd18c94
2021-12-08HAL: Fixed vendor HAL crash due to use-after-free am: 1bdf26126fDamon Kim
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/broadcom/wlan/+/16418512 Change-Id: Ic953be045a6578cf8c54976ce087658a711d5998
2021-12-08HAL: Fixed vendor HAL crash due to use-after-freeDamon Kim
Vendor HAL crash happened due to use-after-free during RSSI monitor operation. So, segmentation fault happened due to wrong memory access. The situation is as follows: ----------------------- // 11-21 13:26:17.284209 827 827 I WifiHAL : Successfully set RSSI monitoring 1. RSSI monitoring start // The object(SetRSSIMonitorCommand, 0xb400007d2ba53970) has been deleted somewhere without calling unregisterVendorhandler(). 2. About 40mins passed ~ // cmd->addRef(); /* invalid memory access => addr 0x50455f5245544651 */ 3. Hal crashed due to use-after-free ----------------------- Any logs for unregisterVendorhandler() & freeing the SetRSSIMonitorCommand object doesn't exist during that time. So, the object(SetRSSIMonitorCommand, 0xb400007d2ba53970) seems to have been freed for some unknown reason. We decided to fix like below: ----------------------- - Add a destructor on the class, run unregisterVendorhandler() when the object is destroyed. - Add more debug logs to find out why the object is destroyed. ----------------------- We expect that the HAL crash may not happen by the destructor operation. Bug: 207297786 Test: Verified using halutil, rssi_monitor function works well. Test: Passed sanity test Change-Id: Iaa30c7e0d901ae65d807258bed8239951f9be942
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-12 20:11:59 +0000