diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2022-03-19 03:47:59 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2022-03-19 03:47:59 +0000 |
commit | 3be73388e7960314981ae5bfe6b7f3e2ffc2e06c (patch) | |
tree | b5751d9ba577548393cfeef704efb05b0959f089 | |
parent | a1e987759b3e967e688d07c07233ccf528cda324 (diff) | |
parent | d9c8ae8d143635c134bd68e273f7ea7547b9481c (diff) | |
download | ethernet-3be73388e7960314981ae5bfe6b7f3e2ffc2e06c.tar.gz |
Merge "Cleaning EthernetNetworkFactoryTest Unprovisioned" am: d9c8ae8d14
Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/net/ethernet/+/2017355
Change-Id: I3caa708a007760ccd25115860be55c0bc5158565
-rw-r--r-- | tests/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/tests/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java b/tests/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java index 726833f..e256add 100644 --- a/tests/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java +++ b/tests/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java @@ -279,19 +279,13 @@ public class EthernetNetworkFactoryTest { // creates an unprovisioned interface private void createUnprovisionedInterface(String iface) throws Exception { - // the only way to create an unprovisioned interface is by calling needNetworkFor - // followed by releaseNetworkFor which will stop the NetworkAgent and IpClient. When - // EthernetNetworkFactory#updateInterfaceLinkState(iface, true) is called, the interface - // is automatically provisioned even if nobody has ever called needNetworkFor + // To create an unprovisioned interface, provision and then "stop" it, i.e. stop its + // NetworkAgent and IpClient. One way this can be done is by provisioning an interface and + // then calling onNetworkUnwanted. createAndVerifyProvisionedInterface(iface); - // Interface is already provisioned, so startProvisioning / register should not be called - // again - mNetFactory.needNetworkFor(createDefaultRequest()); - verify(mIpClient, never()).startProvisioning(any()); - verify(mNetworkAgent, never()).register(); - - mNetFactory.releaseNetworkFor(createDefaultRequest()); + mNetworkAgent.getCallbacks().onNetworkUnwanted(); + mLooper.dispatchAll(); verifyStop(); clearInvocations(mIpClient); |