diff options
author | Barış Kaya <bkaya@google.com> | 2023-09-05 15:44:38 +0100 |
---|---|---|
committer | Barış Kaya <bkaya@google.com> | 2023-09-06 16:00:44 +0100 |
commit | f5b06f03e3ea67fbc0fbe6d86e6d3c130fca92d0 (patch) | |
tree | 297d14d70c58611f3e5ddcfb16c576a9c7694c40 | |
parent | e0bb5c365b8871fe2066fcd6ca84ec4a1a6352b6 (diff) | |
download | gamesdk-f5b06f03e3ea67fbc0fbe6d86e6d3c130fca92d0.tar.gz |
Fix memInfo.pid being unpopulated in some cases.
The unpopulated pid caused a failure in memory telemetry collection. This should fix the issue and prevent accompanying errors from being printed.
Bug: b/296368368
Test: Tested using experimentsdemo
Change-Id: I761dc41267b9ce0a0c9c939d06273ab6fd6e84af
-rw-r--r-- | games-performance-tuner/core/memory_telemetry.cpp | 9 | ||||
-rw-r--r-- | games-performance-tuner/core/memory_telemetry.h | 1 |
2 files changed, 5 insertions, 5 deletions
diff --git a/games-performance-tuner/core/memory_telemetry.cpp b/games-performance-tuner/core/memory_telemetry.cpp index 46ea0ea3..b7690eb8 100644 --- a/games-performance-tuner/core/memory_telemetry.cpp +++ b/games-performance-tuner/core/memory_telemetry.cpp @@ -165,14 +165,13 @@ void DefaultMemInfoProvider::UpdateOomScore() { } } } +DefaultMemInfoProvider::DefaultMemInfoProvider() { + memInfo.initialized = true; + memInfo.pid = (uint32_t)android_process_.myPid(); +} void DefaultMemInfoProvider::SetEnabled(bool enabled) { enabled_ = enabled; - - if (enabled && !memInfo.initialized) { - memInfo.initialized = true; - memInfo.pid = (uint32_t)android_process_.myPid(); - } } bool DefaultMemInfoProvider::GetEnabled() const { return enabled_; } diff --git a/games-performance-tuner/core/memory_telemetry.h b/games-performance-tuner/core/memory_telemetry.h index b8922148..7ab7f64a 100644 --- a/games-performance-tuner/core/memory_telemetry.h +++ b/games-performance-tuner/core/memory_telemetry.h @@ -64,6 +64,7 @@ class DefaultMemInfoProvider : public IMemInfoProvider { MemInfo memInfo; public: + DefaultMemInfoProvider(); void UpdateMemInfo() override; void UpdateOomScore() override; uint64_t GetNativeHeapAllocatedSize() override; |