diff options
| author | Victor Khimenko <khim@google.com> | 2023-12-14 01:06:36 +0000 |
|---|---|---|
| committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2023-12-14 01:06:36 +0000 |
| commit | e9ab9928e0e61bf3be6ed3e77f8a036014d5e19e (patch) | |
| tree | 0881ae1933f757f300c194bd4852cc4a60e054d1 | |
| parent | f573d4bc112c43b4cefc4df12e6b5403cfa0c303 (diff) | |
| parent | 9ecae22fcfd986c4438f23965138fc6b56af5db7 (diff) | |
| download | binary_translation-e9ab9928e0e61bf3be6ed3e77f8a036014d5e19e.tar.gz | |
Merge "Implement BitUtilLog2 efficiently" into main am: 9ecae22fcf
Original change: https://android-review.googlesource.com/c/platform/frameworks/libs/binary_translation/+/2874095
Change-Id: If4f3ff1a61b282c881ed1144c76e2e465811faf1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | base/include/berberis/base/bit_util.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/base/include/berberis/base/bit_util.h b/base/include/berberis/base/bit_util.h index e3610dde..4fb08470 100644 --- a/base/include/berberis/base/bit_util.h +++ b/base/include/berberis/base/bit_util.h @@ -70,8 +70,9 @@ constexpr bool IsAligned(T* p, size_t align) { template <typename T> constexpr T BitUtilLog2(T x) { static_assert(std::is_integral_v<T>, "Log2: T must be integral"); - DCHECK(IsPowerOf2(x)); - return x == 1 ? 0 : BitUtilLog2(x >> 1) + 1; + CHECK(IsPowerOf2(x)); + // TODO(b/260725458): Use std::countr_zero after C++20 becomes available + return __builtin_ctz(x); } // Verify that argument value fits into a target. |