diff options
author | Shuzhen Wang <shuzhenwang@google.com> | 2023-05-04 13:22:56 -0700 |
---|---|---|
committer | Shuzhen Wang <shuzhenwang@google.com> | 2023-05-10 20:49:31 +0000 |
commit | e260520abeea94db3412130f570495e52981af25 (patch) | |
tree | 53d64dffc32105b645b9e8c2e189e4c6555e871e | |
parent | 71cece32e6a0f97bd17d93799eb1fe85e43fa9d8 (diff) | |
download | interfaces-e260520abeea94db3412130f570495e52981af25.tar.gz |
Camera: VTS: initialize camera statuses after callback registration
For BasicCameraLifeCycleTest, callback registration returns the initial
camera statuses. Need to update the cameraId->status map accordingly.
In addition, fix the camera availability check by comparing against
PRESENT, and all other states are considered unavailable/not-present.
Test: atest VtsAidlCameraServiceTargetTest; vendor testing
Bug: 281777503
Change-Id: I4a76a3d54a5a94b99d628424264d6ffed65f8cbf
-rw-r--r-- | cameraservice/vts/functional/VtsAidlCameraServiceTargetTest.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/cameraservice/vts/functional/VtsAidlCameraServiceTargetTest.cpp b/cameraservice/vts/functional/VtsAidlCameraServiceTargetTest.cpp index 35e7ce2..9b5eab9 100644 --- a/cameraservice/vts/functional/VtsAidlCameraServiceTargetTest.cpp +++ b/cameraservice/vts/functional/VtsAidlCameraServiceTargetTest.cpp @@ -106,12 +106,12 @@ class CameraServiceListener : public BnCameraServiceListener { EXPECT_NE(mCameraStatuses.find(in_cameraId), mCameraStatuses.end()); EXPECT_EQ(mCameraStatuses[in_cameraId], CameraDeviceStatus::STATUS_PRESENT); - if (in_status == CameraDeviceStatus::STATUS_NOT_PRESENT) { - auto res = mUnavailablePhysicalCameras[in_cameraId].emplace(in_physicalCameraId); - EXPECT_TRUE(res.second); - } else { + if (in_status == CameraDeviceStatus::STATUS_PRESENT) { auto res = mUnavailablePhysicalCameras[in_cameraId].erase(in_physicalCameraId); EXPECT_EQ(res, 1); + } else { + auto res = mUnavailablePhysicalCameras[in_cameraId].emplace(in_physicalCameraId); + EXPECT_TRUE(res.second); } return ndk::ScopedAStatus::ok(); } @@ -368,6 +368,7 @@ class VtsAidlCameraServiceTargetTest : public ::testing::TestWithParam<std::stri ndk::ScopedAStatus ret = mCameraService->addListener(listener, &cameraStatuses); EXPECT_TRUE(ret.isOk()); + listener->initializeStatuses(cameraStatuses); for (const auto& it : cameraStatuses) { CameraMetadata rawMetadata; |