diff options
author | Mikhail Naganov <mnaganov@google.com> | 2024-02-21 22:00:40 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2024-02-21 22:00:40 +0000 |
commit | e1f30fedcc9aa39848b2a645fe1cca49d76a6dac (patch) | |
tree | 6459dd76261c44ff4895a6b0eabc2d5e527adad0 | |
parent | bfc2e73d49b408e1754a45c70d7583e055e132f5 (diff) | |
parent | 851e1a25bd2f2e54dc4bd6fa81a006a59e24c240 (diff) | |
download | av-e1f30fedcc9aa39848b2a645fe1cca49d76a6dac.tar.gz |
Merge "Volume Control: Modify Volume Level Range Values." into main
-rw-r--r-- | media/libeffects/lvm/wrapper/Aidl/BundleContext.cpp | 20 | ||||
-rw-r--r-- | media/libeffects/lvm/wrapper/Aidl/BundleContext.h | 4 | ||||
-rw-r--r-- | media/libeffects/lvm/wrapper/Aidl/BundleTypes.h | 3 |
3 files changed, 13 insertions, 14 deletions
diff --git a/media/libeffects/lvm/wrapper/Aidl/BundleContext.cpp b/media/libeffects/lvm/wrapper/Aidl/BundleContext.cpp index a9d0cc25ef..aa18deb4bb 100644 --- a/media/libeffects/lvm/wrapper/Aidl/BundleContext.cpp +++ b/media/libeffects/lvm/wrapper/Aidl/BundleContext.cpp @@ -284,15 +284,15 @@ RetCode BundleContext::limitLevel() { // roundoff int maxLevelRound = (int)(totalEnergyEstimation + 0.99); - if (maxLevelRound + mVolume > 0) { - gainCorrection = maxLevelRound + mVolume; + if (maxLevelRound + mVolumedB > 0) { + gainCorrection = maxLevelRound + mVolumedB; } - params.VC_EffectLevel = mVolume - gainCorrection; + params.VC_EffectLevel = mVolumedB - gainCorrection; if (params.VC_EffectLevel < -96) { params.VC_EffectLevel = -96; } - LOG(INFO) << "\tVol: " << mVolume << ", GainCorrection: " << gainCorrection + LOG(INFO) << "\tVol: " << mVolumedB << ", GainCorrection: " << gainCorrection << ", Actual vol: " << params.VC_EffectLevel; /* Activate the initial settings */ @@ -576,25 +576,25 @@ RetCode BundleContext::setBassBoostStrength(int strength) { RetCode BundleContext::setVolumeLevel(float level) { if (mMuteEnabled) { - mLevelSaved = level; + mLevelSaveddB = level; } else { - mVolume = level; + mVolumedB = level; } LOG(INFO) << __func__ << " success with level " << level; return limitLevel(); } float BundleContext::getVolumeLevel() const { - return (mMuteEnabled ? mLevelSaved : mVolume); + return (mMuteEnabled ? mLevelSaveddB : mVolumedB); } RetCode BundleContext::setVolumeMute(bool mute) { mMuteEnabled = mute; if (mMuteEnabled) { - mLevelSaved = mVolume; - mVolume = -96; + mLevelSaveddB = mVolumedB; + mVolumedB = -96; } else { - mVolume = mLevelSaved; + mVolumedB = mLevelSaveddB; } return limitLevel(); } diff --git a/media/libeffects/lvm/wrapper/Aidl/BundleContext.h b/media/libeffects/lvm/wrapper/Aidl/BundleContext.h index af46818c78..d823030083 100644 --- a/media/libeffects/lvm/wrapper/Aidl/BundleContext.h +++ b/media/libeffects/lvm/wrapper/Aidl/BundleContext.h @@ -124,8 +124,8 @@ class BundleContext final : public EffectContext { bool mVirtualizerTempDisabled = false; ::aidl::android::media::audio::common::AudioDeviceDescription mForceDevice; // Volume - float mLevelSaved = 0; /* for when mute is set, level must be saved */ - float mVolume = 0; + float mLevelSaveddB = 0; /* for when mute is set, level must be saved */ + float mVolumedB = 0; bool mMuteEnabled = false; /* Must store as mute = -96dB level */ RetCode initControlParameter(LVM_ControlParams_t& params) const; diff --git a/media/libeffects/lvm/wrapper/Aidl/BundleTypes.h b/media/libeffects/lvm/wrapper/Aidl/BundleTypes.h index 143329d386..daabdb7ff6 100644 --- a/media/libeffects/lvm/wrapper/Aidl/BundleTypes.h +++ b/media/libeffects/lvm/wrapper/Aidl/BundleTypes.h @@ -129,8 +129,7 @@ static const Descriptor kVirtualizerDesc = { .implementor = "NXP Software Ltd."}, .capability = kVirtualizerCap}; -static const std::vector<Range::VolumeRange> kVolumeRanges = { - MAKE_RANGE(Volume, levelDb, -9600, 0)}; +static const std::vector<Range::VolumeRange> kVolumeRanges = {MAKE_RANGE(Volume, levelDb, -96, 0)}; static const Capability kVolumeCap = {.range = kVolumeRanges}; static const std::string kVolumeEffectName = "Volume"; static const Descriptor kVolumeDesc = { |