summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
6 daysRename Preloading to SpeculativeLoading in WebViewupstream-masterelabadysayed
To avoid using the term preloading as it's overloaded and rename it to SpeculativeLoading instead. Bug: 340826097 Change-Id: If9d92e3a1998d4bd02497a223c64d5aa47ee44f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546125 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Sayed Elabady <elabadysayed@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1303746} NOKEYCHECK=True GitOrigin-RevId: b0dbd9fdd227827c78b537ab22d0c5699cbdaa0a
11 daysAdd support lib boundary for enabling preloadingelabadysayed
Bug: 340826097 Change-Id: I712af4add25c9254b85ec0c4fb41baec506ad91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541904 Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Commit-Queue: Sayed Elabady <elabadysayed@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1302032} NOKEYCHECK=True GitOrigin-RevId: 0c67896ebb0b9d2ace4d2a0b2c4d153512bb05e5
11 daysUpdate boundary interface min-sdk to 21Peter Birk Pakkenberg
AndroidX has recently moved their minsdk version to 21, which means that we can now drop support for older SDK versions and move the lint version to 21 for the Chromium sources that are copied there. Bug: 299240961 Change-Id: I327947a707a09a72b144964da50b882bf0d1bf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5537924 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1301810} NOKEYCHECK=True GitOrigin-RevId: ffc416c1d6119021d6fc74a75ec523a3a222cd12
2024-03-27Code inclusion: replace non-inclusive termNate Fischer
This swaps a non-inclusive term with the recommendation from the Google documentation style guide: https://developers.google.com/style/inclusive-documentation This changes everything that I think is safe to change. I'm intentionally leaving the trace tag names because I'm not sure if it's important to keep the names consistent. Fixed: 40153772 Test: N/A Change-Id: I38a9013dda2485070cfa8452c5fc55a3250430cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403603 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Adam Walls <avvall@chromium.org> Commit-Queue: Adam Walls <avvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1279426} NOKEYCHECK=True GitOrigin-RevId: f9f2683545904deb8833948cace582a83fee4e3d
2024-03-07Reland "[WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport"Adem Derinel
With the reland of crrev.com/c/5327926, this should be reland to safe. No changes wrt the original CL. This is a reland of commit 991e4f9f43589d8451c10475ba39f4054076d560 Original change's description: > [WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport > > The support is per WebView. Hence, we cache the support per WebContents. > When the WebContents of a WebView change, we update the cache. > > Test method: > 1 - androidx does not have the API yet. Thus, I modified the > WebSettingsCompat.setAlgorithmicDarkeningAllowed to call the new > setWebAuthnSupport API. Then I used the API in the test app. > 2 - Used the custom GMSCore which includes the ResultReceiver changes. > > Demo: https://photos.app.goo.gl/bsrJtCuAMM2Ee9Je8 > In the demo you see two WebViews within a single app. The first has > WebAuthn disabled; the second is in app mode. > > Bug: b/41483780, b/316886235 > Change-Id: If3eae1634044cc117dac435d8bd823194cb47e5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273159 > Reviewed-by: Richard (Torne) Coles <torne@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Adem Derinel <derinel@google.com> > Cr-Commit-Position: refs/heads/main@{#1265745} Bug: b/41483780, b/316886235 Change-Id: I95de7a1e05e38f15021b73d062abb8504f60fc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5349152 Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1269507} NOKEYCHECK=True GitOrigin-RevId: 916b2555fb5e060d9e53f472c655ea748b713b9d
2024-02-27Revert "[WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport"Alexander Timin
This reverts commit 991e4f9f43589d8451c10475ba39f4054076d560. Reason for revert: Compile failures on Chrome builds: b/327157513 Original change's description: > [WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport > > The support is per WebView. Hence, we cache the support per WebContents. > When the WebContents of a WebView change, we update the cache. > > Test method: > 1 - androidx does not have the API yet. Thus, I modified the > WebSettingsCompat.setAlgorithmicDarkeningAllowed to call the new > setWebAuthnSupport API. Then I used the API in the test app. > 2 - Used the custom GMSCore which includes the ResultReceiver changes. > > Demo: https://photos.app.goo.gl/bsrJtCuAMM2Ee9Je8 > In the demo you see two WebViews within a single app. The first has > WebAuthn disabled; the second is in app mode. > > Bug: b/41483780, b/316886235 > Change-Id: If3eae1634044cc117dac435d8bd823194cb47e5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273159 > Reviewed-by: Richard (Torne) Coles <torne@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Adem Derinel <derinel@google.com> > Cr-Commit-Position: refs/heads/main@{#1265745} Bug: b/41483780, b/316886235 Change-Id: If6aef3c7e5dac2be938f4a0384e4dc8746abdb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5327387 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Adem Derinel <derinel@google.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Owners-Override: Alexander Timin <altimin@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1265805} NOKEYCHECK=True GitOrigin-RevId: 6fcacd41f9ec85ec6c74760646d41e51c4ccafd5
2024-02-27[WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupportAdem Derinel
The support is per WebView. Hence, we cache the support per WebContents. When the WebContents of a WebView change, we update the cache. Test method: 1 - androidx does not have the API yet. Thus, I modified the WebSettingsCompat.setAlgorithmicDarkeningAllowed to call the new setWebAuthnSupport API. Then I used the API in the test app. 2 - Used the custom GMSCore which includes the ResultReceiver changes. Demo: https://photos.app.goo.gl/bsrJtCuAMM2Ee9Je8 In the demo you see two WebViews within a single app. The first has WebAuthn disabled; the second is in app mode. Bug: b/41483780, b/316886235 Change-Id: If3eae1634044cc117dac435d8bd823194cb47e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273159 Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1265745} NOKEYCHECK=True GitOrigin-RevId: 991e4f9f43589d8451c10475ba39f4054076d560
2024-02-13Implement setAudioMuted and isAudioMuted AndroidX APIsAashna
Allow developer to get/set whether web contents should be muted. This is the chromium implementation for corresponding AndroidX APIs. Bug: 325071689 Change-Id: I259eba394e7c68233823c415f681c7c9ced0233b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5291076 Commit-Queue: Aashna Jena <aashnajena@google.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@google.com> Cr-Commit-Position: refs/heads/main@{#1260014} NOKEYCHECK=True GitOrigin-RevId: 6509247528531add165b7220518a500a7cfdaa55
2023-11-23LSC: Reformat //android_webview/**/*.java with google-java-formatAndrew Grieve
See: https://docs.google.com/document/d/1XKHDXIlUP4p9tWQQnImCPhoKbXEgX-otdwEjX8G6SpQ/edit Bug: 1491626 Change-Id: Ibd73ebd59d8964fe97b48cd022072eb77c68d036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054958 Reviewed-by: Peter Wen <wnwen@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#1228561} NOKEYCHECK=True GitOrigin-RevId: feff2176e905c3a859893fd7922f1cca496f1baa
2023-11-14Add support for get/set WebView Media Integrity API config AndroidX APIAashna
Plumbing for following AndroidX APIs: - getWebViewMediaIntegrityApiStatus - setWebViewMediaIntegrityApiStatus Perform explicit conversion between boundary interface status types and internal config status types in case both accidentally diverge at some point. Design Doc: go/wv-pia-design-androidx Bug: b/301393651 Change-Id: I01bbfde44ea308d13c951750c15363cd99ce5390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002172 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Aashna Jena <aashnajena@google.com> Auto-Submit: Aashna Jena <aashnajena@google.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1224423} NOKEYCHECK=True GitOrigin-RevId: ab8cc3d83dcf4df23f2b81a4d38112ca0dc42ba3
2023-09-29[AW][multi-profile] Remove DEV_SUFFIX from MULTI_PROFILE featureSayed
Remove the dev suffix to prepare for the AndroidX release. Fixed: 1467232 Change-Id: I359fa4644a11b63be3408e89e15b4ae4529929a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4895669 Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Auto-Submit: Sayed Elabady <elabadysayed@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1203119} NOKEYCHECK=True GitOrigin-RevId: 7fcb89be1f9276f474617531743ae5f19e6e063d
2023-09-26Add support lib binding for attribution configurationPeter Birk Pakkenberg
Bug: 1473966 Change-Id: Iaec11296be12c47438123037d7edb9e51c6269a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4894425 Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1201615} NOKEYCHECK=True GitOrigin-RevId: d9507a6332ac3629f3c7feba4380bfe75e6af98d
2023-09-21[AW][multi-profile] Add BoundaryInterface for setProfile and getProfileSayed
This CL adds the chromium side work for setProfile and getProfile, there will be another CL for AndroidX side. Bug: 1467232 Change-Id: I1070de4130466b659ea843e1ca91e07f5c2fad3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4765551 Commit-Queue: Sayed Elabady <elabadysayed@chromium.org> Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1199499} NOKEYCHECK=True GitOrigin-RevId: 54d127d7c9d9e1e6a069bd401fd7f39c14998a24
2023-09-13Android: Mark kitkat as unsupported in our build systemAndrew Grieve
Cronet no longer requires kitkat support, so we should be able to remove kitkat-specific things (e.g. legacy multidex). Bug: 1471145 Change-Id: Ib1caf8a22870db4dd775999fa9bee38f3d9a7da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4822585 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1196200} NOKEYCHECK=True GitOrigin-RevId: 6286cc03985e9b99978f614b85bb8f0cf76526f6
2023-09-08[AW][multi-profile] Add BoundaryInterface for Profile and ProfileStoreSayed
The feature is still in DEV mode hence the suffix in the feature name. Bug: 1467232 Change-Id: I0fbb978bf86aaf74bcd8cf589d5570f77d3e796e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712113 Auto-Submit: Sayed Elabady <elabadysayed@chromium.org> Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Sayed Elabady <elabadysayed@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194097} NOKEYCHECK=True GitOrigin-RevId: 263c7c39d200153f3f76dc5cc97a2550aceb4745
2023-08-28[WebView] Implement support library glue for user-agent metadataVictor Tan
Add boundary interface and support lib glue for set/get user-agent metadata. Change-Id: Ib9be1db7cc4555efecb933892cf273c4bf4955e6 Bug: b/294183509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783052 Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Victor Tan <victortan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188979} NOKEYCHECK=True GitOrigin-RevId: def88fdaad0a1dd89b932b366543a72459b285d9
2023-06-16[WebView] Remove content relationship verification codeSusanne Westphal
Bug: 1454473 Change-Id: Ib25c2114f9b92e6160db86498f520f9276f46ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608053 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Susanne Westphal <swestphal@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1158928} NOKEYCHECK=True GitOrigin-RevId: 334d01268df246e959b238956ab956413562edfb
2023-05-31[WebView] Unhide WEB_MESSAGE_ARRAY_BUFFERRichard He
And deprecate `WEB_MESSAGE_GET_MESSAGE_PAYLOAD` which is renamed. Bug: 1023334 Bug: 1374142 Change-Id: I7bdae3d588cd7e301188ad3829b42b93e6042520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568044 Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Richard He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1151190} NOKEYCHECK=True GitOrigin-RevId: 918e0720f49be5db1cb5938c0bdd9c51356fc42c
2023-05-19[WebView] Remove setSupportLibraryVersion()-codeSusanne Westphal
This code was added for an AndroidX-API that has never been submitted (r.android.com/1138298). Removing this code again as we do not intend to add this any more. Change-Id: I408d4988cc53358a1d79384174b0d99fcbf8635c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545100 Commit-Queue: Susanne Westphal <swestphal@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1146426} NOKEYCHECK=True GitOrigin-RevId: e89c34aea7bc9b05e023e4d640175daa5bdbdc9a
2023-04-19Remove deprecation from still-used methodPeter Birk Pakkenberg
Bug: 1374142 Change-Id: Ib3ceb27d9278ce8d6acb10ed4f49cf4b43ca1c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4446359 Auto-Submit: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Susanne Westphal <swestphal@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1132408} NOKEYCHECK=True GitOrigin-RevId: e8e7b29f7cdfa7238c127d43b3a0fbf9ba24eaff
2023-04-19[WebView] Temporarily remove WebMessage feature annotationRichard He
The feature 'WEB_MESSAGE_GET_MESSAGE_PAYLOAD' was renamed, but still referenced in AndroidX. Temporarily remove 'deprecated' annotation to make AndroidX build success. The feature flag will be removed later. Bug: 1374142 Change-Id: I06c24642e47e5b848129ef2c97a5115838ecb948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4444367 Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Auto-Submit: Richard He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1132372} NOKEYCHECK=True GitOrigin-RevId: f75b7d968174b675ceedae862878525a94d1d48d
2023-04-17[WebView] Temporarily add WebMessage feature backRichard He
The feature 'WEB_MESSAGE_GET_MESSAGE_PAYLOAD' was renamed, but still referenced in AndroidX. Adding it back to make sure AndroidX build success. Will remove once it's done. Bug: 1374142 Change-Id: I443c6c3ed6879bb6b5620d3167e9a5eb665b0fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430139 Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Richard He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1131635} NOKEYCHECK=True GitOrigin-RevId: e07294a791d84c4446bc9a2735b1f6a8cc2777b0
2023-04-14Wire up WebMessageListener ArrayBuffer support with AndroidX boundaryRichard He
This CL wire up newly added ArrayBuffer type support of WebMessageListener to AndroidX boundary. All changes are still behind feature flags: `WEB_MESSAGE_GET_MESSAGE_PAYLOAD` and `kArrayBufferJsToBrowser` in native. - Rename feature flag to indicate ArrayBuffer type. The flag is not used in prod (behind DEV suffix). - WebView->AndroidX: Post ArrayBuffer when AndroidX supports the new flag. (Right now JS -> Java ArrayBuffer is behind feature flag). - AndroidX->WebView: Add new 'postMessageWithPayload' method to 'JsReplyProxy', the existing one only accepts string. Same changes in AndroidX are required later. Test: Build and install WebView on userdbg pixel, run AndroidX webkit tests. ArrayBuffer tests will be added in AndroidX when feature is ready. Bug: 1374142 Change-Id: I3dbcd714cddc0efb0c1619019f26d2c82d2aa73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4297714 Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Richard He <linyhe@microsoft.com> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1130770} NOKEYCHECK=True GitOrigin-RevId: 8dd9b603fc60984977ceadf78475da8c6889043e
2023-01-31Add constants related to directory base path to boundary interface.Abhijith Nair
Adds DATA_DIRECTORY_BASE_PATH and CACHE_DIRECTORY_BASE_PATH which is required for adding support for setDirectoryBasePath(String, String) API method in ProcessGlobalConfig. Bug: 1355297 Change-Id: I3a6c5ccd1a49d8c9d5bf74227c26505695af8f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198135 Auto-Submit: Abhijith Nair <abhijithnair@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1099431} NOKEYCHECK=True GitOrigin-RevId: 2640c7a52921df39e67b272003a32fefbe154d99
2023-01-26[WebView][DAL] Add boundary interface and support lib glue for ↵Susanne Westphal
experimentally restricted content. Bug: 1376958 Change-Id: I326853634f8ccabd85807489c4b18bead3241c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3967865 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Susanne Westphal <swestphal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097552} NOKEYCHECK=True GitOrigin-RevId: 30a0b23eed7644322b01455068c3b25c8fe3aba9
2022-10-18Expose image drag drop implementation in glue code for AndroidxSayed Elabady
For now the feature will be for dev only, there will be another CL for enabling it to enable it for prod. Bug: 1353048 Change-Id: I5b113beee97b669aa51261a77acbdb3542f244f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3941675 Reviewed-by: Susanne Westphal <swestphal@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1060417} NOKEYCHECK=True GitOrigin-RevId: aaddc5dab7285d86d998b8dc4a9344c2a423f58c
2022-09-28[aw] Remove unused boundary interface methodsPeter Birk Pakkenberg
These methods were never unhidden, and are no longer in use by the androidx.webkit library. The feature constant that guarded their use has also been removed from the array of supported features. Bug: 1295213 Change-Id: If4deabc81bda0a6d244832be21163edfbe79a8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921798 Reviewed-by: Richard Coles <torne@chromium.org> Auto-Submit: Peter Pakkenberg <pbirk@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1052655} NOKEYCHECK=True GitOrigin-RevId: 39e913ff59281b26f0b49b94a6eec19f3900706d
2022-09-22[aw] Add allowlist for X-Requested-With headerPeter Birk Pakkenberg
This CL reuses the origin matching originally developed for components/js_injection, and moves the computation of the default header mode to native code. The CL adds new API methods, and replaces the original API with stubs, to be removed once the AndroidX library has been updated to use the new methods. Bug: 1295213 Change-Id: Ic96d85d1e159a86461af5b63cac6d87c0ff6497e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822948 Reviewed-by: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1050218} NOKEYCHECK=True GitOrigin-RevId: 020b57aa6fe80bb66a38cc132a0bbd7afeb26359
2022-09-08Update copyright headers in android_webview/ 3/3Avi Drissman
The methodology used is documented in https://crbug.com/1098010#c34. An earlier version of this CL, https://crrev.com/c/3879643, was reverted due to an issue that was resolved with https://crrev.com/c/3881211. No-Try: true Bug: 1098010 Change-Id: Iaea33536d02a9ea5b57eec31d61353fd1e6a4ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3883861 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1044742} NOKEYCHECK=True GitOrigin-RevId: 4a6ec7ef6b441998004d3938645ddb52b5752c2c
2022-09-08Update the copyright headers in the Proguard flags filesAvi Drissman
The Proguard flags files are self-referencing, so update their copyright headers in sync. (There are only five files in /third_party/androidx so update the other three files as well while we're here.) Bug: 1098010 Change-Id: Ia014b5d559cdfc916117c2f70fae7269471740a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3881211 Owners-Override: Avi Drissman <avi@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1044569} NOKEYCHECK=True GitOrigin-RevId: 3f1ea440df93a4b2bda825e033f733bba25b2f80
2022-09-07Revert "Update copyright headers in android_webview/ 3/3"Daniel Cheng
This reverts commit 981595d747e2272e420a5892aaa06498529f9127. Reason for revert: Broke the android-binary-size trybot. Example failure: https://ci.chromium.org/ui/p/chromium/builders/try/android-binary-size/1225625/overview Original change's description: > Update copyright headers in android_webview/ 3/3 > > The methodology used is documented in https://crbug.com/1098010#c15. > > No-Try: true > Bug: 1098010 > Change-Id: I2a7243a21102d9ff2886e7ecb3f664fd1acbc486 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3879643 > Commit-Queue: Avi Drissman <avi@chromium.org> > Owners-Override: Avi Drissman <avi@chromium.org> > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1044093} Bug: 1098010 Change-Id: Ide24e688f02c133cf26f6d7bf4916e188de724c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3880948 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1044212} NOKEYCHECK=True GitOrigin-RevId: 2dfc20ba1cf2d082d5104f675239407a2321cde2
2022-09-07Update copyright headers in android_webview/ 3/3Avi Drissman
The methodology used is documented in https://crbug.com/1098010#c15. No-Try: true Bug: 1098010 Change-Id: I2a7243a21102d9ff2886e7ecb3f664fd1acbc486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3879643 Commit-Queue: Avi Drissman <avi@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1044093} NOKEYCHECK=True GitOrigin-RevId: 981595d747e2272e420a5892aaa06498529f9127
2022-08-26[WebView] Adopt ArrayBuffer WebMessage in boundary interfaceRichard He
Support to receive ArrayBuffer from AndroidX. Design doc: https://docs.google.com/document/d/1nsQnwwY43OuA4PsSaMioiKA0c_M1eV1XX2q15YFA7cI/edit?usp=sharing Bug: 1023334 Change-Id: I63766886b38b0c0fd92d6c1f74eb79457131e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826702 Reviewed-by: Susanne Westphal <swestphal@chromium.org> Commit-Queue: Linyue He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1040052} NOKEYCHECK=True GitOrigin-RevId: 57554690aecbb3d2a9748c3d077d71effa730675
2022-08-22Add ProcessGlobalConfigConstants to boundary interface.Abhijith Nair
This allows code in AndroidX and chromium to refer to the same constants. Bug: 1355297 Change-Id: I68452d526a8a98907803a1c23df87ef262beba8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840394 Commit-Queue: Abhijith Nair <abhijithnair@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1037773} NOKEYCHECK=True GitOrigin-RevId: 87bbb96c25af9813055cf94944510222427c5883
2022-08-11Expose AwCookieManager#getCookieInfo in glue code for AndroidX.Alex Mitra
Bug: 1345878 Change-Id: I55306d6c1abfa5b19b14a53ade5344f2af2dea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822909 Commit-Queue: Alex Mitra <alexmitra@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1033934} NOKEYCHECK=True GitOrigin-RevId: 240795fd5bbbcd4510098bdee678c1b47e14d53e
2022-06-23Expose EnterpriseAuthenticationAppLinkPolicy APIsAyush Sharma
Bug: b/201408457 Change-Id: I956f453fbc0b4adcaf33341542c4cc1b05ec1abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3709074 Reviewed-by: Susanne Westphal <swestphal@chromium.org> Commit-Queue: Ayush Sharma <ayushsha@google.com> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1017362} NOKEYCHECK=True GitOrigin-RevId: 99a8092d711a98cb7afa41e9c8d06398a1ff72f6
2022-04-28Reland "Replace String with WebMessagePayload for AndroidX WebMessage API"Richard He
This is a reland of commit bc7514a7cf7b67ffc3fb0698310a23246df5a7c5 - Keep WebContents#postMessageToMainFrame(String, ...), it's used by downstream. Original change's description: > Replace String with WebMessagePayload for AndroidX WebMessage API > > Design doc: https://docs.google.com/document/d/1nsQnwwY43OuA4PsSaMioiKA0c_M1eV1XX2q15YFA7cI/edit?usp=sharing > > This CL did not add new features. > - Add a new boundary type WebMessagePayload to replace String > WebMessage.getData(). > - Add new data class MessagePayload in content/, and replace existing > PostMessage API with the new type. > - A followup change will add ArrayBuffer support in > WebViewCompat.postMessageToMainFrame and > WebChannelCompat.postMessage. > > How to test: run tests in existing AndroidX Webkit. > > Bug: 1023334 > Change-Id: Ib5b35b974bee597a6efada75503c5288f7058c50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3583520 > Reviewed-by: Bo Liu <boliu@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Linyue He <linyhe@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#995852} Bug: 1023334 Change-Id: I9e2fa991d04e575add848d908a5d097a35a990b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607795 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Linyue He <linyhe@microsoft.com> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/main@{#997137} NOKEYCHECK=True GitOrigin-RevId: 173c29edc14315e542c0c497d0d5bee5c718a289
2022-04-26Revert "Replace String with WebMessagePayload for AndroidX WebMessage API"Zhiyuan Cai
This reverts commit bc7514a7cf7b67ffc3fb0698310a23246df5a7c5. Reason for revert: Fail the downstream builds Original change's description: > Replace String with WebMessagePayload for AndroidX WebMessage API > > Design doc: https://docs.google.com/document/d/1nsQnwwY43OuA4PsSaMioiKA0c_M1eV1XX2q15YFA7cI/edit?usp=sharing > > This CL did not add new features. > - Add a new boundary type WebMessagePayload to replace String > WebMessage.getData(). > - Add new data class MessagePayload in content/, and replace existing > PostMessage API with the new type. > - A followup change will add ArrayBuffer support in > WebViewCompat.postMessageToMainFrame and > WebChannelCompat.postMessage. > > How to test: run tests in existing AndroidX Webkit. > > Bug: 1023334 > Change-Id: Ib5b35b974bee597a6efada75503c5288f7058c50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3583520 > Reviewed-by: Bo Liu <boliu@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Linyue He <linyhe@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#995852} Bug: 1023334, 1319735 Change-Id: If4f6e38f8392ad4135cd76f6391abe6c248194bd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607489 Auto-Submit: Zhiyuan Cai <zhiyuancai@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#996032} NOKEYCHECK=True GitOrigin-RevId: dc0c4bc3ac5be6c530ddf43d1a9f3621ad76a845
2022-04-25Replace String with WebMessagePayload for AndroidX WebMessage APIRichard He
Design doc: https://docs.google.com/document/d/1nsQnwwY43OuA4PsSaMioiKA0c_M1eV1XX2q15YFA7cI/edit?usp=sharing This CL did not add new features. - Add a new boundary type WebMessagePayload to replace String WebMessage.getData(). - Add new data class MessagePayload in content/, and replace existing PostMessage API with the new type. - A followup change will add ArrayBuffer support in WebViewCompat.postMessageToMainFrame and WebChannelCompat.postMessage. How to test: run tests in existing AndroidX Webkit. Bug: 1023334 Change-Id: Ib5b35b974bee597a6efada75503c5288f7058c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3583520 Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Commit-Queue: Linyue He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/main@{#995852} NOKEYCHECK=True GitOrigin-RevId: bc7514a7cf7b67ffc3fb0698310a23246df5a7c5
2022-03-07Aw: Add AlgorithmicDarkening featureMichael Bai
Bug: 1287883 Change-Id: I706364fa7b1904f9494ba74e63b3633bee365435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3502826 Auto-Submit: Michael Bai <michaelbai@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#978409} NOKEYCHECK=True GitOrigin-RevId: 743ef0db0f2599792739e0336c0cbf6d92fb6ad8
2022-03-02Aw: Add AlgorithmicDarkeningAllowed to boundary interfaceMichael Bai
Bug: 1287883 Change-Id: I59f9316007cd4b43c85e9ad5f454819bc67e84d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498326 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/main@{#976839} NOKEYCHECK=True GitOrigin-RevId: a3f419cb3268f372f2f366d9c03c5d88ad660e99
2022-02-25[WebView] Move getVariationsHeader to staticsClark DuVall
This makes more sense since it doesn't depend on the WebView instance. Bug: 977027 Change-Id: I113f338797c2d28d6500fa19ad885be31eb07b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3491323 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#975346} NOKEYCHECK=True GitOrigin-RevId: 6f1a4ac82e64fb9643d5b7a07ea0629221a582a9
2022-02-24Add WebView API to retrieve variations headerClark DuVall
This adds an API to retrieve the variations header from WebView. This can be used by WebView apps to send variations headers if they want to. Bug: 977027 Change-Id: I892d7180a6c1163345e8705ea7bd862218cae1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3482666 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#974886} NOKEYCHECK=True GitOrigin-RevId: beed0ae31cd51a3069175083dc55813428374134
2022-02-24[JJI] Cleanup ScriptReferenceBoundaryInterfaceShimi Zhang
There are actually other breaking changes in the boundary interfaces directory from https://chromium-review.googlesource.com/c/chromium/src/+/3368924, will address them separately before I roll the boundary interface to AndroidX. Bug: 918065 Test: 1. Compile and install WebView or use a default WebView. Test: 2. Copy the change from Chromium to AndroidX Test: 3. run ./gradlew :webkit:webkit:connectedAndroidTest Test: 4. expecting no failures for both new/old version of WebView. Change-Id: I0c56e7b45fe73aac68c70d952260388355c93280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3485436 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/main@{#974884} NOKEYCHECK=True GitOrigin-RevId: 7d03027d415dd3c4248d4a3a140923f75531f560
2022-02-18Expose XRequestedWith api in glue code for AndroidXPeter Birk Pakkenberg
This commit does not expose the CONSTANT_WEBVIEW enum value, as it is intended as a fallback for rollout testing, and is not at this point intended for developer usage. Bug: 1295213 Change-Id: Ia6af00ead6eb5f97e90e9eae61954002f6f4754a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468347 Auto-Submit: Peter Pakkenberg <pbirk@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#972998} NOKEYCHECK=True GitOrigin-RevId: e25438c20b4669530580c3e0c311e60e9d5e506c
2022-01-13android_webview: add no-op boundary interfaces.Adam Langley
This change adds WebView boundary interfaces for supporting WebAuthn in WebViews. They are currently no-ops, but the full change is huge so I'm trying to split it up. BUG=1284805 Change-Id: I8ce75d7077e9db7d15c071e27cf9529a4b94d2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3368924 Reviewed-by: Richard Coles <torne@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/main@{#958718} NOKEYCHECK=True GitOrigin-RevId: aa5dd97385dcf06a2d517a48207f11c29f03e863
2021-03-17[JJI] Rename ScriptReference to ScriptHandlerShimi Zhang
Per discussion from http://aosp/1635279, we rename the class name to ScriptHandler. We also drop the DOCUMENT_START_SCRIPT feature string's ":1" suffix in this change. Bug: 2761958 Test: the current tests should pass. Change-Id: Ibeb413abc44e161132823fe99c1f462f45239414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2765934 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#863942} GitOrigin-RevId: 0794d233678d9a01c19b6446f7d26760e2290a11
2021-02-12[Build] Switch androidx dependencies to use //third_party/androidxPeter Kotwicz
This CL switches depenendencies on the //third_party/android_deps:androidx alias to refer to //third_party/androidx instead. This CL was generated via: find . -name *.gn -exec sed -i 's/android_deps:androidx/androidx:androidx/g' {} + BUG=1064277 Change-Id: I3238cd487298ef733939ade5edf5898dd374c5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2693055 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#853751} GitOrigin-RevId: 0409372615dde3d990738a730b6f784d695bf678
2021-01-11[aw] Add reverse_bypass option for proxy overrideLaís Minchillo
Add a setProxyOverride method that takes in a boolean for reverse_bypass. This will be exposed via androidx.webkit APIs. Add a new test in proxy_config_service_android_unittest and in AwProxyControllerTest to test the newly added reverse_bypass option. Bug: 1162255 Test: run_net_unittests -f *ProxyConfigServiceAndroidTest* Test: run_webview_instrumentation_test_apk -f *AwProxyControllerTest* Change-Id: Icc82656809b9237d6a8defb125b57727d59777ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544645 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#842086} GitOrigin-RevId: be96ccdfef15c94651102992fd304ea9712918bf
2020-08-17Android: Use per-target lint-suppressions.xmlPeter Wen
Previously all lint targets shared one lint suppressions/config file: //build/android/lint/suppressions.xml This resulted in many unnecessary suppressions being added which then suppress the lint checks for every lint target. e.g. if monochrome fails ObsoleteSdkInt checks, suppressing it globally turns off the checks for all other apks, which decreases the utility of android lint for all those other apks. This CL removes the shared suppressions.xml file and splits its content between the targets that actually need them, and adds lint-baseline.xml files where necessary. This also removes the bottleneck of requiring a //build/android/OWNERS to stamp every lint suppression change. This CL also adds suppressions for targets depending on code that chrome already lints via monochrome. E.g. errors in //base are shared by all embedders' lint targets, and it should not become the burden of targets like cast shell or cronet to fix. Thus these errors are suppressed in cronet/cast/remoting-specific suppressions.xml files. This CL changes lint to run in the output directory so that baseline suppressions work for generated files (e.g. AndroidManifest.xml). Bug: 1113795,1115594 Fixes: 1115594 Change-Id: I2d70128707c0fa862c109b6f91631a07916c90d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346857 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798776} GitOrigin-RevId: f74622e693e698c40edd15ca0bc7b75b080f5509