diff options
author | Alexander Timin <altimin@chromium.org> | 2024-02-27 15:33:37 +0000 |
---|---|---|
committer | Copybara-Service <copybara-worker@google.com> | 2024-02-27 07:38:47 -0800 |
commit | 162718bca7c7f47ca30b0684bbd0a6ffb3c6fdd4 (patch) | |
tree | 442c3121192ce4cf8353be952c74d0ca818b8052 | |
parent | b574e1a1ae360350bde138b282e828d404e21ea5 (diff) | |
download | webview_support_interfaces-162718bca7c7f47ca30b0684bbd0a6ffb3c6fdd4.tar.gz |
Revert "[WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport"
This reverts commit 991e4f9f43589d8451c10475ba39f4054076d560.
Reason for revert: Compile failures on Chrome builds: b/327157513
Original change's description:
> [WebView][WebAuthn] Introduce WebSettings.setWebAuthnSupport
>
> The support is per WebView. Hence, we cache the support per WebContents.
> When the WebContents of a WebView change, we update the cache.
>
> Test method:
> 1 - androidx does not have the API yet. Thus, I modified the
> WebSettingsCompat.setAlgorithmicDarkeningAllowed to call the new
> setWebAuthnSupport API. Then I used the API in the test app.
> 2 - Used the custom GMSCore which includes the ResultReceiver changes.
>
> Demo: https://photos.app.goo.gl/bsrJtCuAMM2Ee9Je8
> In the demo you see two WebViews within a single app. The first has
> WebAuthn disabled; the second is in app mode.
>
> Bug: b/41483780, b/316886235
> Change-Id: If3eae1634044cc117dac435d8bd823194cb47e5a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273159
> Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Commit-Queue: Adem Derinel <derinel@google.com>
> Cr-Commit-Position: refs/heads/main@{#1265745}
Bug: b/41483780, b/316886235
Change-Id: If6aef3c7e5dac2be938f4a0384e4dc8746abdb74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5327387
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Adem Derinel <derinel@google.com>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Auto-Submit: Alexander Timin <altimin@chromium.org>
Owners-Override: Alexander Timin <altimin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1265805}
NOKEYCHECK=True
GitOrigin-RevId: 6fcacd41f9ec85ec6c74760646d41e51c4ccafd5
-rw-r--r-- | src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java b/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java index f3a27ce..4c85262 100644 --- a/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java +++ b/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java @@ -55,16 +55,16 @@ public interface WebSettingsBoundaryInterface { int getForceDarkBehavior(); @Retention(RetentionPolicy.SOURCE) - @interface WebauthnSupport { + @interface WebAuthnSupport { int NONE = 0; int APP = 1; int BROWSER = 2; } - void setWebauthnSupport(@WebauthnSupport int support); + void setWebAuthnSupport(@WebAuthnSupport int support); - @WebauthnSupport - int getWebauthnSupport(); + @WebAuthnSupport + int getWebAuthnSupport(); void setRequestedWithHeaderOriginAllowList(Set<String> allowedOriginRules); |