aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPete Bentley <prb@google.com>2023-04-20 14:06:45 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2023-04-20 14:06:45 +0000
commit58b8245491798ec5b66f4445e4742fb66c970ff5 (patch)
treebf1239f221f4c8aab5d33153d9dcff6f142ba90f
parent69ffbbd990dd8e222ad52efe22070b1e1d383881 (diff)
parent6386bb283263351bddd6e4541ab3d1955d0705e2 (diff)
downloadvogar-58b8245491798ec5b66f4445e4742fb66c970ff5.tar.gz
Add better diagnostics for missing Java files. am: dea851f1ec am: 71457422ec am: e9060b64f6 am: 6386bb2832
Original change: https://android-review.googlesource.com/c/platform/external/vogar/+/2546371 Change-Id: Ibd0f83cf93a04af6952800d46a27e0bb03d77087 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--src/vogar/tasks/BuildActionTask.java10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/vogar/tasks/BuildActionTask.java b/src/vogar/tasks/BuildActionTask.java
index fd4c43a..04605fd 100644
--- a/src/vogar/tasks/BuildActionTask.java
+++ b/src/vogar/tasks/BuildActionTask.java
@@ -17,6 +17,7 @@
package vogar.tasks;
import java.io.File;
+import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.OutputStream;
@@ -90,7 +91,14 @@ public final class BuildActionTask extends Task {
if (run.debugging) {
javac.debug();
}
- if (javaFile != null) {
+ if (javaFile == null) {
+ if (JAVA_SOURCE_PATTERN.matcher(action.getTargetClass()).find()) {
+ // This is likely a missing source file rather than a class
+ // named something.java....
+ throw new FileNotFoundException("Unlikely classname, assuming missing source file: "
+ + action.getTargetClass());
+ }
+ } else {
if (!JAVA_SOURCE_PATTERN.matcher(javaFile.toString()).find()) {
throw new CommandFailedException(Collections.<String>emptyList(),
Collections.singletonList("Cannot compile: " + javaFile));