diff options
| author | Gert Wollny <gert.wollny@collabora.com> | 2022-11-08 14:11:12 +0100 |
|---|---|---|
| committer | Marge Bot <emma+marge@anholt.net> | 2022-11-10 07:03:02 +0000 |
| commit | 10e2e2d4e4a2037fe5750c72ce3bf3cb948c3578 (patch) | |
| tree | 1e4adf8b0ee633f085718a946e8d2d7627164bff | |
| parent | 036b354951bdbc1a47a90959ca07511438f72ffe (diff) | |
| download | virglrenderer-10e2e2d4e4a2037fe5750c72ce3bf3cb948c3578.tar.gz | |
shader: Fix off-by-one comparison when adding shader inputs
Fixes Coverity ID: 1527218 "Out-of-bounds write"
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/975>
| -rw-r--r-- | src/vrend_shader.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vrend_shader.c b/src/vrend_shader.c index 6ec3d9cb..7bf15eb7 100644 --- a/src/vrend_shader.c +++ b/src/vrend_shader.c @@ -1347,7 +1347,7 @@ iter_declaration(struct tgsi_iterate_context *iter, if (ctx->front_face_emitted == false) { int k = ctx->num_inputs++; - if (ctx->num_inputs > ARRAY_SIZE(ctx->inputs)) { + if (ctx->num_inputs >= ARRAY_SIZE(ctx->inputs)) { vrend_printf( "Number of inputs exceeded, max is %lu\n", ARRAY_SIZE(ctx->inputs)); return false; } |