diff options
| author | Gert Wollny <gert.wollny@collabora.com> | 2022-11-08 17:24:50 +0100 |
|---|---|---|
| committer | Marge Bot <emma+marge@anholt.net> | 2022-11-10 07:03:02 +0000 |
| commit | 13504a33514366979baaa28feb8cc66a5edbf0b0 (patch) | |
| tree | 9ec57dd45928348eadf52288ddd9e8815dbb0de1 | |
| parent | 1e5f4e0feb9caf214f5b83929f75a8aea98de41a (diff) | |
| download | virglrenderer-13504a33514366979baaa28feb8cc66a5edbf0b0.tar.gz | |
vkr: don't return pointer as bool
Fixes Coverity ID: 1527226 "Dereference before null check"
Since returning the pointer tests whether "arr" is NULL, coverity
assumes that this value can actually be NULL, and points out the error
above. However, rr must be non-NULL, because it is de-referenced, so
returning "true" shows the intent better and quells this issue.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/975>
| -rw-r--r-- | src/venus/vkr_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/venus/vkr_common.c b/src/venus/vkr_common.c index 9f66b68a..9e81e9c5 100644 --- a/src/venus/vkr_common.c +++ b/src/venus/vkr_common.c @@ -229,5 +229,5 @@ object_array_init(struct vkr_context *ctx, arr->objects[i] = obj; } - return arr; + return true; } |