aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-09-21Snap for 10843824 from 0348d10214299073ea59bda4987dd8813a9e7812 to 24Q1-releaseandroid-14.0.0_r37android-14.0.0_r36android-14.0.0_r35android-14.0.0_r34android-14.0.0_r33android-14.0.0_r32android-14.0.0_r31android-14.0.0_r30android-14.0.0_r29android14-qpr2-s5-releaseandroid14-qpr2-s4-releaseandroid14-qpr2-s3-releaseandroid14-qpr2-s2-releaseandroid14-qpr2-s1-releaseandroid14-qpr2-releaseAndroid Build Coastguard Worker
Change-Id: Ia39ecafdc4b00a0b2505b638c14b80c02e34d4b6
2023-08-21Upgrade toolchain-utils to 2942bd8023e3e0a79ed78fd4fff22c1f961e9f73 am: ↵Yabin Cui
1c2bb62c89 am: e0c166ae0c am: 1bcc74be81 am: 34bad74c3c am: 8eed62767c Original change: https://android-review.googlesource.com/c/platform/external/toolchain-utils/+/2716013 Change-Id: I782720da8f7650817d1ea90c4d12fe1474ef9ae4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21Upgrade toolchain-utils to 2942bd8023e3e0a79ed78fd4fff22c1f961e9f73 am: ↵Yabin Cui
1c2bb62c89 am: e0c166ae0c am: 1bcc74be81 am: 34bad74c3c Original change: https://android-review.googlesource.com/c/platform/external/toolchain-utils/+/2716013 Change-Id: I205cef59eb874640db1204303a7e0f8dd9cf1297 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21Upgrade toolchain-utils to 2942bd8023e3e0a79ed78fd4fff22c1f961e9f73 am: ↵Yabin Cui
1c2bb62c89 am: e0c166ae0c am: 1bcc74be81 Original change: https://android-review.googlesource.com/c/platform/external/toolchain-utils/+/2716013 Change-Id: I2f65b7134532a68c1cf0864fa824ea26ab9a8b28 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21Upgrade toolchain-utils to 2942bd8023e3e0a79ed78fd4fff22c1f961e9f73 am: ↵Yabin Cui
1c2bb62c89 am: e0c166ae0c Original change: https://android-review.googlesource.com/c/platform/external/toolchain-utils/+/2716013 Change-Id: I4e686942d789b1b9d0fbf37b0f1fcf2f6b9dd0b7 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21Upgrade toolchain-utils to 2942bd8023e3e0a79ed78fd4fff22c1f961e9f73 am: ↵Yabin Cui
1c2bb62c89 Original change: https://android-review.googlesource.com/c/platform/external/toolchain-utils/+/2716013 Change-Id: I583ef79b8bc3b527da1e4f94d542cc0e54421d6a Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-17Upgrade toolchain-utils to 2942bd8023e3e0a79ed78fd4fff22c1f961e9f73Yabin Cui
This project was upgraded with external_updater. Usage: tools/external_updater/updater.sh update toolchain-utils For more info, check https://cs.android.com/android/platform/superproject/+/main:tools/external_updater/README.md Bug: 296418126 Test: TreeHugger Change-Id: Ic02579672a1236629f437f587a056b9753519d1e
2023-08-16rust_uprev: remove obsolete step "remove patches"Bob Haarman
Previously, patches had the version number they apply to encoded in their filename. Because of this, patches corresponding to Rust versions whose ebuilds were being removed also needed to be removed. Nowadays, we don't include the Rust version in the patch filename anymore and we want to keep the patches from version to version. Thus, we don't need this step anymore. BUG=b:294547321 TEST=Upgrade Rust with the new script Change-Id: I95cf45a7fb2c0a6aa44999040ff5e3263d85cc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4775781 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org>
2023-08-16rust_uprev: generate profile dataBob Haarman
This change modifies rust_uprev so that it automatically generates profile data for new Rust versions as part of the upgrade process. Specifically, it performs the following steps: 1. Edit cros-rustc.eclass so that profile data is not listed in SRC_URI. 2. Generate manifests for the new rust and rust-host ebuilds, including the new sources, but not yet the profile data (which does not exist yet). 3. Invoke pgo_rust to generate and upload profile data. 4. Undo the previous change to cros-rustc.eclass so that SRC_URI includes profile data again. 5. Generate new manifests for the rust and rust-host ebuilds, this time including the new profile data. BUG=b:271017864 TEST=rust_uprev_test, perform a Rust upgrade with the new script Change-Id: I1672b8d62e148503bfcf6ab7bdde83b08f529fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4775780 Tested-by: Bob Haarman <inglorion@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org>
2023-08-15compiler_wrapper: Apply go fmt changesRyan Beltran
This CL applies the changes generated by go fmt. Mostly they are just changing the formatting of comments because go fmt seems to care about that. BUG=None TEST=go fmt Change-Id: I8162940a4e64735817b8718c42b4d36dff3ab600 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4777948 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
2023-08-14compiler_wrapper: Fix infinite recursion in runWithTimeoutRyan Beltran
This CL fixes a staticanalyzer result: env.go:126:9: infinite recursive call (SA5007) BUG=b:295930281 TEST=go test Change-Id: Id7d152afe658e8e104edd4730be9890c359d2b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4779193 Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
2023-08-14compiler_wrapper: Fix findings from staticcheckRyan Beltran
This CL fixes the following staticcheck findings: clang_tidy_flag.go:235:6: func hasAtLeastOneSuffix is unused (U1000) command.go:96:13: error strings should not be capitalized (ST1005) compiler_wrapper.go:97:22: should use time.Since instead of time.Now().Sub (S1012) compiler_wrapper.go:154:3: this value of cSrcFile is never used (SA4006) compiler_wrapper.go:187:12: unnecessary use of fmt.Sprintf (S1039) env.go:148:5: var _env is unused (U1000) env_test.go:228:2: this value of err is never used (SA4006) iwyu_flag.go:18:7: const iwyuCrashSubstring is unused (U1000) BUG=b:295930281 TEST=go test Change-Id: I3d365243192f9041d12b9c8385d4bd8ff1bd5669 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4779192 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
2023-08-14githooks: remove USE_PYTHON3 = TrueBob Haarman
We should no longer need USE_PYTHON3 = True, so let's clean up a bit and remove it. BUG=chromium:1401441 TEST=None Change-Id: I396c7a14ff5ee2b43b5a961f02c20b92ef4b1032 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4776070 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org>
2023-08-14githooks: shorten too-long linesBob Haarman
Several lines were reported as exceeding the 80-character limit. This shortens them. BUG=None TEST=None Change-Id: I3ecd16eb637cc699991841f9f92c56eab21e608d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4778621 Commit-Queue: Bob Haarman <inglorion@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org>
2023-08-14modified pgo_rust so that it can be invoked as a moduleBob Haarman
This will be used by an upcoming change to rust_uprev to automatically generate and upload profile data for new Rust versions. BUG=b:271017864 TEST=use it to upgrade Rust Change-Id: I9e382e0bc3317bb1de9d4501391029f457afae82 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4775779 Tested-by: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org>
2023-08-14rust_uprev: fetch Rust sources from upstream if not present on local mirrorBob Haarman
Previously, fetching sources from upstream, verifying their integrity, and uploading them to the local mirror was a manual process. With this change, this happens automatically. The integrity of the sources is verified using GPG, which checks that the sources have the expected checksum, that the checksum information was signed by the signing key used by the Rust project, and that the key and signature are current (that is, the key has not been revoked and the key and signature have not expired). The expected key is hardcoded in the script so that if we ever encounter sources signed by a different key, the verification will fail and we will have to manually verify that the new key is legitimate. BUG=b:271016462 TEST=unittest, use new script to create rust 1.71.1 uprev Change-Id: I9b2129ed82ca7de9f9aadfd275683f49cb72561a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4767736 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org>
2023-08-14rust_uprev: use Path.{read,write}_text instead of open().{read,write}Bob Haarman
This replaces open(...).read(...) with Path(...).read_text() and open(...).write(...) with Path(...).write_text(...). This avoids cros lint complaining about wanting to wrap the code in a with statement. BUG=None TEST=cros lint; run rust_uprev_test.py Change-Id: Ic3763c09e5f84470aeb36377d0aed92480279a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4775699 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org>
2023-08-14rust_uprev: Fix type information so that mypy runs successfullyBob Haarman
BUG=None TEST=mypy rust_tools/rust_uprev.py && ./run_tests_for rust_tools/rust_uprev.py Change-Id: Ifdb515aae078b2d35145b80084ecd4f59f498471 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4760606 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org>
2023-08-14pgo_rust: make mypy type checking passBob Haarman
BUG=None TEST=mypy Change-Id: Id6d21424091ef6a97238ad374abc84675adecd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4769059 Commit-Queue: Bob Haarman <inglorion@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org>
2023-08-14pgo_rust: fix line-too-long pylint complaintsBob Haarman
A number of lines in pgo_rust triggered line-too-long complaints from pylint. This fixes those, with the exception of one URL which happens to be longer than the line length. Shortening the URL is possible, but would make it less clear, so I've opted to instead silence the complaint for that line. BUG=None TEST=repo upload # see that cros lint no longer complains Change-Id: Ia6433eae378f66376aa33031cb3cee66e42bb69c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4775778 Tested-by: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org>
2023-08-09afdo_metadata: Publish the new kernel profilesmobiletc-prebuild
Update amd profile on chromeos-kernel-4.14 Update amd profile on chromeos-kernel-5.4 Update amd profile on chromeos-kernel-5.10 Update amd profile on chromeos-kernel-5.15 Update arm profile on chromeos-kernel-5.15 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: Icac55060fce1f4323f28247baa0b0d8fab36c3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4765892 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-08-08pgo_rust: Download crate if necessary for benchmark-nopgoBob Haarman
pgo_rust builds a crate for generating profile information and benchmarking non-PGO rustc vs. PGO rustc. This crate was previously being dowloaded as necessary for the "generate" and "benchmark-pgo" subcommands, but not the "benchmark-nopgo" subcommand. This CL fixes that. BUG=b:283927064 TEST=rm -fr /tmp/rust-pgo/crates; pgo_rust.py benchmark-nopgo Change-Id: I18e0016d6bbb523f9416ca69d71d3380130fe746 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4753097 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-08-02afdo_metadata: Publish the new kernel profilesmobiletc-prebuild
Update amd profile on chromeos-kernel-4.14 Update amd profile on chromeos-kernel-5.4 Update amd profile on chromeos-kernel-5.10 Update amd profile on chromeos-kernel-5.15 Update arm profile on chromeos-kernel-5.15 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I88fa831a7faddf7de1986ed9c38fe010091710f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4743699 Reviewed-by: Denis Nikitin <denik@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org>
2023-08-01llvm_tools: remove 4c scriptsGeorge Burgess IV
4c was turned down, so these scripts no longer have a purpose. BUG=b:293166552 TEST=None Change-Id: Ic2589c5c31cd6f6fd1af7501669bd2c663322c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4729352 Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org>
2023-07-31afdo_metadata: Publish the new kernel profilesmobiletc-prebuild
Update amd profile on chromeos-kernel-4.14 Update amd profile on chromeos-kernel-5.4 Update amd profile on chromeos-kernel-5.10 Update amd profile on chromeos-kernel-5.15 Update arm profile on chromeos-kernel-5.15 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I0902aa9449edcd9da3ddd36aa91a6bc91d0c6a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4730591 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-28update_kernel_afdo: Drop 4.19 kernelDenis Nikitin
BUG=b:292253082 TEST=cq Change-Id: Ib753f74d288a40b9a873456d29f9f85d892533a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4708685 Auto-Submit: Denis Nikitin <denik@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org>
2023-07-28llvm_tools: make update_packages_and_run_tests lint-cleanGeorge Burgess IV
BUG=None TEST=Preuploads Change-Id: If98425f5a8bf18984f66f1873008f273821d8e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4720511 Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-28llvm_tools: make modify_a_tryjob lint-cleanGeorge Burgess IV
BUG=None TEST=Preuploads Change-Id: Ie2533c17ec26bb1ef0974029413e1a7247c192ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4720510 Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Auto-Submit: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-28llvm_tools: use `Path`s for API which requires `Path`sGeorge Burgess IV
UpdatePackages requires `Path`s now for `chroot_path`. BUG=b:292048757, b:292054306 TEST=Unittests Change-Id: I67a427e5be798bb24e3fab5551500662b182ae6d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4720509 Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Auto-Submit: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-27auto_delete_nightly_test_data: use `|=` for return valuesGeorge Burgess IV
follow-up given feedback on crrev.com/c/4723016 BUG=None TEST=Unittests Change-Id: I7f9236785f897dbb1f494fb4cef9baf851c56943 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4726282 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-27auto_delete_nightly_test_data: clean up lintsGeorge Burgess IV
BUG=b:293350157, b:288112082 TEST=Unittests, `repo upload` Change-Id: I1e82b619971092950c2f87fde54c8c72d145bf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4723017 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-27auto_delete_nightly_test_data: remove dead partsGeorge Burgess IV
Now that old logs have been moved around, this script (that tried to keep them somewhat tidy) is failing. Since we no longer need to keep these bits tidy, don't. BUG=b:293350157, b:288112082 TEST=Unittests Change-Id: I92fd25bb72de00a4791a9653ed6ea53644c2fb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4723016 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-26afdo_metadata: Publish the new kernel profilesmobiletc-prebuild
Update amd profile on chromeos-kernel-4.14 Update amd profile on chromeos-kernel-4.19 Update amd profile on chromeos-kernel-5.4 Update amd profile on chromeos-kernel-5.10 Update amd profile on chromeos-kernel-5.15 Update arm profile on chromeos-kernel-5.15 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: Idd86874319dbcf34c655b30eed39b4be9803ebd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4720046 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-25llvm_tools: Preserve comments to manifest_utilsJordan R Abrahams-Whitehead
Comments should be preserved in the manifest files. While the code seems to work, the test itself was broken because it did not use the custom parser. Expand upon the test to better show that everything works. BUG=None TEST=./run_tests_for.py llvm_tools/manifest_utils_unittest.py Change-Id: I9f6292b8418374cbed777c4f786d498fcb64842b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4713968 Reviewed-by: George Burgess <gbiv@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-25llvm_tools: update_chromeos_llvm_hash.py straggling formatsJordan R Abrahams-Whitehead
Ran cros format on the code again, and they couldn't cleanly fit in the patch stack. BUG=None TEST=CQ Change-Id: I8e5895903c0f4ca4aa4ecda76565d6ec9cb6fe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4713967 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
2023-07-25llvm_tools: Restructure update_chromeos_llvm_hash.pyJordan R Abrahams-Whitehead
This commit fundamentally changes how "UpdatePackages" works. At present, UpdatePackages goes through a dictionary mapping between package names and ebuild symlinks. However, with the introduction of libcxx-999, this breaks as there is no symlink (and nothing to uprev). This breaks the assumptions of UpdatePackages. This commit reworks the function to create PortagePackage objects which infer the state of their overlay package and self-manage their updates accordingly. BUG=b:275877115, b:292048757, b:292054306 TEST=./run_tests_for.py llvm_tools/* TEST=update_chromeos_llvm_hash.py --is_llvm_next --repo_manifest Change-Id: Ifcc3740af80c1da1e1534afa9c01e79955295b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4713966 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-25compiler_wrapper: disable _FORTIFY_SOURCE=3 for sanitizersGeorge Burgess IV
Thanks to manojgupta for flagging this! BUG=b:288411201 TEST=CQ+1, unittests Change-Id: Ice3e555cb20f93f971d4ec923b442f46786a7e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4713974 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-25compiler_wrapper: manually apply -D_FORTIFY_SOURCE=2George Burgess IV
We want to migrate to -D_FORTIFY_SOURCE=3, but doing so conflicts with the wrapper's implicit application of -D_FORTIFY_SOURCE=2. Have the wrapper skip the whole -D_FORTIFY_SOURCE=2 bit if it sees -D_FORTIFY_SOURCE=3 BUG=b:288411201 TEST=Made a json diff tool that treats -D_FORTIFY_SOURCE=2 as though TEST=it's always at the end of arg lists. All commands compared equally. Change-Id: Iedb42da661e1b67c8d640ca25ffc22200999ffa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4706309 Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org>
2023-07-25llvm_tools: Get manifest_path from update_chromeos_manifestJordan R Abrahams-Whitehead
We'll need the manifest path later for git operations, as manifest_utils.py does not handle any git commands itself. update_chromeos_llvm_hash.py apparently does not test whether the manifest_path actually is added to the CL. BUG=None TEST=CQ Change-Id: Iea4a5443c8012db4c15161df01dd5da498aaba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4713965 Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-25llvm_tools: Update _toolchain.xml instead of full.xmlJordan R Abrahams-Whitehead
Since crrev.com/i/6046315, we should be using _toolchain.xml and merging hash changes there. BUG=b:275877115, b:267209587 TEST=update_chromeos_llvm_hash.py with --repo_manifest Change-Id: If4ccf39a9411b131f0b27c9c508203111d464f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4713544 Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-25llvm_tools: Types for ConvertChrootPathsToAbsolutePathsJordan R Abrahams-Whitehead
We'll use this later in the patch stack. Also do some minor formatting clean up while we're here. BUG=None TEST=None Change-Id: I6d0b06d2d9ffeb9c07a485382620e6a00824a543 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4708692 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-13heatmaps: removeGeorge Burgess IV
This tool was used primarily to turn perf.data profiles into pictures representing where in the binary %ip was over time. It almost certainly hasn't been used in many years, and as LLVM has gotten better at promoting code locality (especially through things like ThinLTO), it seems like it's increasingly unlikely for this to be relevant to us in the future. BUG=b:286091080 TEST=None Change-Id: Id1da1485f40b4aa974125167b06215431867373d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4683721 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-12afdo_metadata: Publish the new kernel profilesmobiletc-prebuild
Update amd profile on chromeos-kernel-4.14 Update amd profile on chromeos-kernel-4.19 Update amd profile on chromeos-kernel-5.4 Update amd profile on chromeos-kernel-5.10 Update amd profile on chromeos-kernel-5.15 Update arm profile on chromeos-kernel-5.15 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: Ib35046845f8045deb4c2f37c1f25e6c7d0c7c32b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4680457 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2023-07-12compiler_wrapper: add flag to skip automatic sysroot logicGeorge Burgess IV
Adding `--sysroot` and the implicit library path here breaks glibc's build when `llvm-libunwind` is installed. Since glibc is a special package, it seems OK to let it own its own destiny WRT gathering the proper includes & linking to libraries properly. BUG=b:290144273 TEST=emerge glibc Change-Id: I4f814b39334147631a0fdcb67ad1f0e067e1d674 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4678360 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org>
2023-07-11cros_utils: Reformat buildbot_utilsJordan R Abrahams-Whitehead
This attempts to isolate some of the style changes to make cros lint happier. It's not all encompassing. BUG=None TEST=./run_tests_for.py cros_utils/*test.py Change-Id: I55e264771ab2aa7160b43679602955dcfcf72beb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4674781 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org>
2023-07-10cros_utils: Make GetLogger have type guaranteesJordan R Abrahams-Whitehead
At present, GetLogger could return None, Logger, or MockLogger. No code seems to be built for when GetLogger returns None, and it would instead be nice to have that safety. The original InitLogger relies on modifying global state to ensure the main_logger is not None. This does not make the type analysis happy, so instead lets have InitLogger return the logger we initted. This also does a minor clean up of the code. BUG=None TEST=./run_tests_for.py cros_utils/* Change-Id: I2f5b142e088ceb0299d7ac2513b7c3c6f3800800 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4674780 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-10toolchain-utils: Remove buildbot_test_llvm.pyJordan R Abrahams-Whitehead
As far as I can tell, this file is no longer used by anything internally or externally. The program doesn't seem to work either, and hasn't had a functional update since 2019. It uses command_executor, and we're trying to clean up uses of that wherever possible. BUG=b:289058911 TEST=./run_tests_for.py cros_utils/*test* Change-Id: Iad14fb9076dd56e4a08c0486ad478aad18ea4f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4672449 Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2023-07-07cros_utils: Delete device_setup_utils*Jordan R Abrahams-Whitehead
These are not used by anything, as far as I can tell. It's just dead code. This code makes use of command_executor, so it's another free clean up. BUG=b:289058911 TEST=run_tests_for cros_utils/* Change-Id: I2599f1d8efa300c29cd1fafb32b7a9a739a04b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4659484 Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Auto-Submit: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org>
2023-07-07cros_utils: Clean command_executor in email_senderJordan R Abrahams-Whitehead
In an attempt to free ourselves from command_executor, this commit replaces command_executor with subrprocess, which has both a nicer interface and also doesn't rely on broken scripts. This is part of a general clean up process to help us not use remote_access.sh BUG=b:289058911 TEST=run_tests_for cros_utils/* Change-Id: I18199ba3ad2bb4eb33412d02fb303cd5196b6017 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4659483 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org>
2023-07-05afdo_metadata: Publish the new kernel profilesmobiletc-prebuild
Update amd profile on chromeos-kernel-4.14 Update amd profile on chromeos-kernel-4.19 Update amd profile on chromeos-kernel-5.4 Update amd profile on chromeos-kernel-5.10 Update amd profile on chromeos-kernel-5.15 Update arm profile on chromeos-kernel-5.15 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I2ebab1b2e378a883ca1c0e5160f10c1a6b8f4fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4667569 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-09 13:12:20 +0000