aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Li <dvdli@google.com>2021-03-09 02:59:58 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2021-03-09 02:59:58 +0000
commita04e937db9dc527d3c4dc0daed3db5404c21c2b2 (patch)
tree0906c962268135832de9fa33d81c5e9cad3cbe32
parent01611ca009296fd24403f4e84f71856a05d953e1 (diff)
parent935ad161bb89554894400b83f533acaf5c51d17e (diff)
downloadtinyalsa-a04e937db9dc527d3c4dc0daed3db5404c21c2b2.tar.gz
Merge "free the pcm structure and return &bad_pcm if open fails." am: 3028ab403f am: 935ad161bb
Original change: https://android-review.googlesource.com/c/platform/external/tinyalsa/+/1620694 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ibd0587e7f0052f2c6edba151fc05d486db462fca
-rw-r--r--pcm.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/pcm.c b/pcm.c
index c885b44..1d84dc0 100644
--- a/pcm.c
+++ b/pcm.c
@@ -1062,13 +1062,11 @@ fail:
pcm->ops->munmap(pcm->data, pcm->mmap_buffer, pcm_frames_to_bytes(pcm, pcm->buffer_size));
fail_close:
pcm->ops->close(pcm->data);
- pcm->data = NULL;
- pcm->fd = -1;
fail_open:
snd_utils_put_dev_node(pcm->snd_node);
- pcm->snd_node = NULL;
- return pcm;
+ free(pcm);
+ return &bad_pcm;
}
int pcm_is_ready(struct pcm *pcm)