diff options
| author | alandonovan <adonovan@google.com> | 2021-01-22 10:30:34 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-22 10:30:34 -0500 |
| commit | 3921cb6f16f6b9ff340bc9feeaac31db99e18234 (patch) | |
| tree | 268e5d49c36c5ecaa239cf59fa04bc2495b49435 | |
| parent | cea917ab6e0f5d6548d516f8c30e197d63db9baa (diff) | |
| download | starlark-go-3921cb6f16f6b9ff340bc9feeaac31db99e18234.tar.gz | |
spec: remove more stale implementation notes (#342)
| -rw-r--r-- | doc/spec.md | 2 | ||||
| -rw-r--r-- | starlark/testdata/string.star | 3 |
2 files changed, 1 insertions, 4 deletions
diff --git a/doc/spec.md b/doc/spec.md index 2b83ffa..cbd117e 100644 --- a/doc/spec.md +++ b/doc/spec.md @@ -4231,7 +4231,7 @@ applications to mimic the Bazel dialect more closely. Our goal is eventually to eliminate all such differences on a case-by-case basis. See [Starlark spec issue 20](https://github.com/bazelbuild/starlark/issues/20). -* String interpolation supports the `[ixXc]` conversions. +* String interpolation supports the `[ioxXc]` conversions. * String elements are bytes. * Non-ASCII strings are encoded using UTF-8. * Strings support hex byte escapes. diff --git a/starlark/testdata/string.star b/starlark/testdata/string.star index 859f645..84c6791 100644 --- a/starlark/testdata/string.star +++ b/starlark/testdata/string.star @@ -412,9 +412,6 @@ assert.fails(lambda: sorted("abc"), "got string, want iterable") # sorted assert.fails(lambda: [].extend("bc"), "got string, want iterable") # list.extend assert.fails(lambda: ",".join("abc"), "got string, want iterable") # string.join assert.fails(lambda: dict(["ab"]), "not iterable .*string") # dict - -# The Java implementation does not correctly reject the following cases: -# (See Google Issue b/34385336) assert.fails(for_string, "string value is not iterable") # for loop assert.fails(lambda: [x for x in "abc"], "string value is not iterable") # comprehension assert.fails(lambda: all("abc"), "got string, want iterable") # all |