From 920bf3d02b328b844952525763b27caf297a02c5 Mon Sep 17 00:00:00 2001 From: Neil Fuller Date: Wed, 10 May 2023 10:58:56 +0000 Subject: Suppress an occasionally flaky, randomized test. Suppress an occasionally flaky, randomized test. The test sometimes "hangs", possibly due to b/6428842 where it is suggested that the randomized geometry the test generates can be "inverted", i.e. instead of a small area, the area described is everywhere except for a small area, leading to a massive area. This is a guess - the test is being suppressed on Android as this code isn't being used for anything important right now. Bug: 280346791 Test: treehugger only Change-Id: Id5ba8250839ac44b1515305431400328a7683744 --- tests/com/google/common/geometry/S2RegionCovererTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/com/google/common/geometry/S2RegionCovererTest.java b/tests/com/google/common/geometry/S2RegionCovererTest.java index 51e3de4..5ff8969 100644 --- a/tests/com/google/common/geometry/S2RegionCovererTest.java +++ b/tests/com/google/common/geometry/S2RegionCovererTest.java @@ -74,6 +74,9 @@ public strictfp class S2RegionCovererTest extends GeometryTestCase { } } + // b/280346791 - commented in Android as this test occasionally takes a long time, probably + // due to an upstream bug that generates pathological test geometry cases. + /* public void testRandomCaps() { logger.info("TestRandomCaps"); @@ -115,6 +118,7 @@ public strictfp class S2RegionCovererTest extends GeometryTestCase { checkCovering(coverer, cap, denormalized, false); } } + */ public void testSimpleCoverings() { logger.info("TestSimpleCoverings"); -- cgit v1.2.3