Age | Commit message (Collapse) | Author |
|
52e56fbeb8 am: 3f8bc0357b am: 0ab6fbb6fb am: 83a3677d8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: Ifa77fe5c89f3e48e4f41c04b3e532aef3a88aea0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
3757f6eee1 am: 02ec2e8082 am: 8f05455e65
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: Ibf6c7bdfa5968cf29050f40f6fd94e2cbbbb6161
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
52e56fbeb8 am: 3f8bc0357b am: 0ab6fbb6fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: I0410fa6739dbb0e26061fabd24d30a5ecb65684f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
3757f6eee1 am: 02ec2e8082
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: I9bf77ded2bece69f9daea0bdfe74e0f1f1711c36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
52e56fbeb8 am: 3f8bc0357b
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: I7c9244afb69b58c34ea29de88c3ac77c90d60ee2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: Ie9136e0363b96495ceb72972bd0e6680379d3ddf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: I7350fbbc7a379a3b8e5afa0c5cb1b2ade606eff9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: I0d95410dcf86a1143c3de5c2a789963fa7b2e9d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/23120797
Change-Id: Id744e15b62ca838535edd3bb838ee1017c344b0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Suppress an occasionally flaky, randomized test. The test sometimes
"hangs", possibly due to b/6428842 where it is suggested that the
randomized geometry the test generates can be "inverted", i.e.
instead of a small area, the area described is everywhere except for
a small area, leading to a massive area.
This is a guess - the test is being suppressed on Android as this
code isn't being used for anything important right now.
Bug: 280346791
Test: treehugger only
Change-Id: Id5ba8250839ac44b1515305431400328a7683744
|
|
bc9a7bb0d2 am: d62bc5b681 -s ours am: b79caa2255 -s ours am: c6f7b38a74 -s ours am: f1d9f4f62e -s ours
am skip reason: Merged-In I2608f134f1232a04fbfd094ce47c5747b88336fa with SHA-1 eab1a33feb is already in history
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/2131922
Change-Id: Id8a18ae291b42bbc9449238f82768085b77ca29e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
bc9a7bb0d2 am: d62bc5b681 -s ours am: b79caa2255 -s ours am: c6f7b38a74 -s ours
am skip reason: Merged-In I2608f134f1232a04fbfd094ce47c5747b88336fa with SHA-1 eab1a33feb is already in history
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/2131922
Change-Id: I29524d8135ac5e7d217f7c4f11878140fd966a2b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
bc9a7bb0d2 am: d62bc5b681 -s ours am: b79caa2255 -s ours
am skip reason: Merged-In I2608f134f1232a04fbfd094ce47c5747b88336fa with SHA-1 eab1a33feb is already in history
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/2131922
Change-Id: Iecb5dffe06d436ba1c699d7123ed7513b9004a64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
bc9a7bb0d2 am: d62bc5b681 -s ours
am skip reason: Merged-In I2608f134f1232a04fbfd094ce47c5747b88336fa with SHA-1 eab1a33feb is already in history
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/2131922
Change-Id: I8a62f6fe6095be792cfa0f8dd28e4373eaa520e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/2131922
Change-Id: I97b09c289f92929a1e7d65173100426f035e7535
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
65c25bb360 am: 480d97b832
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/18993610
Change-Id: Ie5f91eba6d2b3d84eb1333fd97bfd8034b62bef7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/18993610
Change-Id: I8d3f1523b454a7b7e00212aaaa984842f6947dc4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/18993610
Change-Id: Id91de96b70ce31d2b0f7cca70d78afef0b065e73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Allow the S2 java lib to be used in platform code, not just an APEX.
Bug: 231906346
Test: Build only
Merged-In: I2608f134f1232a04fbfd094ce47c5747b88336fa
Change-Id: I2608f134f1232a04fbfd094ce47c5747b88336fa
|
|
Allow the S2 java lib to be used in platform code, not just an APEX.
Bug: 231906346
Test: Build only
Change-Id: I2608f134f1232a04fbfd094ce47c5747b88336fa
|
|
am: 45b25db709
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/1864565
Change-Id: I5fa30fd27927a2081204a13a07e34909b21011fb
|
|
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/1864565
Change-Id: Iffae9486b9e55265fa0ac6ed811ee82518b1dfea
|
|
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/1864565
Change-Id: I6c8086611b2fc9c83996f972d3397720d80b81a8
|
|
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/1864565
Change-Id: I1060d8ca3a58eb5e7a2f65952e8f90781e3b7371
|
|
Original change: https://android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/1864565
Change-Id: Ia72d9900eb3467e2ea22f36795db5413511c0558
|
|
This project is used by the packages/modules/GeoTZ code so point
the OWNERS there.
Test: None
Change-Id: I9342f5c2af51d0f87b9b6ca5e9d5381405e50f6c
|
|
Bug: 189946434
Change-Id: Iff3ab8b537d9acf885657cfc4923b3315b5d671b
|
|
into sc-dev am: 68ec31df9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/13775503
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I1b9a1769543f749d25a1714023030f96460e21c3
|
|
into sc-dev am: 68ec31df9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/13775503
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I856a82853d9aad8e498451b99711e5eecc28a287
|
|
into sc-dev
|
|
With b/180736967, java_test_host unit tests are automatically running
in presubmit and do not need an explicit TEST_MAPPING.
Change-Id: I3e26866a73336ef60fcfe7289414b1e496067d48
Test: presubmit
Bug: 180736967
|
|
dae5745741
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/13741148
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I0c2b27d8a8445deb8e4c082570abd9779b6e2f57
|
|
dae5745741
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/s2-geometry-library-java/+/13741148
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ic929705b8bb15730a9299595da3bdfebbf2c35bc
|
|
Added SPDX-license-identifier-Apache-2.0 to:
Android.bp
Bug: 68860345
Bug: 151177513
Bug: 151953481
Test: m all
Exempt-From-Owner-Approval: janitorial work
Change-Id: I380c23d63e58e94b66ae44db5f4e8e5420869d28
|
|
Anchor the API level the library is compiled against and allow the
library to be included in the geotz APEX.
The choice of API level 30 is arbitrary - it could be lower but it
doesn't need to be.
Bug: 152746105
Test: build
Change-Id: I7a4cd0b476a8829cd3ff0e88441cc3398268d9fb
|
|
Test: build
Bug: 152747091
Change-Id: I34a876afbddc02d4a3a5477a41f2a4590c56b07a
|
|
This corrects the Android.bp and returns the TEST_MAPPING.
This reverts commit 081ad246e6d9559f8e5d8d5df99c1edf8515f597.
Bug: 161459805
Test: treehugger
Change-Id: Iac8c4ae4db4434cf1c2c36b0254363a051fc7c56
|
|
The project was just added and it looks like the TEST_MAPPING is causing
problems. Removing to fix presubmit.
Bug: 161459805
Test: None
Change-Id: I2060d2537254f01e91fb31ba89524d6b2fb3d1f9
|
|
Add the license files needed by Android, add Android build rules
and remove prebuilts.
The build rules include test targets. One of the tests fails already so
it is "suppressed" here.
Bug: 152746105
Test: atest --host s2-geometry-library-java-tests
Test: atest S2GeometryLibraryJavaTests
Change-Id: Iaa7033e866a7897dd6ced01ac72b3df051a9975f
|
|
The initial check-in of upstream code from master.
Bug: 152746105
Test: None
Change-Id: Ia3e6e5d3ec6f5f2d202d49b295296aaac7a790e1
|
|
|
|
the method.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25471702
|
|
only have been converted to asserts, and commented out pending an answer from the java libraries team on how best to handle debug time only checks. One of these changes overlaps a change started by ikaushan in CL 25025671 -- hopefully he beats me to the punch.
S2EdgeIndex incorrectly copied the S2 Minimum Width metric, rather than referring to the metric in S2Projections. This change should have no effect, except in the case that the projection in S2 is changed, in which case it may work fine now, but would certainly have been incredibly wrong before.
Vital performance fixes:
- Several classes and methods are now final, to avoid subclasses tampering with them and/or to allow the jvm to apply additional runtime optimizations.
- Fixed performance of S2PolygonBuilder#assembleLoop(), which was removing N vertices from the start of an ArrayList *one at a time*, by calling ArrayList.remove(0) N times. Which of course takes N*list.size() steps, aka very quadratic performance in the common case of many loops in the builder. Instead we now call list.subList(n, list.size()), to just skip past the vertices we don't care about.
- Fixed S2Polygon.S2PolygonIndex creating a copy of the whole array of vertices in *every call* to edgeFromTo(), because S2Loop's copy constructor was being used, for no apparent reason, which clones the vertices. Since edgeFromTo() is called twice per vertex to create the polygon index, a polygon with N vertices was inadverdantly copying 2*N^2 vertices to build the polygon index.
- Fixed performance of S2Polygon#clipBoundary(), which was testing every vertex of a polygon b for containment in polygon a, only to emit a log message that essentially never occurs. In C++, this check is a debug time only check, so the pattern has been followed of making this a commented-out assertion instead of doing this extremely expensive check in production code. Also greatly simplified the addition of edges to the S2PolygonBuilder by relying on the checks already being done in the builder.
- Fixed performance of S2Loop#vertex(int), which was doing a check before indexing into the vertices array, which itself does a range check. Since we don't need or want want both checks, the array dereference exception is caught and rethrown so the external behavior of the method is unchanged, but it is now significantly faster.
- Fixed performance of S2Polygon.S2LoopSequenceIndex, which was suffering from using List<Integer>. By using int[] instead, we save extra method calls and a lot of boxing/unboxing in this performance critical area.
- S2EdgeIndex now stores cells and edges more efficiently in parallel arrays, and edge lookups have been made significantly faster by a local implementation of binary search.
- S2EdgeIndex methods getEdgesInParentCells and getEdgesInChildrenCells now take a Set instead of a List that is then filtered through a set. This saves an extra copy of all the edges, and keeps us from accumulating redundant copies of the same edge as the search progresses.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25397727
|
|
speedup of S2Polygon.isValid().
This particular hot spot was identified using YourKit profiler.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25256987
|
|
Before this CL it was possible to have instances of S2Edge such that:
a.equals(b) ==/==> b.equals(a)
b.equals(a) && b.equals(c) ==/==> a.equals(c)
Undirected edges are just fundamentally a different type to an S2Edge
and should be treated as such. Additionally they are only used privately
in one place and never using polymorphic behaviour.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25140523
|
|
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25130844
|
|
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25081675
|
|
static arrays.
The IJ_TO_POS array was never being called so for now I removed it. We can
trivially add it back (with appropriate lookup function) if we need it later.
The other arrays were wrapped and given (hopefully) better JavaDoc.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=25078833
|
|
file it is in, so each file can be reviewed independantly.
Basically this tackles some very low hanging fruit with respect to immutability
and some minor style issues.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=24987273
|
|
fix broken build (http://test/ui#p=geo.gt) of java/com/google/geo/gt/geometry/GTLatLngRect.java
(introduced by CL 24952612)
Tested:
javatests/com/google/common/geometry:all
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=24955423
|