aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@google.com>2023-11-20 20:18:46 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2023-11-20 20:18:46 +0000
commit14b23d205d1edeb873bbdd28a974545281b7c9bf (patch)
tree9b7623254330fd2491cfa3030c4ada96adb601ae
parent6210ec60e705ebd9cdccadf1e0dcd3f8193904dd (diff)
parentb52442f6faeb64681742b274e9c07ec7fa1e2db3 (diff)
downloadrobolectric-shadows-14b23d205d1edeb873bbdd28a974545281b7c9bf.tar.gz
Do not use isFileEncryptedNativeOrEmulated() on Android 14 and later am: 82724e7932 am: 9eed888af3 am: b52442f6fa
Original change: https://android-review.googlesource.com/c/platform/external/robolectric-shadows/+/2835791 Change-Id: I26253a28270f62f4e02cfbcdd8f43ad01e2da4c9 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--robolectric/src/test/java/org/robolectric/shadows/ShadowStorageManagerTest.java11
-rw-r--r--shadows/framework/src/main/java/org/robolectric/shadows/ShadowStorageManager.java5
2 files changed, 13 insertions, 3 deletions
diff --git a/robolectric/src/test/java/org/robolectric/shadows/ShadowStorageManagerTest.java b/robolectric/src/test/java/org/robolectric/shadows/ShadowStorageManagerTest.java
index e1c4c7104..220317adc 100644
--- a/robolectric/src/test/java/org/robolectric/shadows/ShadowStorageManagerTest.java
+++ b/robolectric/src/test/java/org/robolectric/shadows/ShadowStorageManagerTest.java
@@ -1,6 +1,7 @@
package org.robolectric.shadows;
import static android.os.Build.VERSION_CODES.N;
+import static android.os.Build.VERSION_CODES.TIRAMISU;
import static com.google.common.truth.Truth.assertThat;
import static org.robolectric.RuntimeEnvironment.application;
import static org.robolectric.Shadows.shadowOf;
@@ -17,6 +18,7 @@ import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.Config;
+import org.robolectric.util.ReflectionHelpers;
/** Unit tests for {@link ShadowStorageManager}. */
@RunWith(AndroidJUnit4.class)
@@ -53,10 +55,15 @@ public class ShadowStorageManagerTest {
}
@Test
- @Config(minSdk = N)
+ @Config(minSdk = N, maxSdk = TIRAMISU)
public void isFileEncryptedNativeOrEmulated() {
shadowOf(storageManager).setFileEncryptedNativeOrEmulated(true);
- assertThat(StorageManager.isFileEncryptedNativeOrEmulated()).isTrue();
+ // Use reflection, as this method is planned to be removed from StorageManager in V.
+ assertThat(
+ (boolean)
+ ReflectionHelpers.callStaticMethod(
+ StorageManager.class, "isFileEncryptedNativeOrEmulated"))
+ .isTrue();
}
@Test
diff --git a/shadows/framework/src/main/java/org/robolectric/shadows/ShadowStorageManager.java b/shadows/framework/src/main/java/org/robolectric/shadows/ShadowStorageManager.java
index 2614d7e88..f17c6f434 100644
--- a/shadows/framework/src/main/java/org/robolectric/shadows/ShadowStorageManager.java
+++ b/shadows/framework/src/main/java/org/robolectric/shadows/ShadowStorageManager.java
@@ -2,6 +2,7 @@ package org.robolectric.shadows;
import static android.os.Build.VERSION_CODES.M;
import static android.os.Build.VERSION_CODES.N;
+import static android.os.Build.VERSION_CODES.TIRAMISU;
import static org.robolectric.RuntimeEnvironment.application;
import android.os.UserManager;
@@ -82,8 +83,10 @@ public class ShadowStorageManager {
return null;
}
+ // Use maxSdk=T for this method, since starting in U, this method in StorageManager is deprecated
+ // and is no longer called by the Android framework. It's planned to be removed entirely in V.
@HiddenApi
- @Implementation(minSdk = N)
+ @Implementation(minSdk = N, maxSdk = TIRAMISU)
protected static boolean isFileEncryptedNativeOrEmulated() {
return isFileEncryptionSupported;
}