aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Zerny <zerny@google.com>2017-10-26 08:46:15 +0200
committerIan Zerny <zerny@google.com>2017-10-26 08:46:15 +0200
commitb2a5217985db7c9e40268a3237f1c0c0519a43e9 (patch)
treee7b83069950bae9d6bd1ec124170badb82d02ff3
parent325f44954718c76079b86f149c6a61442e8aee99 (diff)
downloadr8-b2a5217985db7c9e40268a3237f1c0c0519a43e9.tar.gz
Remove loop over all DEX runtimes now that bots support 4.4.4.
R=ager Change-Id: I6afd7d7d17f29539b489876afbcfbacc18e72877
-rw-r--r--src/test/java/com/android/tools/r8/R8RunExamplesTest.java34
1 files changed, 14 insertions, 20 deletions
diff --git a/src/test/java/com/android/tools/r8/R8RunExamplesTest.java b/src/test/java/com/android/tools/r8/R8RunExamplesTest.java
index e21e1bbb5..614f771ca 100644
--- a/src/test/java/com/android/tools/r8/R8RunExamplesTest.java
+++ b/src/test/java/com/android/tools/r8/R8RunExamplesTest.java
@@ -246,28 +246,22 @@ public class R8RunExamplesTest {
fail("JVM failed for: " + mainClass);
}
- // TODO(ager): Once we have a bot running using dalvik (version 4.4.4) we should remove
- // this explicit loop to get rid of repeated testing on the buildbots.
- for (DexVm version : artVersions) {
- TestCondition condition = failingRun.get(mainClass);
- if (condition != null && condition.test(getTool(), compiler, version.getVersion(), mode)) {
- thrown.expect(Throwable.class);
- } else {
- thrown = ExpectedException.none();
- }
+ DexVm vm = ToolHelper.getDexVm();
+ TestCondition condition = failingRun.get(mainClass);
+ if (condition != null && condition.test(getTool(), compiler, vm.getVersion(), mode)) {
+ thrown.expect(Throwable.class);
+ } else {
+ thrown = ExpectedException.none();
+ }
- // Check output against Art output on original dex file.
- String output =
- ToolHelper.checkArtOutputIdentical(original, generated.toString(), mainClass, version);
+ // Check output against Art output on original dex file.
+ String output =
+ ToolHelper.checkArtOutputIdentical(original, generated.toString(), mainClass, vm);
- // Check output against JVM output.
- if (shouldMatchJVMOutput(version.getVersion())) {
- String javaOutput = javaResult.stdout;
- assertEquals(
- "JVM and Art output differ:\n" + "JVM:\n" + javaOutput + "\nArt:\n" + output,
- javaOutput,
- output);
- }
+ // Check output against JVM output.
+ if (shouldMatchJVMOutput(vm.getVersion())) {
+ String javaOutput = javaResult.stdout;
+ assertEquals("JVM and Art output differ", javaOutput, output);
}
}