aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-05Merge pull request #16388 from protocolbuffers/cp-manifest-jpmsupstream-25.xzhangskz
Cherry-Pick Add Automatic-Module-Name (#14562)
2024-04-05Disable MacOS C++ Cmake test for now.Joshua Haberman
PiperOrigin-RevId: 594102279
2024-04-04Update setup-php to 2.30.0 and re-enable macOS PHP 8.2 tests.Sandy Zhang
setup-php 2.30.0 should fix https://github.com/shivammathur/setup-php/issues/823 PiperOrigin-RevId: 612882408
2024-04-02Add Automatic-Module-Name (#14562)Clayton Walker
Adds Automatic-Module-Name after it was lost during the maven-bazel migration (and subsequent re-addition of osgi bundle support). Updates OsgiWrapper to support adding the Automatic-Module-Name header to the list of properties supported by the `osgi_java_library` rule. Fixes #12639 Closes #14562 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14562 from Sineaggi:add-automatic-module-name a27b3e6695acb4f1f253422fd2d324bb1b3f6669 PiperOrigin-RevId: 579748655
2024-02-27Merge pull request #15985 from protocolbuffers/staleness-fix-25Mike Kruskal
Fix staleness tests
2024-02-27Add back error message unconditionallyMike Kruskal
2024-02-27Pin bazel 6 for 25.xMike Kruskal
2024-02-27Merge pull request #15984 from mkruskal-google/staleness-fix-25Mike Kruskal
Actually fail if staleness fail
2024-02-27Regen stale filesMike Kruskal
2024-02-27Actually fail if staleness failMike Kruskal
PiperOrigin-RevId: 610833812
2024-02-15Merge pull request #15858 from protocolbuffers/25.x-202402152111Jerry Berg
25.3 202402152111
2024-02-15Updating version.json and repo version numbers to: 25.4-devProtobuf Team Bot
2024-02-15Updating version.json and repo version numbers to: 25.3Protobuf Team Bot
2024-02-12Merge pull request #15814 from protocolbuffers/cp-ruby-3.3zhangskz
Update Ruby GHA to test against Ruby 3.3.
2024-02-12Update Ruby GHA to test against Ruby 3.3.Sandy Zhang
Fixes #15182 PiperOrigin-RevId: 593899707
2024-02-12Merge pull request #15802 from protocolbuffers/cp-25.xzhangskz
Cherrypick Apple Privacy Manifest changes to make these available in 25.x
2024-02-12Bump python version to 3.9 for gcloud 460.0.0Mike Kruskal
PiperOrigin-RevId: 599953322
2024-02-12[ObjC] Use a local to avoid warnings in 32bit builds.Thomas Van Lenten
CocoaPods fails spec validation for some warnings, so use a local to avoid warnings for 64->32bit implicit conversions. This comes up for watchOS builds. PiperOrigin-RevId: 601849919
2024-02-12[CPP] Add the privacy manifest to the C++ CocoaPod.Thomas Van Lenten
There are no restrict calls, so the manifest asserts that. The CocoaPods support now ensures you are using CocoaPods >= 1.12 as that avoids all the know bugs in CocoaPods support needed to capture the Privacy Manifest in a resource bundle. PiperOrigin-RevId: 602443703
2024-02-12[ObjC] Add the privacy manifest to the ObjC CocoaPod.Thomas Van Lenten
There are no restrict calls, so the manifest asserts that. The CocoaPods support now ensure you are using CocoaPods >= 1.12 as that avoids all the know bugs in CocoaPods support needed to capture the Privacy Manifest in a resource bundle. PiperOrigin-RevId: 602433417
2024-02-12Add PrivacyInfo.xcprivacy (#15557)dmaclach
issue##15029 As required by https://developer.apple.com/support/third-party-SDK-requirements/ Protos does not collect data. Required reason APIs searched for using: ``` grep -ER 'NSFileCreationDate|NSFileModificationDate|fileModificationDate|NSURLContentModificationDateKey|NSURLCreationDateKey|getattrlist\(|getattrlistbulk\(|fgetattrlist\(|stat\(|fstat\(|fstatat\(|lstat\(|getattrlistat\(|systemUptime\(|mach_absolute_time\(|NSURLVolumeAvailableCapacityKey|NSURLVolumeAvailableCapacityForImportantUsageKey|NSURLVolumeAvailableCapacityForOpportunisticUsageKey|NSURLVolumeTotalCapacityKey|NSFileSystemFreeSize|NSFileSystemSize|statfs\(|statvfs\(|fstatfs\(|fstatvfs\(|getattrlist\(|fgetattrlist\(|getattrlistat\(|activeInputModes|NSUserDefaults' . ``` ``` ./third_party/utf8_range/utf8_to_utf16/main.c: if (fstat(fd, &stat) == -1) { ./third_party/utf8_range/main.c: if (fstat(fd, &stat) == -1) { ./src/google/protobuf/map.h: s = mach_absolute_time(); ./src/google/protobuf/io/io_win32.cc:int stat(const char* path, struct _stat* buffer) { ./src/google/protobuf/io/io_win32.cc: return ::_wstat(wpath.c_str(), buffer); ./src/google/protobuf/io/io_win32.cc: return ::_stat(path, buffer); ./src/google/protobuf/io/io_win32.h:PROTOBUF_EXPORT int stat(const char* path, struct _stat* buffer); ./src/google/protobuf/testing/file.cc: if (lstat(name.c_str(), &stats) != 0) return; ./src/google/protobuf/compiler/importer.cc: ret = stat(std::string(filename).c_str(), &sb); ``` `./third_party/utf8_range/...` - tool for utf that is not in user binaries `./src/google/protobuf/map.h` - resolved with pull#15554 `./src/google/protobuf/io/io_win32.cc` - windows code `./src/google/protobuf/testing/file.cc` - testing code not in user binaries `./src/google/protobuf/compiler/importer.cc` - compiler code not in user binaries So no required reason APIs. Apple has not yet communicated how this is to be put into podspecs so saving for future commit. Closes #15557 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15557 from dmaclach:privacy 4c4e570adf4ab7c340817eb8f098ee112ed052be PiperOrigin-RevId: 601362376
2024-02-12remove use of mach_absolute_time (#15554)dmaclach
`mach_absolute_time` is one of Apple's required reason APIs (https://developer.apple.com/documentation/kernel/1462446-mach_absolute_time?language=objc). Replace it with the suggested `clock_gettime_nsec_np(CLOCK_UPTIME_RAW)` so that we don't need a RRA entry in a privacy manifest. issue #15029 Closes #15554 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15554 from protocolbuffers:dmaclach-mach_absolute_time 295d83178d5567743c720e7405ac974b0bcab832 PiperOrigin-RevId: 601370915
2024-01-09Merge pull request #15360 from protocolbuffers/backport-bundlerzhangskz
Pin bundler version to 2.4.22 for Ruby 2.7 support.
2024-01-09Merge pull request #15359 from protocolbuffers/25.x-202401092212Mike Kruskal
25.x 202401092212
2024-01-09Pin bundler version to 2.4.22 for Ruby 2.7 support.Sandy Zhang
Latest bundler 2.5.0 release results in the following error: `The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with gem install bundler -v 2.4.22 bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.3.183.` PiperOrigin-RevId: 591288515
2024-01-08Updating version.json and repo version numbers to: 25.3-devProtobuf Team Bot
2024-01-08Updating version.json and repo version numbers to: 25.2Protobuf Team Bot
2023-11-29Merge pull request #14907 from mkruskal-google/cmake-install-fixzhangskz
Only substitute prefixes during installation setup.
2023-11-29Only substitute prefixes during installation setup.Mike Kruskal
This caused an issue on some platforms where `protobuf/java/core/src/main/java/com/google/protobuf/java_features.proto` was getting turned into the invalid path `java/core/src/main/java/com/google/java_features.proto`. Fixes #14862 PiperOrigin-RevId: 586478133
2023-11-17Merge pull request #14800 from mkruskal-google/leak-patchMike Kruskal
Register a shutdown deleter for C++ feature defaults
2023-11-17Register a shutdown delete for C++ feature defaultsMike Kruskal
Fixes #14794 PiperOrigin-RevId: 583499526
2023-11-15Merge pull request #14765 from protocolbuffers/25.x-202311152135zhangskz
25.x 202311152135
2023-11-15Updating version.json and repo version numbers to: 25.2-devProtobuf Team Bot
2023-11-15Updating version.json and repo version numbers to: 25.1Protobuf Team Bot
2023-11-14Add support for extensions in CRuby, JRuby, and FFI Ruby (#14703) (#14756)zhangskz
Follow up to #14594, which added support for custom options, this PR implements extensions support, which should fully resolve #1198. Closes #14703 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14703 from protocolbuffers:add-support-for-extensions-in-ruby 601aca4121212c1633e9c7cd8abc65aebe9da9df PiperOrigin-RevId: 582460674 Co-authored-by: Jason Lunn <jason.lunn@gmail.com>
2023-11-13Add support for options in CRuby, JRuby and FFI (#14594) (#14739)Jason Lunn
Rewrrte and extension of #12828, with additional work for JRuby. Partially fixes #1198 by adding support for custom options. Handling of extensions will be handled in a follow up. Also includes these unrelated fixes: * Removes code echo between `google/protobuf/repeated_field.rb` and `google/protobuf/ffi/repeated_field.rb` by `require`'ing the former in the latter. * Adds missing calles to `testFrozen()` from methods of `RepeatedField` under JRuby that mutate. * Various typos in comments. Closes #14594 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14594 from protocolbuffers:add-support-for-options-in-ruby 16cc9e35b8635989af28962f4a54444a176a0559 PiperOrigin-RevId: 580848874
2023-11-13Bump mac PHP version to 8.2 to fix non-hermetic breakages. (#14741)zhangskz
This was likely either a change in macos or the github runners PiperOrigin-RevId: 580245853 This is a backport of 62f4888
2023-11-07Merge pull request #14674 from anandolee/25.xMike Kruskal
Cherry pick to 25.x: Raise warnings for python syntax usages
2023-11-07Raise warnings for python syntax usagesJie Luo
PiperOrigin-RevId: 579344748
2023-11-06Move python/BUILD to python/BUILD.bazel (#14658)Adam Cozzette
This should address the issue in #14600 by avoiding a conflict on with the `build` directory created by setup.py on a case-insensitive filesystem. Closes #14600. PiperOrigin-RevId: 579859556
2023-11-02Merge pull request #14620 from protocolbuffers/win2019-25.xMike Kruskal
Backport CI fixes to 25.x
2023-11-02Error on staleness failureMike Kruskal
2023-11-02Update `cc_file_list_aspect` to handle targets with missing `hdrs/textual_hdrs`Adam Cozzette
Our stale file regeneration logic broke with Bazel 6.4.0, and I suspect it was caused by this change: https://github.com/bazelbuild/bazel/pull/19534 Our logic assumed that any target with a `CcInfo` provider must have `hdrs` and `textual_hdrs` attributes, but it seems that this is no longer true for `cc_proto_library` starting with Bazel 6.4.0. The fix is just to use `getattr` and treat the item as an empty list if it's missing. PiperOrigin-RevId: 575473886
2023-11-02Pin python at 3.11.Mike Kruskal
Github changed their mac runners to use 3.12 by default, which removed setuptools and is causing breakages in some of our tests. PiperOrigin-RevId: 578917538
2023-11-02Enable caching of pip dependenciesMike Kruskal
PiperOrigin-RevId: 578740011
2023-11-02Fix windows 2019 build.Mike Kruskal
setup-gcloud doesn't honor the environment variables set by setup-python, so we need to manually set CLOUDSDK_PYTHON before running it. PiperOrigin-RevId: 578674246
2023-11-01Merge pull request #14596 from protocolbuffers/25.x-202311012212Joshua Haberman
25.x 202311012212
2023-11-01Migrate tests to windows 2022 by default.Mike Kruskal
For the windows 2019 test, we need to upgrade python for the latest gcloud to work. PiperOrigin-RevId: 578600130
2023-11-01Updating version.json to: 25.1-devProtobuf Team Bot
2023-11-01Updating version.json and repo version numbers to: 25.0Protobuf Team Bot