aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPrimiano Tucci <primiano@google.com>2021-06-25 09:31:47 +0100
committerPrimiano Tucci <primiano@google.com>2021-06-25 08:34:31 +0000
commit3a9c0ef08c3aa0f1edc6dbf5502e84025c092609 (patch)
tree5b7c6a440f3cd0889923523e294b8b809cea0122
parentf69a7701253a1c934595a31c581465a1acb0af80 (diff)
downloadperfetto-3a9c0ef08c3aa0f1edc6dbf5502e84025c092609.tar.gz
Disable SaveForBugreport_Triggers on android buildsandroid12-dev
This test seems failing on GSI builds for non clear reasons. The code under test does not depend on kernel feature and other nearly-identical tests are not failing, nor this test seems failing on other devices. Unfortunately the bug is very unactionable, I did not find a way to look at logs for the other tests (especially the SaveForBugreport_WriteIntoFile, I don't see how that wouldn't fail either as it's practically identical). Given this is a non-critical feature I don't see too many other options than disabling the test for now. Bug: 191940560 Change-Id: I3fe41e4a10d06b02610729bc22c926e923399366 Merged-In: I3fe41e4a10d06b02610729bc22c926e923399366
-rw-r--r--test/end_to_end_integrationtest.cc8
1 files changed, 7 insertions, 1 deletions
diff --git a/test/end_to_end_integrationtest.cc b/test/end_to_end_integrationtest.cc
index 63336412a..7b19368eb 100644
--- a/test/end_to_end_integrationtest.cc
+++ b/test/end_to_end_integrationtest.cc
@@ -1079,7 +1079,13 @@ TEST_F(PerfettoTest, SaveForBugreport_WriteIntoFile) {
// Tests that SaveTraceForBugreport() works also if the trace has triggers
// defined and those triggers have not been hit. This is a regression test for
// b/188008375 .
-TEST_F(PerfettoTest, SaveForBugreport_Triggers) {
+#if PERFETTO_BUILDFLAG(PERFETTO_ANDROID_BUILD)
+// Disabled due to b/191940560
+#define MAYBE_SaveForBugreport_Triggers DISABLED_SaveForBugreport_Triggers
+#else
+#define MAYBE_SaveForBugreport_Triggers SaveForBugreport_Triggers
+#endif
+TEST_F(PerfettoTest, MAYBE_SaveForBugreport_Triggers) {
base::TestTaskRunner task_runner;
TestHelper helper(&task_runner);