diff options
| author | Handa Wang <7058128+superwhd@users.noreply.github.com> | 2024-03-28 23:35:45 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-28 08:35:45 -0700 |
| commit | 077a43d8b0005276f16c7631eba13020cdb62190 (patch) | |
| tree | 0f8b3513178b5940c6b2f4346b22ba23e499deac | |
| parent | 253be50f837451173eb3c02f899615eb03e0c085 (diff) | |
| download | ot-br-posix-077a43d8b0005276f16c7631eba13020cdb62190.tar.gz | |
[border-agent] remove duplicate Thread state callback registrations (#2233)
This commit lets the `BorderAgent` register the Thread state callback
in the constructor instead of `Start()` so that it won't register a
new callback every time it starts.
| -rw-r--r-- | src/border_agent/border_agent.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/border_agent/border_agent.cpp b/src/border_agent/border_agent.cpp index c2becdef..b6acf18c 100644 --- a/src/border_agent/border_agent.cpp +++ b/src/border_agent/border_agent.cpp @@ -143,6 +143,7 @@ BorderAgent::BorderAgent(otbr::Ncp::ControllerOpenThread &aNcp, Mdns::Publisher , mProductName(OTBR_PRODUCT_NAME) , mBaseServiceInstanceName(OTBR_MESHCOP_SERVICE_INSTANCE_NAME) { + mNcp.AddThreadStateChangedCallback([this](otChangedFlags aFlags) { HandleThreadStateChanged(aFlags); }); } otbrError BorderAgent::SetMeshCopServiceValues(const std::string &aServiceInstanceName, @@ -186,8 +187,6 @@ void BorderAgent::Start(void) { otbrLogInfo("Start Thread Border Agent"); - mNcp.AddThreadStateChangedCallback([this](otChangedFlags aFlags) { HandleThreadStateChanged(aFlags); }); - #if OTBR_ENABLE_DBUS_SERVER mNcp.GetThreadHelper()->SetUpdateMeshCopTxtHandler([this](std::map<std::string, std::vector<uint8_t>> aUpdate) { HandleUpdateVendorMeshCoPTxtEntries(std::move(aUpdate)); |