aboutsummaryrefslogtreecommitdiff
path: root/nullaway/src/main/java/com/uber/nullaway/handlers/MethodNameUtil.java
blob: 1a276bb428c667b24e821e191f2e9341656dd66e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
package com.uber.nullaway.handlers;

/*
 * Copyright (c) 2019 Uber Technologies, Inc.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

import com.google.errorprone.util.ASTHelpers;
import com.sun.tools.javac.code.Symbol;
import com.sun.tools.javac.util.Name;
import com.uber.nullaway.annotations.Initializer;
import org.checkerframework.nullaway.dataflow.cfg.node.MethodInvocationNode;
import org.checkerframework.nullaway.dataflow.cfg.node.Node;

/**
 * A utility class that holds the names from the Table. Currently, {@link
 * com.uber.nullaway.handlers.AssertionHandler} requires it, while {@link
 * com.uber.nullaway.handlers.OptionalEmptinessHandler} uses it only when AssertionHandler is
 * enabled.
 */
class MethodNameUtil {

  // Strings corresponding to the names of the methods (and their owners) used to identify
  // assertions in this handler.
  private static final String IS_NOT_NULL_METHOD = "isNotNull";
  private static final String IS_OWNER_TRUTH_SUBJECT = "com.google.common.truth.Subject";
  private static final String IS_OWNER_ASSERTJ_ABSTRACT_ASSERT =
      "org.assertj.core.api.AbstractAssert";
  private static final String IS_INSTANCE_OF_METHOD = "isInstanceOf";
  private static final String IS_INSTANCE_OF_ANY_METHOD = "isInstanceOfAny";
  private static final String IS_TRUE_METHOD = "isTrue";
  private static final String IS_FALSE_METHOD = "isFalse";
  private static final String IS_TRUE_OWNER_TRUTH = "com.google.common.truth.BooleanSubject";
  private static final String IS_TRUE_OWNER_ASSERTJ = "org.assertj.core.api.AbstractBooleanAssert";
  private static final String BOOLEAN_VALUE_OF_METHOD = "valueOf";
  private static final String BOOLEAN_VALUE_OF_OWNER = "java.lang.Boolean";
  private static final String IS_PRESENT_METHOD = "isPresent";
  private static final String IS_NOT_EMPTY_METHOD = "isNotEmpty";
  private static final String IS_PRESENT_OWNER_ASSERTJ =
      "org.assertj.core.api.AbstractOptionalAssert";
  private static final String ASSERT_THAT_METHOD = "assertThat";
  private static final String AS_METHOD = "as";
  private static final String DESCRIBED_AS_METHOD = "describedAs";

  private static final String ASSERT_THAT_OWNER_TRUTH = "com.google.common.truth.Truth";
  private static final String ASSERT_THAT_OWNER_ASSERTJ = "org.assertj.core.api.Assertions";

  private static final String HAMCREST_ASSERT_CLASS = "org.hamcrest.MatcherAssert";
  private static final String JUNIT_ASSERT_CLASS = "org.junit.Assert";
  private static final String JUNIT5_ASSERTION_CLASS = "org.junit.jupiter.api.Assertions";

  private static final String ASSERT_TRUE_METHOD = "assertTrue";
  private static final String ASSERT_FALSE_METHOD = "assertFalse";

  private static final String MATCHERS_CLASS = "org.hamcrest.Matchers";
  private static final String CORE_MATCHERS_CLASS = "org.hamcrest.CoreMatchers";
  private static final String CORE_IS_NULL_CLASS = "org.hamcrest.core.IsNull";
  private static final String IS_MATCHER = "is";
  private static final String IS_A_MATCHER = "isA";
  private static final String NOT_MATCHER = "not";
  private static final String NOT_NULL_VALUE_MATCHER = "notNullValue";
  private static final String NULL_VALUE_MATCHER = "nullValue";
  private static final String INSTANCE_OF_MATCHER = "instanceOf";

  // Names of the methods (and their owners) used to identify assertions in this handler. Name used
  // here refers to com.sun.tools.javac.util.Name. Comparing methods using Names is faster than
  // comparing using strings.
  private Name isNotNull;

  private Name isInstanceOf;
  private Name isInstanceOfAny;
  private Name isOwnerTruthSubject;
  private Name isOwnerAssertJAbstractAssert;

  private Name isTrue;
  private Name isFalse;
  private Name isTrueOwnerTruth;
  private Name isTrueOwnerAssertJ;
  private Name isPresent;
  private Name isNotEmpty;
  private Name isPresentOwnerAssertJ;

  private Name isBooleanValueOfMethod;
  private Name isBooleanValueOfOwner;

  private Name assertThat;
  private Name assertThatOwnerTruth;
  private Name assertThatOwnerAssertJ;

  private Name as;
  private Name describedAs;

  // Names for junit assertion libraries.
  private Name hamcrestAssertClass;
  private Name junitAssertClass;
  private Name junit5AssertionClass;

  private Name assertTrue;
  private Name assertFalse;

  // Names for hamcrest matchers.
  private Name matchersClass;
  private Name coreMatchersClass;
  private Name coreIsNullClass;
  private Name isMatcher;
  private Name isAMatcher;
  private Name notMatcher;
  private Name notNullValueMatcher;
  private Name nullValueMatcher;
  private Name instanceOfMatcher;

  @Initializer
  void initializeMethodNames(Name.Table table) {
    isNotNull = table.fromString(IS_NOT_NULL_METHOD);
    isOwnerTruthSubject = table.fromString(IS_OWNER_TRUTH_SUBJECT);
    isOwnerAssertJAbstractAssert = table.fromString(IS_OWNER_ASSERTJ_ABSTRACT_ASSERT);

    isInstanceOf = table.fromString(IS_INSTANCE_OF_METHOD);
    isInstanceOfAny = table.fromString(IS_INSTANCE_OF_ANY_METHOD);

    isTrue = table.fromString(IS_TRUE_METHOD);
    isFalse = table.fromString(IS_FALSE_METHOD);
    isTrueOwnerTruth = table.fromString(IS_TRUE_OWNER_TRUTH);
    isTrueOwnerAssertJ = table.fromString(IS_TRUE_OWNER_ASSERTJ);

    isBooleanValueOfMethod = table.fromString(BOOLEAN_VALUE_OF_METHOD);
    isBooleanValueOfOwner = table.fromString(BOOLEAN_VALUE_OF_OWNER);

    assertThat = table.fromString(ASSERT_THAT_METHOD);
    assertThatOwnerTruth = table.fromString(ASSERT_THAT_OWNER_TRUTH);
    assertThatOwnerAssertJ = table.fromString(ASSERT_THAT_OWNER_ASSERTJ);

    as = table.fromString(AS_METHOD);
    describedAs = table.fromString(DESCRIBED_AS_METHOD);

    isPresent = table.fromString(IS_PRESENT_METHOD);
    isNotEmpty = table.fromString(IS_NOT_EMPTY_METHOD);
    isPresentOwnerAssertJ = table.fromString(IS_PRESENT_OWNER_ASSERTJ);

    hamcrestAssertClass = table.fromString(HAMCREST_ASSERT_CLASS);
    junitAssertClass = table.fromString(JUNIT_ASSERT_CLASS);
    junit5AssertionClass = table.fromString(JUNIT5_ASSERTION_CLASS);

    assertTrue = table.fromString(ASSERT_TRUE_METHOD);
    assertFalse = table.fromString(ASSERT_FALSE_METHOD);

    matchersClass = table.fromString(MATCHERS_CLASS);
    coreMatchersClass = table.fromString(CORE_MATCHERS_CLASS);
    coreIsNullClass = table.fromString(CORE_IS_NULL_CLASS);
    isMatcher = table.fromString(IS_MATCHER);
    isAMatcher = table.fromString(IS_A_MATCHER);
    notMatcher = table.fromString(NOT_MATCHER);
    notNullValueMatcher = table.fromString(NOT_NULL_VALUE_MATCHER);
    nullValueMatcher = table.fromString(NULL_VALUE_MATCHER);
    instanceOfMatcher = table.fromString(INSTANCE_OF_MATCHER);
  }

  boolean isMethodIsNotNull(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, isNotNull, isOwnerTruthSubject)
        || matchesMethod(methodSymbol, isNotNull, isOwnerAssertJAbstractAssert);
  }

  boolean isMethodIsInstanceOf(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, isInstanceOf, isOwnerTruthSubject)
        || matchesMethod(methodSymbol, isInstanceOf, isOwnerAssertJAbstractAssert)
        // Truth doesn't seem to have isInstanceOfAny
        || matchesMethod(methodSymbol, isInstanceOfAny, isOwnerAssertJAbstractAssert);
  }

  boolean isMethodAssertTrue(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, assertTrue, junitAssertClass)
        || matchesMethod(methodSymbol, assertTrue, junit5AssertionClass);
  }

  boolean isMethodAssertFalse(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, assertFalse, junitAssertClass)
        || matchesMethod(methodSymbol, assertFalse, junit5AssertionClass);
  }

  boolean isMethodThatEnsuresOptionalPresent(Symbol.MethodSymbol methodSymbol) {
    // same owner
    return matchesMethod(methodSymbol, isPresent, isPresentOwnerAssertJ)
        || matchesMethod(methodSymbol, isNotEmpty, isPresentOwnerAssertJ);
  }

  boolean isMethodIsTrue(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, isTrue, isTrueOwnerTruth)
        || matchesMethod(methodSymbol, isTrue, isTrueOwnerAssertJ);
  }

  boolean isMethodIsFalse(Symbol.MethodSymbol methodSymbol) {
    // same owners as isTrue
    return matchesMethod(methodSymbol, isFalse, isTrueOwnerTruth)
        || matchesMethod(methodSymbol, isFalse, isTrueOwnerAssertJ);
  }

  boolean isMethodBooleanValueOf(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, isBooleanValueOfMethod, isBooleanValueOfOwner);
  }

  boolean isMethodAssertThat(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, assertThat, assertThatOwnerTruth)
        || matchesMethod(methodSymbol, assertThat, assertThatOwnerAssertJ);
  }

  /**
   * Returns true if the method is describedAs() or as() from AssertJ. Note that this implementation
   * does not check the ower, as there are many possible implementations. This method should only be
   * used in a caller content where it is clear that the operation is related to use of AssertJ.
   *
   * @param methodSymbol symbol for the method
   * @return {@code true} iff the method is describedAs() or as() from AssertJ
   */
  public boolean isMethodAssertJDescribedAs(Symbol.MethodSymbol methodSymbol) {
    return methodSymbol.name.equals(as) || methodSymbol.name.equals(describedAs);
  }

  boolean isMethodHamcrestAssertThat(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, assertThat, hamcrestAssertClass);
  }

  boolean isMethodJunitAssertThat(Symbol.MethodSymbol methodSymbol) {
    return matchesMethod(methodSymbol, assertThat, junitAssertClass);
  }

  boolean isMatcherIsNotNull(Node node) {
    // Matches with
    //   * is(not(nullValue()))
    //   * is(notNullValue())
    if (matchesMatcherMethod(node, isMatcher, matchersClass)
        || matchesMatcherMethod(node, isMatcher, coreMatchersClass)) {
      // All overloads of `is` method have exactly one argument.
      return isMatcherNotNull(((MethodInvocationNode) node).getArgument(0));
    }
    return false;
  }

  private boolean isMatcherNotNull(Node node) {
    // Matches with
    //   * not(nullValue())
    //   * notNullValue()
    if (matchesMatcherMethod(node, notMatcher, matchersClass)
        || matchesMatcherMethod(node, notMatcher, coreMatchersClass)) {
      // All overloads of `not` method have exactly one argument.
      return isMatcherNull(((MethodInvocationNode) node).getArgument(0));
    }
    return matchesMatcherMethod(node, notNullValueMatcher, matchersClass)
        || matchesMatcherMethod(node, notNullValueMatcher, coreMatchersClass)
        || matchesMatcherMethod(node, notNullValueMatcher, coreIsNullClass);
  }

  private boolean isMatcherNull(Node node) {
    // Matches with nullValue()
    return matchesMatcherMethod(node, nullValueMatcher, matchersClass)
        || matchesMatcherMethod(node, nullValueMatcher, coreMatchersClass)
        || matchesMatcherMethod(node, nullValueMatcher, coreIsNullClass);
  }

  boolean isMatcherIsInstanceOf(Node node) {
    // Matches with
    //   * is(instanceOf(Some.class))
    //   * isA(Some.class)
    if (matchesMatcherMethod(node, isMatcher, matchersClass)
        || matchesMatcherMethod(node, isMatcher, coreMatchersClass)) {
      // All overloads of `is` method have exactly one argument.
      Node inner = ((MethodInvocationNode) node).getArgument(0);
      return matchesMatcherMethod(inner, instanceOfMatcher, matchersClass)
          || matchesMatcherMethod(inner, instanceOfMatcher, coreMatchersClass);
    }
    return (matchesMatcherMethod(node, isAMatcher, matchersClass)
        || matchesMatcherMethod(node, isAMatcher, coreMatchersClass));
  }

  private boolean matchesMatcherMethod(Node node, Name matcherName, Name matcherClass) {
    if (node instanceof MethodInvocationNode) {
      MethodInvocationNode methodInvocationNode = (MethodInvocationNode) node;
      Symbol.MethodSymbol callee = ASTHelpers.getSymbol(methodInvocationNode.getTree());
      return matchesMethod(callee, matcherName, matcherClass);
    }
    return false;
  }

  private boolean matchesMethod(
      Symbol.MethodSymbol methodSymbol, Name toMatchMethodName, Name toMatchOwnerName) {
    return methodSymbol.name.equals(toMatchMethodName)
        && methodSymbol.owner.getQualifiedName().equals(toMatchOwnerName);
  }

  boolean isUtilInitialized() {
    return isNotNull != null;
  }
}