diff options
| author | scivision <scivision@users.noreply.github.com> | 2024-01-16 12:56:15 -0500 |
|---|---|---|
| committer | scivision <scivision@users.noreply.github.com> | 2024-01-16 12:58:46 -0500 |
| commit | 8b42a300bd57b93a8037e5097041c639ade8f9db (patch) | |
| tree | 1792db194e02bc0d8bd920dcc5e54cabea068127 | |
| parent | fd7067652cae480190bf13b2ee5475efdf09ac7d (diff) | |
| download | ninja-8b42a300bd57b93a8037e5097041c639ade8f9db.tar.gz | |
correction to #2360
in general, flags check have to be to the non-no option.
Updates use of deprecated CMake command.
| -rw-r--r-- | CMakeLists.txt | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 8a5ef00..90e3418 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -255,9 +255,9 @@ if(BUILD_TESTING) # NOTE: gtest uninit some variables, gcc >= 1.11.3 may cause error on compile. # Remove this comment and six lines below, once ninja deps gtest-1.11.0 or above. - if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "1.11.3") - check_cxx_compiler_flag(-Wno-maybe-uninitialized flag_no_maybe_uninit) - if (flag_no_maybe_uninit) + if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "1.11.3") + check_cxx_compiler_flag(-Wmaybe-uninitialized flag_maybe_uninit) + if (flag_maybe_uninit) target_compile_options(gtest PRIVATE -Wno-maybe-uninitialized) endif() endif() |