Age | Commit message (Collapse) | Author |
|
am: 847d15f64a
Change-Id: Id10e5c86216fb21c6fd631ae526ecd760220b42d
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347500 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 64de154440
Change-Id: If626c2e64fb9fed381f839ac1c153143cb0b6f2c
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347491 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 5fc600b647
Change-Id: I3d55ab73594e5e240b44c60ba18c76e6b07b6afe
|
|
am: e037b673a6
Change-Id: Icb8dbd9e1f5115877e6e1a091305430f5e4c8549
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347418 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
Summary: Right now only some platforms add pthread to the compilation, however, at least one of the tests requires the pthread library on Linux as well. Since the library is available, this change adds it by default on Linux.
Reviewers: labath, zturner, asmith
Subscribers: stella.stamenova, jfb, lldb-commits
Differential Revision: https://reviews.llvm.org/D54808
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347412 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 2ae14c637f
Change-Id: Ie0797421693bbf009e9178ac5f6c47993292cca4
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347391 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 0d6a8ba20f
Change-Id: If45295d268018534db723f924e9c505f44866c64
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347365 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 0acfb3aa0f
Change-Id: Ibff093dc2e3002c20e24006ac3434613e2e16d7c
|
|
If we just invoke clang-cl without specifying the linker, the tests fail on Windows because they cannot find the correct linker to use, so it needs to be specified explicitly
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347323 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
pass on Windows as written as they don't even build
am: 1d5d244291
Change-Id: I623b888eabdb79bc3f88de01ff83195b7ee35942
|
|
These tests are not able to pass on Windows as written as they don't even build
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347321 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
extended llvm_codesign
am: 5b794a9dc2
Change-Id: I14d240fffc02f20f9990a444120a05d37c107f49
|
|
extended llvm_codesign
Summary:
Use llvm_codesign to sign debugserver with entitlements.
Set global LLVM_CODESIGNING_IDENTITY from LLDB_CODESIGN_IDENTITY (if given).
Pass through ENTITLEMENTS from add_lldb_executable to add_llvm_executable.
Handle reconfigurations correctly.
We have a lot of cases, make them explicit:
(1) build and sign debugserver, if all conditions apply:
* LLDB_NO_DEBUGSERVER=OFF (default)
* On Darwin: LLDB_USE_SYSTEM_DEBUGSERVER=OFF (default)
* On Darwin: LLVM_CODESIGNING_IDENTITY == lldb_codesign
(2) use system debugserver, if on Darwin and any of:
* LLDB_USE_SYSTEM_DEBUGSERVER=ON and found on system (explicit case)
* LLVM_CODESIGNING_IDENTITY != lldb_codesign and found on system (fallback case)
(3) debugserver will not be available, in case of:
* LLDB_NO_DEBUGSERVER=ON
* On Darwin: LLVM_CODESIGNING_IDENTITY != lldb_codesign and not found on system
(4) error state, in case of:
* LLDB_USE_SYSTEM_DEBUGSERVER=ON and not found on system
* LLDB_USE_SYSTEM_DEBUGSERVER=ON and LLDB_NO_DEBUGSERVER=ON
Reviewers: xiaobai, beanz, vsk, JDevlieghere
Subscribers: mgorny, lldb-commits, llvm-commits
Differential Revision: https://reviews.llvm.org/D54476
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347305 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 2e910faf8e
Change-Id: Id0671244c33e77569edd3beb04d5451f6f67fa21
|
|
Skip this test because Windows deals differently with shared libraries.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347283 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 9540d32006
Change-Id: I139384de863e45f54c0f9e2a15234983ea696c0d
|
|
Otherwise, the clang analyzer tests fail on Windows when attempting to
unpickle AnalyzerTest objects in the worker processes. The pattern of,
add to path, import, remove from path, serialize, deserialize, doesn't
work. Once something gets added to the path, if we want to move it
across the wire for multiprocessing, we need to keep the module on
sys.path.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347254 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 94ceb3a7ec
Change-Id: I703f5338e19178c2724b2c9534478aa263d6c4bb
|
|
Summary: In order to invoke sed on Windows, we need to quote the command correctly. Since we already have commands which do that, move the definitions at the beginning of the file and then re-use them for each command.
Reviewers: aprantl, zturner
Subscribers: teemperor, lldb-commits
Differential Revision: https://reviews.llvm.org/D54709
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347243 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 6ba773043d
Change-Id: I39e87596436eb8356c8bf2f05a857761f1495393
|
|
am: d24032e6c9
Change-Id: Ibb60e85ffd0788d9127a4a61eecc8c100f4fd858
|
|
We had some logic backwards, and as a result if MSVC was not found
in PATH we would throw a string concatenation exception.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347224 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
It's not clear how these ended up in the file, but this fixes it.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347223 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 9ef3f4bc64
Change-Id: I086297eea2d800e5aa377c1a61e8d6b138671c33
|
|
am: a7dac89803
Change-Id: Iaf1964ea791ecb719319caec10013a99ca86fbf5
|
|
Recently I tried to port LLDB's lit configuration files over to use a
on the surface, but broke some cases that weren't broken before and also
exposed some additional problems with the old approach that we were just
getting lucky with.
When we set up a lit environment, the goal is to make it as hermetic as
possible. We should not be relying on PATH and enabling the use of
arbitrary shell commands. Instead, only whitelisted commands should be
allowed. These are, generally speaking, the lit builtins such as echo,
cd, etc, as well as anything for which substitutions have been
explicitly set up for. These substitutions should map to the build
output directory, but in some cases it's useful to be able to override
this (for example to point to an installed tools directory).
This is, of course, how it's supposed to work. What was actually
happening is that we were bringing in PATH and LD_LIBRARY_PATH and then
just running the given run line as a shell command. This led to problems
such as finding the wrong version of clang-cl on PATH since it wasn't
even a substitution, and flakiness / non-determinism since the
environment the tests were running in would change per-machine. On the
other hand, it also made other things possible. For example, we had some
tests that were explicitly running cl.exe and link.exe instead of
clang-cl and lld-link and the only reason it worked at all is because it
was finding them on PATH. Unfortunately we can't entirely get rid of
these tests, because they support a few things in debug info that
clang-cl and lld-link don't (notably, the LF_UDT_MOD_SRC_LINE record
which makes some of the tests fail.
The high level changes introduced in this patch are:
1. Removal of functionality - The lit test suite no longer respects
LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER. This means there is no
more support for gcc, but nobody was using this anyway (note: The
functionality is still there for the dotest suite, just not the lit test
suite). There is no longer a single substitution %cxx and %cc which maps
to <arbitrary-compiler>, you now explicitly specify the compiler with a
substitution like %clang or %clangxx or %clang_cl. We can revisit this
in the future when someone needs gcc.
2. Introduction of the LLDB_LIT_TOOLS_DIR directory. This does in spirit
what LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER used to do, but now
more friendly. If this is not specified, all tools are expected to be
the just-built tools. If it is specified, the tools which are not
themselves being tested but are being used to construct and run checks
(e.g. clang, FileCheck, llvm-mc, etc) will be searched for in this
directory first, then the build output directory.
3. Changes to core llvm lit files. The use_lld() and use_clang()
functions were introduced long ago in anticipation of using them in
lldb, but since they were never actually used anywhere but their
respective problems, there were some issues to be resolved regarding
generality and ability to use them outside their project.
4. Changes to .test files - These are all just replacing things like
clang-cl with %clang_cl and %cxx with %clangxx, etc.
5. Changes to lit.cfg.py - Previously we would load up some system
environment variables and then add some new things to them. Then do a
bunch of work building out our own substitutions. First, we delete the
system environment variable code, making the environment hermetic. Then,
we refactor the substitution logic into two separate helper functions,
one which sets up substitutions for the tools we want to test (which
must come from the build output directory), and another which sets up
substitutions for support tools (like compilers, etc).
6. New substitutions for MSVC -- Previously we relied on location of
MSVC by bringing in the entire parent's PATH and letting
subprocess.Popen just run the command line. Now we set up real
substitutions that should have the same effect. We use PATH to find
them, and then look for INCLUDE and LIB to construct a substitution
command line with appropriate /I and /LIBPATH: arguments. The nice thing
about this is that it opens the door to having separate %msvc-cl32 and
%msvc-cl64 substitutions, rather than only requiring the user to run
vcvars first. Because we can deduce the path to 32-bit libraries from
64-bit library directories, and vice versa. Without these substitutions
this would have been impossible.
Differential Revision: https://reviews.llvm.org/D54567
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347216 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
Because of different shell quoting rules, and the fact that LLDB
commands often contain spaces, -O is not portable for writing command
lines. Instead, we should use explicit lldbinit files.
Differential Revision: https://reviews.llvm.org/D54680
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347213 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: e228882377
Change-Id: I6797a06227e61dc2d78fa8a5ff75ec1a8e72c1d6
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347188 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: faff1fe25c
Change-Id: I09fe89c1a301d026044f65a41031e47349b2daec
|
|
This breaks many tests on Windows, which now all fail with an error such
as "Unable to read memory at address <xxxxxxxx>".
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347174 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 65b3d74054
Change-Id: I6c85850cf12b968821e7b148ac2af1855b738542
|
|
am: 46eeb39620
Change-Id: I9b0e654d2c62e129f3a80bc1a036106f574c4fa4
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347125 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347124 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 3b3f366054
Change-Id: Ib3b5f76eaa2b1623458e02800a945b5fc9d2661c
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347122 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 4da94a8b83
Change-Id: Ia6fbddad6b64f594cfd7216222770454bf2a78ca
|
|
am: 47916947ab
Change-Id: I8abc8b8a8d0abbd7a443cea198a5fb379d808d26
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347120 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
Different versions of Xcode have different outputs for the simctl command
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347117 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: df17fb772f
Change-Id: Ia8e4f4605a2c571995677df801a6739e01487aa4
|
|
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347114 91177308-0d34-0410-b5e6-96231b3b80d8
|
|
am: 29537130ad
Change-Id: Ibf5f0ae3fbf407337b441ab73b23031fdf42d680
|
|
Those tests were using pexpect and being flaky on some of ours bots.
This patch reimplmeents the tests usinf FileCheck, and it also
extends the test coverage to a few more stop-hook options.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@347109 91177308-0d34-0410-b5e6-96231b3b80d8
|