aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndy Green <andy@warmcat.com>2021-10-17 07:48:40 +0100
committerAndy Green <andy@warmcat.com>2021-11-08 11:08:45 +0000
commit3e1a1a443dd5c904e8773c425f9bdbeea8a43f08 (patch)
tree6a4dfefb4ef1ea203fd8ef6e1b13f1964658b3b2
parentf9fc45bd9896e19b00a40da64134845ccf5fcea0 (diff)
downloadlibwebsockets-3e1a1a443dd5c904e8773c425f9bdbeea8a43f08.tar.gz
coverity: client_reset: no longer any way to get NULL *pwsi
Coverity belatedly noticed that client_reset no longer changes *pwsi
-rw-r--r--lib/roles/http/client/client-http.c14
1 files changed, 1 insertions, 13 deletions
diff --git a/lib/roles/http/client/client-http.c b/lib/roles/http/client/client-http.c
index 221f394d..7dce8500 100644
--- a/lib/roles/http/client/client-http.c
+++ b/lib/roles/http/client/client-http.c
@@ -819,21 +819,9 @@ lws_client_interpret_server_handshake(struct lws *wsi)
}
if (!lws_client_reset(&wsi, ssl, ads, port, path, ads, 1)) {
- /*
- * There are two ways to fail out with NULL return...
- * simple, early problem where the wsi is intact, or
- * we went through with the reconnect attempt and the
- * wsi is already closed. In the latter case, the wsi
- * has been set to NULL additionally.
- */
lwsl_err("Redirect failed\n");
cce = "HS: Redirect failed";
- /* coverity[reverse_inull] */
- if (wsi)
- goto bail3;
-
- /* wsi has closed */
- return 1;
+ goto bail3;
}
/*