diff options
| author | Roberto Alanis <alanisbaez@google.com> | 2021-12-01 07:19:06 +0000 |
|---|---|---|
| committer | Roberto Alanis <alanisbaez@google.com> | 2021-12-07 23:35:30 +0000 |
| commit | 58b91b0ec405e2c7f623b051c85d5116a540071a (patch) | |
| tree | 6f16906242888fecfd48203d76d3408c5d2bf271 | |
| parent | 206d268d4d8066e5a37c49025325b80c95c771dd (diff) | |
| download | libwebm-58b91b0ec405e2c7f623b051c85d5116a540071a.tar.gz | |
patch-check: commit subject length check
Change-Id: I745f819cdf7736ac315ddab059d9ddba30f35f1f
Bug: b:185520494
| -rw-r--r-- | PRESUBMIT.py | 31 |
1 files changed, 31 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 9dcbf38..fb6f32d 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -32,15 +32,45 @@ See https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for details on the presubmit API built into depot_tools. """ +import re import subprocess2 USE_PYTHON3 = True _BASH_INDENTATION = "2" +_GIT_COMMIT_SUBJECT_LENGTH = 65 _INCLUDE_BASH_FILES_ONLY = [r".*\.sh$"] _INCLUDE_SOURCE_FILES_ONLY = [r".*\.(c|cc|[hc]pp|h)$"] _LIBWEBM_MAX_LINE_LENGTH = 80 +def _CheckCommitSubjectLength(input_api, output_api): + """Ensures commit's subject length is no longer than 65 chars.""" + name = "git-commit subject" + cmd = ["git", "log", "-1", "--pretty=%s"] + start = input_api.time.time() + proc = subprocess2.Popen( + cmd, + stderr=subprocess2.PIPE, + stdout=subprocess2.PIPE, + universal_newlines=True) + + stdout, _ = proc.communicate() + duration = input_api.time.time() - start + + if not re.match(r"^Revert", + stdout) and (len(stdout) - 1) > _GIT_COMMIT_SUBJECT_LENGTH: + failure_msg = ( + "The commit subject: %s is too long (%d chars)\n" + "Try to keep this to 50 or lessor less (up to 65 is permitted for " + "non-reverts).\n" + "https://www.git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-" + "Project#_commit_guidelines") % (stdout, len(stdout) - 1) + return output_api.PresubmitError("%s\n (%4.2fs) failed\n%s" % + (name, duration, failure_msg)) + + return output_api.PresubmitResult("%s\n (%4.2fs) success" % (name, duration)) + + def _GetFilesToSkip(input_api): """Skips libwebm-specific files.""" return list(input_api.DEFAULT_FILES_TO_SKIP) + [ @@ -112,6 +142,7 @@ def _CommonChecks(input_api, output_api): results.extend( input_api.canned_checks.CheckChangeHasNoStrayWhitespace( input_api, output_api)) + results.append(_CheckCommitSubjectLength(input_api, output_api)) source_file_filter = lambda x: input_api.FilterSourceFile( x, files_to_skip=_GetFilesToSkip(input_api)) |