diff options
| author | dcashman <dcashman@google.com> | 2016-02-22 15:25:51 -0800 |
|---|---|---|
| committer | dcashman <dcashman@google.com> | 2016-02-23 08:08:14 -0800 |
| commit | ae9473b3eb92d952fc04d3846b376c412f992553 (patch) | |
| tree | f0f3495e9d963d54c0e81171934900ebb70e785a | |
| parent | 640db2f86f237868d038b2fedc05aad154b5fe43 (diff) | |
| download | libselinux-ae9473b3eb92d952fc04d3846b376c412f992553.tar.gz | |
Return error on invalid pid_t input to procattr funcs.
(cherry-pick of commit: https://android-review.googlesource.com/#/c/203372/)
AOSP Bug: 200617
Bug: 27111481
Change-Id: Ib269a35686aa19b4b57697886ae27913842b707a
| -rw-r--r-- | src/procattr.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/procattr.c b/src/procattr.c index 8569f82..e88e224 100644 --- a/src/procattr.c +++ b/src/procattr.c @@ -21,9 +21,9 @@ static int openattr(pid_t pid, const char *attr, int flags) char *path; pid_t tid; - if (pid > 0) + if (pid > 0) { rc = asprintf(&path, "/proc/%d/attr/%s", pid, attr); - else { + } else if (pid == 0) { rc = asprintf(&path, "/proc/thread-self/attr/%s", attr); if (rc < 0) return -1; @@ -33,6 +33,9 @@ static int openattr(pid_t pid, const char *attr, int flags) free(path); tid = gettid(); rc = asprintf(&path, "/proc/self/task/%d/attr/%s", tid, attr); + } else { + errno = -EINVAL; + return -1; } if (rc < 0) return -1; |